diff --git a/core/core.services.yml b/core/core.services.yml index b3b0228..65e0a40 100644 --- a/core/core.services.yml +++ b/core/core.services.yml @@ -32,7 +32,7 @@ services: class: Drupal\Core\Cache\TimeZoneCacheContext tags: - { name: cache.context} - cache_tags_invalidator: + cache_tags.invalidator: class: Drupal\Core\Cache\CacheTagsInvalidator calls: - [setContainer, ['@service_container']] @@ -42,7 +42,7 @@ services: class: Drupal\Core\Cache\DatabaseCacheTagsChecksum arguments: ['@database'] tags: - - { name: cache_tags_invalidator} + - { name: cache_tags.invalidator} cache.backend.chainedfast: class: Drupal\Core\Cache\ChainedFastBackendFactory arguments: ['@settings'] diff --git a/core/lib/Drupal/Core/Cache/Cache.php b/core/lib/Drupal/Core/Cache/Cache.php index a38df0e..4ce3610 100644 --- a/core/lib/Drupal/Core/Cache/Cache.php +++ b/core/lib/Drupal/Core/Cache/Cache.php @@ -100,7 +100,7 @@ public static function buildTags($prefix, array $suffixes) { * The list of tags to invalidate cache items for. */ public static function invalidateTags(array $tags) { - \Drupal::service('cache_tags_invalidator')->invalidateTags($tags); + \Drupal::service('cache_tags.invalidator')->invalidateTags($tags); } /** diff --git a/core/lib/Drupal/Core/Cache/PhpBackend.php b/core/lib/Drupal/Core/Cache/PhpBackend.php index 7bcf861..df6ffa7 100644 --- a/core/lib/Drupal/Core/Cache/PhpBackend.php +++ b/core/lib/Drupal/Core/Cache/PhpBackend.php @@ -133,7 +133,7 @@ protected function prepareItem($cache, $allow_invalid) { $cache->valid = $cache->expire == Cache::PERMANENT || $cache->expire >= REQUEST_TIME; // Check if invalidateTags() has been called with any of the item's tags. - if (!$this->checksumProvider->isValid($cache->checksums, $cache->tags)) { + if (!$this->checksumProvider->isValid($cache->checksum, $cache->tags)) { $cache->valid = FALSE; } @@ -151,7 +151,6 @@ public function set($cid, $data, $expire = Cache::PERMANENT, array $tags = array if ($tags) { $tags = array_unique($tags); Cache::validateTags($tags); - $this->checksumProvider->onCacheTagsWrite($tags); } $item = (object) array( 'cid' => $cid, diff --git a/core/lib/Drupal/Core/Installer/InstallerServiceProvider.php b/core/lib/Drupal/Core/Installer/InstallerServiceProvider.php index 851ae71..15a7e79 100644 --- a/core/lib/Drupal/Core/Installer/InstallerServiceProvider.php +++ b/core/lib/Drupal/Core/Installer/InstallerServiceProvider.php @@ -53,7 +53,7 @@ public function register(ContainerBuilder $container) { // that we don't call it when cache tags are invalidated very early in the // installer. $container->getDefinition('cache_tags.checksum') - ->clearTag('cache_tags_invalidator'); + ->clearTag('cache_tags.invalidator'); // Replace the route builder with an empty implementation. // @todo Convert installer steps into routes; add an installer.routing.yml. diff --git a/core/modules/system/src/Tests/Cache/BackendChainUnitTest.php b/core/modules/system/src/Tests/Cache/BackendChainUnitTest.php index 39b797e..4c90701 100644 --- a/core/modules/system/src/Tests/Cache/BackendChainUnitTest.php +++ b/core/modules/system/src/Tests/Cache/BackendChainUnitTest.php @@ -26,7 +26,7 @@ protected function createCacheBackend($bin) { ->prependBackend(new MemoryBackend('bar')) ->appendBackend(new MemoryBackend('baz')); - \Drupal::service('cache_tags_invalidator')->addInvalidator($chain); + \Drupal::service('cache_tags.invalidator')->addInvalidator($chain); return $chain; } diff --git a/core/modules/system/src/Tests/Cache/ChainedFastBackendUnitTest.php b/core/modules/system/src/Tests/Cache/ChainedFastBackendUnitTest.php index 74d19d7..961c10a 100644 --- a/core/modules/system/src/Tests/Cache/ChainedFastBackendUnitTest.php +++ b/core/modules/system/src/Tests/Cache/ChainedFastBackendUnitTest.php @@ -27,7 +27,11 @@ class ChainedFastBackendUnitTest extends GenericCacheBackendUnitTestBase { protected function createCacheBackend($bin) { $consistent_backend = new DatabaseBackend(\Drupal::service('database'), \Drupal::service('cache_tags.checksum'), $bin); $fast_backend = new PhpBackend($bin, \Drupal::service('cache_tags.checksum')); - return new ChainedFastBackend($consistent_backend, $fast_backend, $bin); + $backend = new ChainedFastBackend($consistent_backend, $fast_backend, $bin); + // Explicitly register the cache bin as it can not work through the + // cache bin list in the container. + \Drupal::service('cache_tags.invalidator')->addInvalidator($backend); + return $backend; } } diff --git a/core/modules/system/src/Tests/Cache/MemoryBackendUnitTest.php b/core/modules/system/src/Tests/Cache/MemoryBackendUnitTest.php index b5b6916..0dfeae7 100644 --- a/core/modules/system/src/Tests/Cache/MemoryBackendUnitTest.php +++ b/core/modules/system/src/Tests/Cache/MemoryBackendUnitTest.php @@ -24,7 +24,7 @@ class MemoryBackendUnitTest extends GenericCacheBackendUnitTestBase { */ protected function createCacheBackend($bin) { $backend = new MemoryBackend($bin); - \Drupal::service('cache_tags_invalidator')->addInvalidator($backend); + \Drupal::service('cache_tags.invalidator')->addInvalidator($backend); return $backend; } } diff --git a/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityBaseUnitTest.php b/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityBaseUnitTest.php index 8405d8a..0480f52 100644 --- a/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityBaseUnitTest.php +++ b/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityBaseUnitTest.php @@ -129,7 +129,7 @@ protected function setUp() { $container->set('entity.manager', $this->entityManager); $container->set('uuid', $this->uuid); $container->set('language_manager', $this->languageManager); - $container->set('cache_tags_invalidator', $this->cacheTagsInvalidator); + $container->set('cache_tags.invalidator', $this->cacheTagsInvalidator); $container->set('config.typed', $this->typedConfigManager); \Drupal::setContainer($container); diff --git a/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityStorageTest.php b/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityStorageTest.php index d9edc78..24ce7d2 100644 --- a/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityStorageTest.php +++ b/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityStorageTest.php @@ -162,7 +162,7 @@ protected function setUp() { $container = new ContainerBuilder(); $container->set('entity.manager', $this->entityManager); $container->set('config.typed', $this->typedConfigManager); - $container->set('cache_tags_invalidator', $this->cacheTagsInvalidator); + $container->set('cache_tags.invalidator', $this->cacheTagsInvalidator); \Drupal::setContainer($container); } diff --git a/core/tests/Drupal/Tests/Core/Entity/EntityUnitTest.php b/core/tests/Drupal/Tests/Core/Entity/EntityUnitTest.php index 4ab0366..3f4029d 100644 --- a/core/tests/Drupal/Tests/Core/Entity/EntityUnitTest.php +++ b/core/tests/Drupal/Tests/Core/Entity/EntityUnitTest.php @@ -122,7 +122,7 @@ protected function setUp() { $container->set('entity.manager', $this->entityManager); $container->set('uuid', $this->uuid); $container->set('language_manager', $this->languageManager); - $container->set('cache_tags_invalidator', $this->cacheTagsInvalidator); + $container->set('cache_tags.invalidator', $this->cacheTagsInvalidator); \Drupal::setContainer($container); $this->entity = $this->getMockForAbstractClass('\Drupal\Core\Entity\Entity', array($this->values, $this->entityTypeId)); diff --git a/core/tests/Drupal/Tests/Core/Entity/KeyValueStore/KeyValueEntityStorageTest.php b/core/tests/Drupal/Tests/Core/Entity/KeyValueStore/KeyValueEntityStorageTest.php index 34127c5..79c5999 100644 --- a/core/tests/Drupal/Tests/Core/Entity/KeyValueStore/KeyValueEntityStorageTest.php +++ b/core/tests/Drupal/Tests/Core/Entity/KeyValueStore/KeyValueEntityStorageTest.php @@ -130,7 +130,7 @@ protected function setUpKeyValueEntityStorage($uuid_key = 'uuid') { $container = new ContainerBuilder(); $container->set('entity.manager', $this->entityManager); $container->set('language_manager', $this->languageManager); - $container->set('cache_tags_invalidator', $this->cacheTagsInvalidator); + $container->set('cache_tags.invalidator', $this->cacheTagsInvalidator); \Drupal::setContainer($container); } diff --git a/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php b/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php index 2c9a015..0e7ac2f 100644 --- a/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php +++ b/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php @@ -121,7 +121,7 @@ protected function setUp() { $logger = $this->getMock('Psr\Log\LoggerInterface'); $this->themeHandler = new TestThemeHandler($this->root, $this->configFactory, $this->moduleHandler, $this->state, $this->infoParser, $logger, $this->cssCollectionOptimizer, $this->configInstaller, $this->configManager, $this->routeBuilderIndicator, $this->extensionDiscovery); - $cache_tags_invalidator = $this->getMock('Drupal\Core\Cache\CacheTagsInvalidatorInterface'); + $cache_tags.invalidator = $this->getMock('Drupal\Core\Cache\CacheTagsInvalidatorInterface'); $this->getContainerWithCacheTagsInvalidator($cache_tags_invalidator); } diff --git a/core/tests/Drupal/Tests/UnitTestCase.php b/core/tests/Drupal/Tests/UnitTestCase.php index e4fc1d7..1a0ac77 100644 --- a/core/tests/Drupal/Tests/UnitTestCase.php +++ b/core/tests/Drupal/Tests/UnitTestCase.php @@ -208,7 +208,7 @@ protected function getContainerWithCacheTagsInvalidator(CacheTagsInvalidatorInte $container = $this->getMock('Symfony\Component\DependencyInjection\ContainerInterface'); $container->expects($this->any()) ->method('get') - ->with('cache_tags_invalidator') + ->with('cache_tags.invalidator') ->will($this->returnValue($cache_tags_validator)); \Drupal::setContainer($container);