diff --git a/core/modules/block/block.install b/core/modules/block/block.install new file mode 100644 index 0000000..29947f0 --- /dev/null +++ b/core/modules/block/block.install @@ -0,0 +1,47 @@ + 'language.current_language_context', + 'node' => 'node.node_route_context', + 'user' => 'user.current_user_context', + ]; + + $config_factory = \Drupal::configFactory(); + foreach ($config_factory->listAll('block.block.') as $block_config_name) { + $block = $config_factory->getEditable($block_config_name); + + if ($visibility = $block->get('visibility')) { + foreach ($visibility as &$condition) { + foreach ($condition['context_mapping'] as $key => $context) { + if (!isset($context_service_id_map[$key])) { + throw new \UnexpectedValueException(sprintf('Encountered an unexpected context mapping key %s', $key)); + } + $new_context_id = explode('.', $context, 2); + $condition['context_mapping'][$key] = '@' . $context_service_id_map[$key] . ':' . $new_context_id[1]; + } + } + + $block->set('visibility', $visibility); + } + + $block->save(); + } +} + +/** + * @} End of "addtogroup updates-8.0.x-beta". + */ diff --git a/core/modules/block/src/Tests/Update/BlockContextMappingUpdateTest.php b/core/modules/block/src/Tests/Update/BlockContextMappingUpdateTest.php new file mode 100644 index 0000000..29c25aa --- /dev/null +++ b/core/modules/block/src/Tests/Update/BlockContextMappingUpdateTest.php @@ -0,0 +1,77 @@ +databaseDumpFiles = [ + __DIR__ . '/../../../../system/tests/fixtures/update/drupal-8.bare.standard.php.gz', + __DIR__ . '/../../../../system/tests/fixtures/update/drupal-8.block-context-manager-2354889.php', + ]; + parent::setUp(); + } + + /** + * Tests that block context mapping are updated properly. + */ + public function testUpdateHookN() { + $this->runUpdates(); + + // Disable maintenance mode. + \Drupal::state()->set('system.maintenance_mode', FALSE); + + // The block that we are testing has the following visibility rules: + // - only visible on node pages + // - only visible to authenticated users. + $block_title = 'Test for 2354889'; + + // Create two nodes, a page and an article. + $page = Node::create([ + 'type' => 'page', + 'title' => 'Page node', + ]); + $page->save(); + + $article = Node::create([ + 'type' => 'article', + 'title' => 'Article node', + ]); + $article->save(); + + // Check that the block appears only on Page nodes for authenticated users. + $this->drupalGet('node/' . $page->id()); + $this->assertRaw($block_title, 'Test block is visible on a Page node as an authenticated user.'); + + $this->drupalGet('node/' . $article->id()); + $this->assertNoRaw($block_title, 'Test block is not visible on a Article node as an authenticated user.'); + + $this->drupalLogout(); + + // Check that the block does not appear on any page for anonymous users. + $this->drupalGet('node/' . $page->id()); + $this->assertNoRaw($block_title, 'Test block is not visible on a Page node as an anonymous user.'); + + $this->drupalGet('node/' . $article->id()); + $this->assertNoRaw($block_title, 'Test block is not visible on a Article node as an anonymous user.'); + } + +} diff --git a/core/modules/system/tests/fixtures/update/drupal-8.block-context-manager-2354889.php b/core/modules/system/tests/fixtures/update/drupal-8.block-context-manager-2354889.php new file mode 100644 index 0000000..34a810b --- /dev/null +++ b/core/modules/system/tests/fixtures/update/drupal-8.block-context-manager-2354889.php @@ -0,0 +1,117 @@ + '9d204071-a923-4707-8200-c298a540fb0c', + 'langcode' => 'en', + 'status' => TRUE, + 'dependencies' => [ + 'content' => [ + 'block_content:basic:c1895145-893e-460b-a24e-78cd2cefbb1f', + ], + 'module' => [ + 'block_content', + 'node', + 'user', + ], + 'theme' => [ + 'bartik', + ], + ], + 'id' => 'testfor2354889', + 'theme' => 'bartik', + 'region' => 'content', + 'weight' => -6, + 'provider' => NULL, + 'plugin' => 'block_content:c1895145-893e-460b-a24e-78cd2cefbb1f', + 'settings' => [ + 'id' => 'block_content:c1895145-893e-460b-a24e-78cd2cefbb1f', + 'label' => 'Test for 2354889', + 'provider' => 'block_content', + 'label_display' => 'visible', + 'cache' => [ + 'max_age' => -1, + ], + 'status' => TRUE, + 'info' => '', + 'view_mode' => 'full', + ], + 'visibility' => [ + 'node_type' => [ + 'id' => 'node_type', + 'bundles' => [ + 'page' => 'page', + ], + 'negate' => FALSE, + // Context that will be tested. + 'context_mapping' => [ + 'node' => 'node.node', + ], + ], + 'user_role' => [ + 'id' => 'user_role', + 'roles' => [ + 'authenticated' => 'authenticated', + ], + 'negate' => FALSE, + // Context that will be tested. + 'context_mapping' => [ + 'user' => 'user.current_user', + ], + ], + ], +],[ + 'uuid' => 'C499B41D-035E-432E-9462-36410C43C49F', + 'langcode' => 'en', + 'status' => TRUE, + 'dependencies' => [ + 'module' => [ + 'search', + ], + 'theme' => [ + 'bartik', + ], + ], + 'id' => 'secondtestfor2354889', + 'theme' => 'bartik', + 'region' => 'sidebar_first', + 'weight' => -6, + 'provider' => NULL, + 'plugin' => 'search_form_block', + 'settings' => [ + 'id' => 'search_form_block', + 'label' => 'Search', + 'provider' => 'search', + 'label_display' => 'visible', + 'cache' => [ + 'max_age' => -1, + ], + 'status' => TRUE, + ], + 'visibility' => [], +]]; + +foreach ($block_configs as $block_config) { + $connection->insert('config') + ->fields(array( + 'collection', + 'name', + 'data', + )) + ->values(array( + 'collection' => '', + 'name' => 'block.block.' . $block_config['id'], + 'data' => serialize($block_config), + )) + ->execute(); +}