diff -u b/core/modules/field_ui/src/Tests/ManageDisplayTest.php b/core/modules/field_ui/src/Tests/ManageDisplayTest.php --- b/core/modules/field_ui/src/Tests/ManageDisplayTest.php +++ b/core/modules/field_ui/src/Tests/ManageDisplayTest.php @@ -133,7 +133,7 @@ $this->drupalPostAjaxForm(NULL, $edit, "field_test_plugin_settings_update"); $this->assertText('Default empty setting now has a value.'); - // Test the settings form behavior. We should need have an edit button since + // Test the settings form behavior. An edit button should be present since // there are thrid party settings to configure. $edit = array('fields[field_test][type]' => 'field_no_settings', 'refresh_rows' => 'field_test'); $this->drupalPostAjaxForm(NULL, $edit, array('op' => t('Refresh'))); only in patch2: unchanged: --- a/core/modules/comment/src/Plugin/Field/FieldFormatter/CommentDefaultFormatter.php +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/CommentDefaultFormatter.php @@ -75,6 +75,7 @@ public static function create(ContainerInterface $container, array $configuratio $configuration['settings'], $configuration['label'], $configuration['view_mode'], + $configuration['third_party_settings'], $container->get('current_user'), $container->get('entity.manager')->getStorage('comment'), $container->get('entity.manager')->getViewBuilder('comment') @@ -96,6 +97,8 @@ public static function create(ContainerInterface $container, array $configuratio * The formatter label display setting. * @param string $view_mode * The view mode. + * @param array $third_party_settings + * Third party settings. * @param \Drupal\Core\Session\AccountInterface $current_user * The current user. * @param \Drupal\comment\CommentStorageInterface $comment_storage @@ -103,8 +106,8 @@ public static function create(ContainerInterface $container, array $configuratio * @param \Drupal\Core\Entity\EntityViewBuilderInterface $comment_view_builder * The comment view builder. */ - public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, AccountInterface $current_user, CommentStorageInterface $comment_storage, EntityViewBuilderInterface $comment_view_builder) { - parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $label, $view_mode); + public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, AccountInterface $current_user, CommentStorageInterface $comment_storage, EntityViewBuilderInterface $comment_view_builder) { + parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $label, $view_mode, $third_party_settings); $this->viewBuilder = $comment_view_builder; $this->storage = $comment_storage; $this->currentUser = $current_user; only in patch2: unchanged: --- a/core/modules/datetime/src/Plugin/Field/FieldFormatter/DateTimeDefaultFormatter.php +++ b/core/modules/datetime/src/Plugin/Field/FieldFormatter/DateTimeDefaultFormatter.php @@ -67,13 +67,15 @@ public static function defaultSettings() { * The formatter label display setting. * @param string $view_mode * The view mode. + * @param array $third_party_settings + * Third party settings. * @param \Drupal\Core\Datetime\Date $date_service * The date service. * @param \Drupal\Core\Entity\EntityStorageInterface $date_storage * The date storage. */ - public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, Date $date_service, EntityStorageInterface $date_storage) { - parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $label, $view_mode); + public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, Date $date_service, EntityStorageInterface $date_storage) { + parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $label, $view_mode, $third_party_settings); $this->dateService = $date_service; $this->dateStorage = $date_storage; @@ -90,6 +92,7 @@ public static function create(ContainerInterface $container, array $configuratio $configuration['settings'], $configuration['label'], $configuration['view_mode'], + $configuration['third_party_settings'], $container->get('date'), $container->get('entity.manager')->getStorage('date_format') ); only in patch2: unchanged: --- a/core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeDefaultWidget.php +++ b/core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeDefaultWidget.php @@ -34,8 +34,8 @@ class DateTimeDefaultWidget extends WidgetBase { /** * {@inheritdoc} */ - public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings) { - parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings); + public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, array $third_party_settings) { + parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $third_party_settings); // @todo Inject this once https://drupal.org/node/2035317 is in. $this->dateStorage = \Drupal::entityManager()->getStorage('date_format'); only in patch2: unchanged: --- a/core/modules/options/src/Plugin/Field/FieldWidget/OptionsWidgetBase.php +++ b/core/modules/options/src/Plugin/Field/FieldWidget/OptionsWidgetBase.php @@ -45,8 +45,8 @@ /** * {@inheritdoc} */ - public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings) { - parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings); + public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, array $third_party_settings) { + parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $third_party_settings); $property_names = $this->fieldDefinition->getPropertyNames(); $this->column = $property_names[0]; }