? 304226_coding_standards_followup.patch
? coding_standards_uc_multi_stock.patch
Index: uc_multi_stock.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/uc_multi_stock/uc_multi_stock.module,v
retrieving revision 1.2
diff -u -p -r1.2 uc_multi_stock.module
--- uc_multi_stock.module	5 Sep 2008 19:48:17 -0000	1.2
+++ uc_multi_stock.module	5 Sep 2008 20:29:32 -0000
@@ -288,22 +288,21 @@ function uc_multi_get_sku($nid, $attribu
  * @return
  *   Array of sub products, empty array if the product has no attrributes
  */
-function uc_multi_get_subproducts($nid){
+function uc_multi_get_subproducts($nid) {
   $out = array();
 
-  if(!empty($nid) and module_exists('uc_attribute')){
-    $sql = 'SELECT 	* FROM 	{uc_product_adjustments} WHERE 	nid = '.$nid;
-	$q = db_query($sql);
-	$i = 0;
-	while($product = db_fetch_array($q)){
-		$out[$i]['attributes'] = unserialize($product['combination']);
-		$out[$i]['model'] = $product['model'];
-		$i++;
-	}
-	return $out;
+  if (!empty($nid) && module_exists('uc_attribute')) {
+    $results = db_query('SELECT * FROM   {uc_product_adjustments} WHERE   nid = %d', $nid);
+    $i = 0;
+    while ($product = db_fetch_array($results)) {
+      $out[$i]['attributes'] = unserialize($product['combination']);
+      $out[$i]['model'] = $product['model'];
+      $i++;
+    }
+    return $out;
   }
   else {
-	return array();
+    return array();
   }
 }