* Unmerged path core/modules/taxonomy/src/Entity/Term.php * Unmerged path core/modules/taxonomy/src/TermViewsData.php diff --git a/core/modules/views/src/EntityViewsData.php b/core/modules/views/src/EntityViewsData.php index 61def5acd4..4459af4ba0 100644 --- a/core/modules/views/src/EntityViewsData.php +++ b/core/modules/views/src/EntityViewsData.php @@ -371,13 +371,10 @@ protected function mapFieldDefinition($table, $field_name, FieldDefinitionInterf // @todo Introduce concept of the "main" column for a field, rather than // assuming the first one is the main column. See also what the // mapSingleFieldViewsData() method does with $first. - $multiple = (count($field_column_mapping) > 1); $first = TRUE; foreach ($field_column_mapping as $field_column_name => $schema_field_name) { - $views_field_name = ($multiple) ? $field_name . '__' . $field_column_name : $field_name; - $table_data[$views_field_name] = $this->mapSingleFieldViewsData($table, $field_name, $field_definition_type, $field_column_name, $field_schema['columns'][$field_column_name]['type'], $first, $field_definition); - - $table_data[$views_field_name]['entity field'] = $field_name; + $table_data[$schema_field_name] = $this->mapSingleFieldViewsData($table, $field_name, $field_definition_type, $field_column_name, $field_schema['columns'][$field_column_name]['type'], $first, $field_definition); + $table_data[$schema_field_name]['entity field'] = $field_name; $first = FALSE; } } diff --git a/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_entity_multivalue_basefield.yml b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_entity_multivalue_basefield.yml index 478071dfa7..d2ecb577bf 100644 --- a/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_entity_multivalue_basefield.yml +++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_entity_multivalue_basefield.yml @@ -30,7 +30,7 @@ display: name: id: name table: entity_test_multivalue_basefield__name - field: name + field: name_value plugin_id: field entity_type: entity_test_multivalue_basefield entity_field: name diff --git a/core/modules/views/tests/src/Unit/EntityViewsDataTest.php b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php index acb84e5f1e..131259e589 100644 --- a/core/modules/views/tests/src/Unit/EntityViewsDataTest.php +++ b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php @@ -527,8 +527,12 @@ public function testBaseTableFields() { $this->assertEquals('users_field_data', $relationship['base']); $this->assertEquals('uid', $relationship['base field']); - $this->assertStringField($data['entity_test__string']['string']); - $this->assertField($data['entity_test__string']['string'], 'string'); + // The string field name should be used as the 'entity field' but the actual + // field should reflect what the column mapping is using for multi-value + // base fields NOT just the field name. The actual column name returned from + // mappings in the test mocks is 'value'. + $this->assertStringField($data['entity_test__string']['value']); + $this->assertField($data['entity_test__string']['value'], 'string'); $this->assertEquals([ 'left_field' => 'id', 'field' => 'entity_id', @@ -682,8 +686,8 @@ public function testDataTableFields() { $this->assertEquals('users_field_data', $relationship['base']); $this->assertEquals('uid', $relationship['base field']); - $this->assertStringField($data['entity_test_mul__string']['string']); - $this->assertField($data['entity_test_mul__string']['string'], 'string'); + $this->assertStringField($data['entity_test_mul__string']['value']); + $this->assertField($data['entity_test_mul__string']['value'], 'string'); $this->assertEquals([ 'left_field' => 'id', 'field' => 'entity_id', @@ -741,7 +745,7 @@ public function testRevisionTableFields() { ['description', ['value' => 'description__value', 'format' => 'description__format']], ['homepage', ['value' => 'homepage']], ['user_id', ['target_id' => 'user_id']], - ['revision_id', ['value' => 'id']], + ['revision_id', ['value' => 'revision_id']], ['string', ['value' => 'value']], ]); $table_mapping->expects($this->any()) @@ -867,8 +871,8 @@ public function testRevisionTableFields() { $this->assertEquals('users_field_data', $relationship['base']); $this->assertEquals('uid', $relationship['base field']); - $this->assertStringField($data['entity_test_mulrev__string']['string']); - $this->assertField($data['entity_test_mulrev__string']['string'], 'string'); + $this->assertStringField($data['entity_test_mulrev__string']['value']); + $this->assertField($data['entity_test_mulrev__string']['value'], 'string'); $this->assertEquals([ 'left_field' => 'id', 'field' => 'entity_id', @@ -879,8 +883,8 @@ public function testRevisionTableFields() { ]], ], $data['entity_test_mulrev__string']['table']['join']['entity_test_mulrev_property_data']); - $this->assertStringField($data['entity_test_mulrev_revision__string']['string']); - $this->assertField($data['entity_test_mulrev_revision__string']['string'], 'string'); + $this->assertStringField($data['entity_test_mulrev_revision__string']['value']); + $this->assertField($data['entity_test_mulrev_revision__string']['value'], 'string'); $this->assertEquals([ 'left_field' => 'revision_id', 'field' => 'entity_id',