diff --git a/core/lib/Drupal/Core/Field/FieldConfigStorageBase.php b/core/lib/Drupal/Core/Field/FieldConfigStorageBase.php index 04739b1..67652e5 100644 --- a/core/lib/Drupal/Core/Field/FieldConfigStorageBase.php +++ b/core/lib/Drupal/Core/Field/FieldConfigStorageBase.php @@ -9,7 +9,6 @@ use Drupal\Core\Config\Entity\ConfigEntityStorage; use Drupal\Core\Entity\EntityInterface; -use Drupal\field\Entity\FieldStorageConfig; /** * Base storage class for field config entities. diff --git a/core/modules/entity_reference/entity_reference.module b/core/modules/entity_reference/entity_reference.module index 526c60c..b4c95c2 100644 --- a/core/modules/entity_reference/entity_reference.module +++ b/core/modules/entity_reference/entity_reference.module @@ -84,19 +84,10 @@ function entity_reference_field_storage_config_update(FieldStorageConfigInterfac return; } - if (empty($field_storage->bundles)) { - // Field storage has no fields. - return; - } - - $field_name = $field_storage->getName(); - - foreach ($field_storage->bundles() as $entity_type => $bundles) { - foreach ($bundles as $bundle) { - $field = FieldConfig::loadByName($entity_type, $bundle, $field_name); - $field->settings['handler_settings'] = array(); - $field->save(); - } + foreach ($field_storage->getBundles() as $bundle) { + $field = FieldConfig::loadByName($field_storage->getTargetEntityTypeId(), $bundle, $field_storage->getName()); + $field->settings['handler_settings'] = array(); + $field->save(); } } diff --git a/core/modules/migrate_drupal/src/Tests/d6/MigrateFieldInstanceTest.php b/core/modules/migrate_drupal/src/Tests/d6/MigrateFieldInstanceTest.php index 05cc467..daac5b2 100644 --- a/core/modules/migrate_drupal/src/Tests/d6/MigrateFieldInstanceTest.php +++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateFieldInstanceTest.php @@ -135,11 +135,14 @@ public function testFieldInstanceSettings() { 'display_default' => FALSE, 'uri_scheme' => 'public', 'handler' => 'default', + 'handler_settings' => array(), 'target_bundle' => NULL, ); + $field_settings = $field->getSettings(); + ksort($expected); + ksort($field_settings); // This is the only way to compare arrays. - $this->assertFalse(array_diff_assoc($field->getSettings(), $expected)); - $this->assertFalse(array_diff_assoc($expected, $field->getSettings())); + $this->assertIdentical($expected, $field_settings); // Test a link field. $field = FieldConfig::load('node.story.field_test_link');