diff --git a/core/includes/common.inc b/core/includes/common.inc index 12ccffd..dccf647 100644 --- a/core/includes/common.inc +++ b/core/includes/common.inc @@ -3428,6 +3428,13 @@ function drupal_pre_render_link($element) { $element['#options']['attributes'] += $element['#attributes']; } + // Merge the provided attributes on top of the default attributes + // provided by the element definition. + if (isset($element['#default_attributes'])) { + $element['#options'] += array('attributes' => array()); + $element['#options']['attributes'] = NestedArray::mergeDeep($element['#default_attributes'], $element['#options']['attributes']); + } + // This #pre_render callback can be invoked from inside or outside of a Form // API context, and depending on that, a HTML ID may be already set in // different locations. #options should have precedence over Form API's #id. diff --git a/core/includes/theme.inc b/core/includes/theme.inc index 726503e..bf05c7e 100644 --- a/core/includes/theme.inc +++ b/core/includes/theme.inc @@ -1899,18 +1899,6 @@ function template_preprocess_feed_icon(&$variables) { } /** - * Returns HTML for a "more" link, like those used in blocks. - * - * @param $variables - * An associative array containing: - * - url: The URL of the main page. - * - title: A descriptive verb for the link, like 'Read more'. - */ -function theme_more_link($variables) { - return ''; -} - -/** * Returns HTML for an indentation div; used for drag and drop tables. * * @param $variables @@ -2638,9 +2626,6 @@ function drupal_common_theme() { 'variables' => array('url' => NULL, 'title' => NULL), 'template' => 'feed-icon', ), - 'more_link' => array( - 'variables' => array('url' => NULL, 'title' => NULL) - ), 'progress_bar' => array( 'variables' => array('label' => NULL, 'percent' => NULL, 'message' => NULL), 'template' => 'progress-bar', diff --git a/core/modules/aggregator/lib/Drupal/aggregator/Plugin/Block/AggregatorFeedBlock.php b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/Block/AggregatorFeedBlock.php index 341e92d..0cddb59 100644 --- a/core/modules/aggregator/lib/Drupal/aggregator/Plugin/Block/AggregatorFeedBlock.php +++ b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/Block/AggregatorFeedBlock.php @@ -135,9 +135,9 @@ public function build() { if ($feed = $this->storageController->load($this->configuration['feed'])) { $result = $this->connection->queryRange("SELECT * FROM {aggregator_item} WHERE fid = :fid ORDER BY timestamp DESC, iid DESC", 0, $this->configuration['block_count'], array(':fid' => $feed->id())); $more_link = array( - '#theme' => 'more_link', - '#url' => 'aggregator/sources/' . $feed->id(), - '#title' => t("View this feed's recent news."), + '#type' => 'more_link', + '#href' => 'aggregator/sources/' . $feed->id(), + '#attributes' => array('title' => t("View this feed's recent news.")), ); $read_more = drupal_render($more_link); $items = array(); diff --git a/core/modules/forum/forum.module b/core/modules/forum/forum.module index 95ebe76..299cef7 100644 --- a/core/modules/forum/forum.module +++ b/core/modules/forum/forum.module @@ -564,7 +564,11 @@ function forum_block_view_pre_render($elements) { $result = $elements['#query']->execute(); if ($node_title_list = node_title_list($result)) { $elements['forum_list'] = $node_title_list; - $elements['forum_more'] = array('#theme' => 'more_link', '#url' => 'forum', '#title' => t('Read the latest forum topics.')); + $elements['forum_more'] = array( + '#type' => 'more_link', + '#href' => 'forum', + '#attributes' => array('title' => t('Read the latest forum topics.')), + ); } return $elements; } diff --git a/core/modules/node/node.module b/core/modules/node/node.module index 1702ee9..19b3922 100644 --- a/core/modules/node/node.module +++ b/core/modules/node/node.module @@ -1184,9 +1184,9 @@ function theme_node_recent_block($variables) { $output = drupal_render($table); if (user_access('access content overview')) { $more_link = array( - '#theme' => 'more_link', - '#url' => 'admin/content', - '#title' => t('Show more content'), + '#type' => 'more_link', + '#href' => 'admin/content', + '#attributes' => array('title' => t('Show more content')), ); $output .= drupal_render($more_link); } diff --git a/core/modules/system/css/system.theme.css b/core/modules/system/css/system.theme.css index 6b34538..0b33d7f 100644 --- a/core/modules/system/css/system.theme.css +++ b/core/modules/system/css/system.theme.css @@ -119,7 +119,7 @@ abbr.form-required, abbr.tabledrag-changed, abbr.ajax-changed { } /** - * Markup generated by theme_more_link(). + * Markup generated by #type 'link'. */ .more-link { text-align: right; /* LTR */ diff --git a/core/modules/system/lib/Drupal/system/Tests/Common/RenderElementTypesTest.php b/core/modules/system/lib/Drupal/system/Tests/Common/RenderElementTypesTest.php index 9ba4bf4..d6bfa7d 100644 --- a/core/modules/system/lib/Drupal/system/Tests/Common/RenderElementTypesTest.php +++ b/core/modules/system/lib/Drupal/system/Tests/Common/RenderElementTypesTest.php @@ -113,4 +113,35 @@ function testHtmlTag() { $this->assertElements($elements); } + /** + * Tests system #type 'more_link'. + */ + function testMoreLink() { + $elements = array( + // Test more_link anchor tag generation without class attributes to test default. + array( + 'name' => "#type 'more_link' anchor tag generation without extra classes", + 'value' => array( + '#type' => 'more_link', + '#href' => 'admin/content', + ), + 'expected' => 'More', + ), + // Test more_link anchor tag generation without class attributes to test additional classes. + array( + 'name' => "#type 'more_link' anchor tag generation with extra classes", + 'value' => array( + '#type' => 'more_link', + '#href' => 'admin/content', + '#attributes' => array( + 'name' => 'description', + 'class' => array('drupal', 'test'), + ), + ), + 'expected' => 'More', + ), + ); + $this->assertElements($elements); + } + } diff --git a/core/modules/system/system.module b/core/modules/system/system.module index ee3466d..e1aaca7 100644 --- a/core/modules/system/system.module +++ b/core/modules/system/system.module @@ -536,6 +536,11 @@ function system_element_info() { $types['link'] = array( '#pre_render' => array('drupal_pre_render_link'), ); + // A "more" link, like those used in blocks. + $types['more_link'] = $types['link'] + array( + '#title' => t('More'), + '#default_attributes' => array('class' => array('more-link')), + ); $types['fieldset'] = array( '#value' => NULL, '#process' => array('form_process_group', 'ajax_process_form'), diff --git a/core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/EventSubscriber/ThemeTestSubscriber.php b/core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/EventSubscriber/ThemeTestSubscriber.php index 2e5417d..e2bddaa 100644 --- a/core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/EventSubscriber/ThemeTestSubscriber.php +++ b/core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/EventSubscriber/ThemeTestSubscriber.php @@ -42,7 +42,7 @@ public function onRequest(GetResponseEvent $event) { // theme_test_request_listener_page_callback() to test that even when the // theme system is initialized this early, it is still capable of // returning output and theming the page as a whole. - $GLOBALS['theme_test_output'] = theme('more_link', array('url' => 'user', 'title' => 'Themed output generated in a KernelEvents::REQUEST listener')); + $GLOBALS['theme_test_output'] = theme('theme_test_foo', array('foo' => 'Themed output generated in a KernelEvents::REQUEST listener')); } }