diff --git a/core/modules/aggregator/tests/src/Functional/AggregatorTestBase.php b/core/modules/aggregator/tests/src/Functional/AggregatorTestBase.php index 3e5ce25032..31ccc25bba 100644 --- a/core/modules/aggregator/tests/src/Functional/AggregatorTestBase.php +++ b/core/modules/aggregator/tests/src/Functional/AggregatorTestBase.php @@ -38,7 +38,7 @@ abstract class AggregatorTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create an Article node type. diff --git a/core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php b/core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php index 0477889dec..0cfeb11875 100644 --- a/core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php +++ b/core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php @@ -30,7 +30,7 @@ class BigPipeRegressionTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Use the big_pipe_test_theme theme. diff --git a/core/modules/block/tests/src/Functional/BlockTestBase.php b/core/modules/block/tests/src/Functional/BlockTestBase.php index 83b7de0060..04b7c91e2a 100644 --- a/core/modules/block/tests/src/Functional/BlockTestBase.php +++ b/core/modules/block/tests/src/Functional/BlockTestBase.php @@ -40,7 +40,7 @@ abstract class BlockTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Use the test page as the front page. diff --git a/core/modules/block_content/tests/src/Functional/BlockContentTestBase.php b/core/modules/block_content/tests/src/Functional/BlockContentTestBase.php index 43220d1e73..baf521f862 100644 --- a/core/modules/block_content/tests/src/Functional/BlockContentTestBase.php +++ b/core/modules/block_content/tests/src/Functional/BlockContentTestBase.php @@ -51,7 +51,7 @@ abstract class BlockContentTestBase extends BrowserTestBase { /** * Sets the test up. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); if ($this->autoCreateBasicBlockType) { $this->createBlockContentType('basic', TRUE); diff --git a/core/modules/block_content/tests/src/Functional/Views/BlockContentFieldFilterTest.php b/core/modules/block_content/tests/src/Functional/Views/BlockContentFieldFilterTest.php index 5ad36523be..9cc7c988b7 100644 --- a/core/modules/block_content/tests/src/Functional/Views/BlockContentFieldFilterTest.php +++ b/core/modules/block_content/tests/src/Functional/Views/BlockContentFieldFilterTest.php @@ -39,7 +39,7 @@ class BlockContentFieldFilterTest extends BlockContentTestBase { /** * {@inheritdoc} */ - public function setUp($import_test_views = TRUE, $modules = ['block_content_test_views']): void { + protected function setUp($import_test_views = TRUE, $modules = ['block_content_test_views']): void { parent::setUp($import_test_views, $modules); // Add two new languages. diff --git a/core/modules/block_content/tests/src/Functional/Views/BlockContentTestBase.php b/core/modules/block_content/tests/src/Functional/Views/BlockContentTestBase.php index 9114856068..ace5f83221 100644 --- a/core/modules/block_content/tests/src/Functional/Views/BlockContentTestBase.php +++ b/core/modules/block_content/tests/src/Functional/Views/BlockContentTestBase.php @@ -42,7 +42,7 @@ abstract class BlockContentTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = ['block_content_test_views']) { + protected function setUp($import_test_views = TRUE, $modules = ['block_content_test_views']): void { parent::setUp($import_test_views, $modules); // Ensure the basic bundle exists. This is provided by the standard profile. $this->createBlockContentType(['id' => 'basic']); diff --git a/core/modules/block_content/tests/src/Kernel/BlockContentDeletionTest.php b/core/modules/block_content/tests/src/Kernel/BlockContentDeletionTest.php index 7276eae053..fe41695044 100644 --- a/core/modules/block_content/tests/src/Kernel/BlockContentDeletionTest.php +++ b/core/modules/block_content/tests/src/Kernel/BlockContentDeletionTest.php @@ -25,7 +25,7 @@ class BlockContentDeletionTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); $this->installEntitySchema('block_content'); diff --git a/core/modules/block_content/tests/src/Kernel/BlockContentDeriverTest.php b/core/modules/block_content/tests/src/Kernel/BlockContentDeriverTest.php index 640bbb1eda..3695c591b6 100644 --- a/core/modules/block_content/tests/src/Kernel/BlockContentDeriverTest.php +++ b/core/modules/block_content/tests/src/Kernel/BlockContentDeriverTest.php @@ -22,7 +22,7 @@ class BlockContentDeriverTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); $this->installEntitySchema('block_content'); diff --git a/core/modules/block_content/tests/src/Kernel/BlockContentEntityReferenceSelectionTest.php b/core/modules/block_content/tests/src/Kernel/BlockContentEntityReferenceSelectionTest.php index 738a809355..53d9562cec 100644 --- a/core/modules/block_content/tests/src/Kernel/BlockContentEntityReferenceSelectionTest.php +++ b/core/modules/block_content/tests/src/Kernel/BlockContentEntityReferenceSelectionTest.php @@ -65,7 +65,7 @@ class BlockContentEntityReferenceSelectionTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installSchema('system', ['sequences']); $this->installEntitySchema('user'); diff --git a/core/modules/ckeditor/tests/src/Unit/Plugin/CKEditorPlugin/LanguageTest.php b/core/modules/ckeditor/tests/src/Unit/Plugin/CKEditorPlugin/LanguageTest.php index 5b8bc6948f..ef59c63356 100644 --- a/core/modules/ckeditor/tests/src/Unit/Plugin/CKEditorPlugin/LanguageTest.php +++ b/core/modules/ckeditor/tests/src/Unit/Plugin/CKEditorPlugin/LanguageTest.php @@ -24,7 +24,7 @@ class LanguageTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { $this->plugin = new Language([], $this->randomMachineName(), []); } diff --git a/core/modules/comment/tests/src/Functional/CommentTestBase.php b/core/modules/comment/tests/src/Functional/CommentTestBase.php index bfefc61693..b98cdc1363 100644 --- a/core/modules/comment/tests/src/Functional/CommentTestBase.php +++ b/core/modules/comment/tests/src/Functional/CommentTestBase.php @@ -57,7 +57,7 @@ abstract class CommentTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create an article content type only if it does not yet exist, so that diff --git a/core/modules/comment/tests/src/Functional/Views/CommentTestBase.php b/core/modules/comment/tests/src/Functional/Views/CommentTestBase.php index 44a67eaacc..0a7ab1dfb6 100644 --- a/core/modules/comment/tests/src/Functional/Views/CommentTestBase.php +++ b/core/modules/comment/tests/src/Functional/Views/CommentTestBase.php @@ -58,7 +58,7 @@ abstract class CommentTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = ['comment_test_views']) { + protected function setUp($import_test_views = TRUE, $modules = ['comment_test_views']): void { parent::setUp($import_test_views, $modules); // Add two users, create a node with the user1 as author and another node diff --git a/core/modules/comment/tests/src/Kernel/Views/CommentViewsKernelTestBase.php b/core/modules/comment/tests/src/Kernel/Views/CommentViewsKernelTestBase.php index 38101770a8..37987d9d7b 100644 --- a/core/modules/comment/tests/src/Kernel/Views/CommentViewsKernelTestBase.php +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsKernelTestBase.php @@ -42,7 +42,7 @@ abstract class CommentViewsKernelTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp($import_test_views); ViewTestData::createTestViews(static::class, ['comment_test_views']); diff --git a/core/modules/content_moderation/tests/src/Functional/ModeratedContentLocalTaskTest.php b/core/modules/content_moderation/tests/src/Functional/ModeratedContentLocalTaskTest.php index 6797bca5f0..64cc55f1b0 100644 --- a/core/modules/content_moderation/tests/src/Functional/ModeratedContentLocalTaskTest.php +++ b/core/modules/content_moderation/tests/src/Functional/ModeratedContentLocalTaskTest.php @@ -35,7 +35,7 @@ class ModeratedContentLocalTaskTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->drupalPlaceBlock('local_tasks_block'); diff --git a/core/modules/content_moderation/tests/src/Functional/ModeratedContentViewTest.php b/core/modules/content_moderation/tests/src/Functional/ModeratedContentViewTest.php index 218e1c3c01..cf01a082a0 100644 --- a/core/modules/content_moderation/tests/src/Functional/ModeratedContentViewTest.php +++ b/core/modules/content_moderation/tests/src/Functional/ModeratedContentViewTest.php @@ -42,7 +42,7 @@ class ModeratedContentViewTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->drupalCreateContentType(['type' => 'page', 'name' => 'Basic page'])->save(); diff --git a/core/modules/content_moderation/tests/src/Functional/ModerationActionsTest.php b/core/modules/content_moderation/tests/src/Functional/ModerationActionsTest.php index 9632540f98..c678595ab6 100644 --- a/core/modules/content_moderation/tests/src/Functional/ModerationActionsTest.php +++ b/core/modules/content_moderation/tests/src/Functional/ModerationActionsTest.php @@ -36,7 +36,7 @@ class ModerationActionsTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $moderated_bundle = $this->createContentType(['type' => 'moderated_bundle']); diff --git a/core/modules/content_moderation/tests/src/Functional/ModerationRevisionRevertTest.php b/core/modules/content_moderation/tests/src/Functional/ModerationRevisionRevertTest.php index 069fe78915..71a6925a43 100644 --- a/core/modules/content_moderation/tests/src/Functional/ModerationRevisionRevertTest.php +++ b/core/modules/content_moderation/tests/src/Functional/ModerationRevisionRevertTest.php @@ -34,7 +34,7 @@ class ModerationRevisionRevertTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $moderated_bundle = $this->createContentType(['type' => 'moderated_bundle']); diff --git a/core/modules/content_moderation/tests/src/Functional/ModerationStateTestBase.php b/core/modules/content_moderation/tests/src/Functional/ModerationStateTestBase.php index 7e254eadfa..350c8d0d87 100644 --- a/core/modules/content_moderation/tests/src/Functional/ModerationStateTestBase.php +++ b/core/modules/content_moderation/tests/src/Functional/ModerationStateTestBase.php @@ -72,7 +72,7 @@ abstract class ModerationStateTestBase extends BrowserTestBase { /** * Sets the test up. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->workflow = $this->createEditorialWorkflow(); $this->adminUser = $this->drupalCreateUser($this->permissions); diff --git a/core/modules/content_translation/tests/src/Functional/ContentTranslationPendingRevisionTestBase.php b/core/modules/content_translation/tests/src/Functional/ContentTranslationPendingRevisionTestBase.php index dbf00f2c34..947e4ed6dc 100644 --- a/core/modules/content_translation/tests/src/Functional/ContentTranslationPendingRevisionTestBase.php +++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationPendingRevisionTestBase.php @@ -48,7 +48,7 @@ abstract class ContentTranslationPendingRevisionTestBase extends ContentTranslat /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { $this->entityTypeId = 'node'; $this->bundle = 'article'; diff --git a/core/modules/content_translation/tests/src/Functional/ContentTranslationTestBase.php b/core/modules/content_translation/tests/src/Functional/ContentTranslationTestBase.php index c3a4c53d01..405fa2beea 100644 --- a/core/modules/content_translation/tests/src/Functional/ContentTranslationTestBase.php +++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationTestBase.php @@ -85,7 +85,7 @@ abstract class ContentTranslationTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->setupLanguages(); diff --git a/core/modules/datetime/tests/src/Functional/DateTestBase.php b/core/modules/datetime/tests/src/Functional/DateTestBase.php index 9ecb8fe34f..57cc4cb641 100644 --- a/core/modules/datetime/tests/src/Functional/DateTestBase.php +++ b/core/modules/datetime/tests/src/Functional/DateTestBase.php @@ -88,7 +88,7 @@ abstract class DateTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $web_user = $this->drupalCreateUser([ diff --git a/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateonlyTest.php b/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateonlyTest.php index 04e38fd016..cf1c247f39 100644 --- a/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateonlyTest.php +++ b/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateonlyTest.php @@ -47,7 +47,7 @@ class EntityTestDateonlyTest extends EntityTestResourceTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Add datetime field. diff --git a/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDatetimeTest.php b/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDatetimeTest.php index 2030900cf4..34474958af 100644 --- a/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDatetimeTest.php +++ b/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDatetimeTest.php @@ -47,7 +47,7 @@ class EntityTestDatetimeTest extends EntityTestResourceTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Add datetime field. diff --git a/core/modules/datetime/tests/src/Kernel/Views/DateTimeHandlerTestBase.php b/core/modules/datetime/tests/src/Kernel/Views/DateTimeHandlerTestBase.php index edf886c70a..5f12e524ec 100644 --- a/core/modules/datetime/tests/src/Kernel/Views/DateTimeHandlerTestBase.php +++ b/core/modules/datetime/tests/src/Kernel/Views/DateTimeHandlerTestBase.php @@ -54,7 +54,7 @@ abstract class DateTimeHandlerTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp($import_test_views); $this->installSchema('node', 'node_access'); diff --git a/core/modules/datetime_range/tests/src/Functional/EntityResource/EntityTest/EntityTestDateRangeTest.php b/core/modules/datetime_range/tests/src/Functional/EntityResource/EntityTest/EntityTestDateRangeTest.php index 636221f951..9e5ee8264c 100644 --- a/core/modules/datetime_range/tests/src/Functional/EntityResource/EntityTest/EntityTestDateRangeTest.php +++ b/core/modules/datetime_range/tests/src/Functional/EntityResource/EntityTest/EntityTestDateRangeTest.php @@ -47,7 +47,7 @@ class EntityTestDateRangeTest extends EntityTestResourceTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Add datetime_range field. diff --git a/core/modules/dblog/tests/src/Kernel/DbLogControllerTest.php b/core/modules/dblog/tests/src/Kernel/DbLogControllerTest.php index d5585bc95f..8c74084544 100644 --- a/core/modules/dblog/tests/src/Kernel/DbLogControllerTest.php +++ b/core/modules/dblog/tests/src/Kernel/DbLogControllerTest.php @@ -20,7 +20,7 @@ class DbLogControllerTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); $this->installSchema('dblog', ['watchdog']); diff --git a/core/modules/field/tests/src/Functional/Views/FieldTestBase.php b/core/modules/field/tests/src/Functional/Views/FieldTestBase.php index 639f683883..feac7d8e05 100644 --- a/core/modules/field/tests/src/Functional/Views/FieldTestBase.php +++ b/core/modules/field/tests/src/Functional/Views/FieldTestBase.php @@ -43,7 +43,7 @@ abstract class FieldTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = ['field_test_views']) { + protected function setUp($import_test_views = TRUE, $modules = ['field_test_views']): void { parent::setUp($import_test_views, $modules); // Ensure the page node type exists. diff --git a/core/modules/field/tests/src/Kernel/FieldCrudTest.php b/core/modules/field/tests/src/Kernel/FieldCrudTest.php index ddc71895aa..8db9cafae5 100644 --- a/core/modules/field/tests/src/Kernel/FieldCrudTest.php +++ b/core/modules/field/tests/src/Kernel/FieldCrudTest.php @@ -41,7 +41,7 @@ class FieldCrudTest extends FieldKernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->fieldStorageDefinition = [ diff --git a/core/modules/field/tests/src/Kernel/FieldKernelTestBase.php b/core/modules/field/tests/src/Kernel/FieldKernelTestBase.php index abb7050afe..9cdc2994a7 100644 --- a/core/modules/field/tests/src/Kernel/FieldKernelTestBase.php +++ b/core/modules/field/tests/src/Kernel/FieldKernelTestBase.php @@ -52,7 +52,7 @@ abstract class FieldKernelTestBase extends KernelTestBase { /** * Set the default field storage backend for fields created during tests. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->fieldTestData = new \ArrayObject([], \ArrayObject::ARRAY_AS_PROPS); diff --git a/core/modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldInstanceLabelDescriptionTest.php b/core/modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldInstanceLabelDescriptionTest.php index 940f91d72d..95ff3db1ed 100644 --- a/core/modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldInstanceLabelDescriptionTest.php +++ b/core/modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldInstanceLabelDescriptionTest.php @@ -29,7 +29,7 @@ class MigrateFieldInstanceLabelDescriptionTest extends MigrateDrupal6TestBase im /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->migrateFields(); diff --git a/core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceLabelDescriptionTest.php b/core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceLabelDescriptionTest.php index 161f6cd946..a777d25b3c 100644 --- a/core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceLabelDescriptionTest.php +++ b/core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceLabelDescriptionTest.php @@ -39,7 +39,7 @@ class MigrateFieldInstanceLabelDescriptionTest extends MigrateDrupal7TestBase im /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('node'); diff --git a/core/modules/file/tests/src/Functional/FileFieldTestBase.php b/core/modules/file/tests/src/Functional/FileFieldTestBase.php index cbfe67fa3c..2fa0f534a4 100644 --- a/core/modules/file/tests/src/Functional/FileFieldTestBase.php +++ b/core/modules/file/tests/src/Functional/FileFieldTestBase.php @@ -35,7 +35,7 @@ abstract class FileFieldTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->adminUser = $this->drupalCreateUser([ 'access content', diff --git a/core/modules/file/tests/src/Functional/FileManagedTestBase.php b/core/modules/file/tests/src/Functional/FileManagedTestBase.php index 2507c947c1..689dd3b7b1 100644 --- a/core/modules/file/tests/src/Functional/FileManagedTestBase.php +++ b/core/modules/file/tests/src/Functional/FileManagedTestBase.php @@ -23,7 +23,7 @@ abstract class FileManagedTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Clear out any hook calls. file_test_reset(); diff --git a/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php b/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php index aca03382da..df630fad2a 100644 --- a/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php +++ b/core/modules/file/tests/src/Functional/Formatter/FileMediaFormatterTestBase.php @@ -26,7 +26,7 @@ abstract class FileMediaFormatterTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->drupalLogin($this->drupalCreateUser(['view test entity'])); } diff --git a/core/modules/file/tests/src/Kernel/FileManagedUnitTestBase.php b/core/modules/file/tests/src/Kernel/FileManagedUnitTestBase.php index 5d14ef9b0c..4441fd333f 100644 --- a/core/modules/file/tests/src/Kernel/FileManagedUnitTestBase.php +++ b/core/modules/file/tests/src/Kernel/FileManagedUnitTestBase.php @@ -24,7 +24,7 @@ abstract class FileManagedUnitTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Clear out any hook calls. file_test_reset(); diff --git a/core/modules/hal/tests/src/Functional/dblog/DbLogResourceTest.php b/core/modules/hal/tests/src/Functional/dblog/DbLogResourceTest.php index b0768ae739..6d65e12db0 100644 --- a/core/modules/hal/tests/src/Functional/dblog/DbLogResourceTest.php +++ b/core/modules/hal/tests/src/Functional/dblog/DbLogResourceTest.php @@ -51,7 +51,7 @@ class DbLogResourceTest extends ResourceTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $auth = isset(static::$auth) ? [static::$auth] : []; diff --git a/core/modules/hal/tests/src/Functional/user/RestRegisterUserTest.php b/core/modules/hal/tests/src/Functional/user/RestRegisterUserTest.php index a4500cb8ec..3785d7565b 100644 --- a/core/modules/hal/tests/src/Functional/user/RestRegisterUserTest.php +++ b/core/modules/hal/tests/src/Functional/user/RestRegisterUserTest.php @@ -60,7 +60,7 @@ class RestRegisterUserTest extends ResourceTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $auth = isset(static::$auth) ? [static::$auth] : []; diff --git a/core/modules/hal/tests/src/Kernel/NormalizerTestBase.php b/core/modules/hal/tests/src/Kernel/NormalizerTestBase.php index f61890e6de..9f2e4fb841 100644 --- a/core/modules/hal/tests/src/Kernel/NormalizerTestBase.php +++ b/core/modules/hal/tests/src/Kernel/NormalizerTestBase.php @@ -53,7 +53,7 @@ abstract class NormalizerTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); $this->installEntitySchema('entity_test'); diff --git a/core/modules/help_topics/tests/src/Functional/HelpTopicTranslatedTestBase.php b/core/modules/help_topics/tests/src/Functional/HelpTopicTranslatedTestBase.php index 05c391db56..78ca97f5dd 100644 --- a/core/modules/help_topics/tests/src/Functional/HelpTopicTranslatedTestBase.php +++ b/core/modules/help_topics/tests/src/Functional/HelpTopicTranslatedTestBase.php @@ -27,7 +27,7 @@ abstract class HelpTopicTranslatedTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // These tests rely on some markup from the 'Claro' theme, as well as an diff --git a/core/modules/image/tests/src/Functional/ImageFieldTestBase.php b/core/modules/image/tests/src/Functional/ImageFieldTestBase.php index 05c47ddce7..01ea732280 100644 --- a/core/modules/image/tests/src/Functional/ImageFieldTestBase.php +++ b/core/modules/image/tests/src/Functional/ImageFieldTestBase.php @@ -48,7 +48,7 @@ abstract class ImageFieldTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create Basic page and Article node types. diff --git a/core/modules/image/tests/src/FunctionalJavascript/ImageFieldTestBase.php b/core/modules/image/tests/src/FunctionalJavascript/ImageFieldTestBase.php index faf352ed16..3e8bf24501 100644 --- a/core/modules/image/tests/src/FunctionalJavascript/ImageFieldTestBase.php +++ b/core/modules/image/tests/src/FunctionalJavascript/ImageFieldTestBase.php @@ -38,7 +38,7 @@ abstract class ImageFieldTestBase extends WebDriverTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create Basic page and Article node types. diff --git a/core/modules/jsonapi/tests/src/Functional/ExternalNormalizersTest.php b/core/modules/jsonapi/tests/src/Functional/ExternalNormalizersTest.php index 3214ca4301..1963cb02b9 100644 --- a/core/modules/jsonapi/tests/src/Functional/ExternalNormalizersTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ExternalNormalizersTest.php @@ -59,7 +59,7 @@ class ExternalNormalizersTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // This test is not about access control at all, so allow anonymous users to diff --git a/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php b/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php index 0dcfb3e68d..b054b694b2 100644 --- a/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php +++ b/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php @@ -106,7 +106,7 @@ class FileUploadTest extends ResourceTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->fileStorage = $this->container->get('entity_type.manager') diff --git a/core/modules/jsonapi/tests/src/Functional/InternalEntitiesTest.php b/core/modules/jsonapi/tests/src/Functional/InternalEntitiesTest.php index 032c49698e..5d87369544 100644 --- a/core/modules/jsonapi/tests/src/Functional/InternalEntitiesTest.php +++ b/core/modules/jsonapi/tests/src/Functional/InternalEntitiesTest.php @@ -59,7 +59,7 @@ class InternalEntitiesTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->testUser = $this->drupalCreateUser([ 'view test entity', diff --git a/core/modules/jsonapi/tests/src/Functional/JsonApiFunctionalTestBase.php b/core/modules/jsonapi/tests/src/Functional/JsonApiFunctionalTestBase.php index 832278be1b..e6f4713a65 100644 --- a/core/modules/jsonapi/tests/src/Functional/JsonApiFunctionalTestBase.php +++ b/core/modules/jsonapi/tests/src/Functional/JsonApiFunctionalTestBase.php @@ -92,7 +92,7 @@ abstract class JsonApiFunctionalTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Set up a HTTP client that accepts relative URLs. diff --git a/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php b/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php index 2f358158f5..0092a95e97 100644 --- a/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php +++ b/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php @@ -216,7 +216,7 @@ abstract class ResourceTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp() { + protected function setUp(): void { parent::setUp(); $this->serializer = $this->container->get('jsonapi.serializer'); diff --git a/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php b/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php index 6ab42019e6..ec379ab881 100644 --- a/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php +++ b/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php @@ -62,7 +62,7 @@ protected function setUpAuthorization($method) { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Create a "Camelids" node type. diff --git a/core/modules/jsonapi/tests/src/Kernel/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php b/core/modules/jsonapi/tests/src/Kernel/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php index 778826dd03..725bcf6c3e 100644 --- a/core/modules/jsonapi/tests/src/Kernel/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php +++ b/core/modules/jsonapi/tests/src/Kernel/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php @@ -232,7 +232,7 @@ protected function setUp(): void { /** * {@inheritdoc} */ - public function tearDown(): void { + protected function tearDown(): void { if ($this->node) { $this->node->delete(); } diff --git a/core/modules/jsonapi/tests/src/Kernel/Query/FilterTest.php b/core/modules/jsonapi/tests/src/Kernel/Query/FilterTest.php index dec00bffb2..a92359da03 100644 --- a/core/modules/jsonapi/tests/src/Kernel/Query/FilterTest.php +++ b/core/modules/jsonapi/tests/src/Kernel/Query/FilterTest.php @@ -61,7 +61,7 @@ class FilterTest extends JsonapiKernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->setUpSchemas(); diff --git a/core/modules/jsonapi/tests/src/Unit/EventSubscriber/ResourceResponseValidatorTest.php b/core/modules/jsonapi/tests/src/Unit/EventSubscriber/ResourceResponseValidatorTest.php index e6c1c566cf..15c522abd1 100644 --- a/core/modules/jsonapi/tests/src/Unit/EventSubscriber/ResourceResponseValidatorTest.php +++ b/core/modules/jsonapi/tests/src/Unit/EventSubscriber/ResourceResponseValidatorTest.php @@ -33,7 +33,7 @@ class ResourceResponseValidatorTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Check that the validation class is available. if (!class_exists("\\JsonSchema\\Validator")) { diff --git a/core/modules/jsonapi/tests/src/Unit/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php b/core/modules/jsonapi/tests/src/Unit/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php index 337d72675f..589a0d4891 100644 --- a/core/modules/jsonapi/tests/src/Unit/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php +++ b/core/modules/jsonapi/tests/src/Unit/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php @@ -35,7 +35,7 @@ class JsonApiDocumentTopLevelNormalizerTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { $resource_type_repository = $this->prophesize(ResourceTypeRepository::class); $field_resolver = $this->prophesize(FieldResolver::class); diff --git a/core/modules/jsonapi/tests/src/Unit/Normalizer/ResourceIdentifierNormalizerTest.php b/core/modules/jsonapi/tests/src/Unit/Normalizer/ResourceIdentifierNormalizerTest.php index 70adf33c5c..c546f6f185 100644 --- a/core/modules/jsonapi/tests/src/Unit/Normalizer/ResourceIdentifierNormalizerTest.php +++ b/core/modules/jsonapi/tests/src/Unit/Normalizer/ResourceIdentifierNormalizerTest.php @@ -44,7 +44,7 @@ class ResourceIdentifierNormalizerTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { $target_resource_type = new ResourceType('lorem', 'dummy_bundle', NULL); $relationship_fields = [ 'field_dummy' => new ResourceTypeRelationship('field_dummy'), diff --git a/core/modules/language/tests/src/Kernel/LanguageTestBase.php b/core/modules/language/tests/src/Kernel/LanguageTestBase.php index 458eeaec53..26077dfb01 100644 --- a/core/modules/language/tests/src/Kernel/LanguageTestBase.php +++ b/core/modules/language/tests/src/Kernel/LanguageTestBase.php @@ -27,7 +27,7 @@ abstract class LanguageTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installConfig(['language']); diff --git a/core/modules/language/tests/src/Kernel/Views/LanguageTestBase.php b/core/modules/language/tests/src/Kernel/Views/LanguageTestBase.php index e78e962627..4e94243b90 100644 --- a/core/modules/language/tests/src/Kernel/Views/LanguageTestBase.php +++ b/core/modules/language/tests/src/Kernel/Views/LanguageTestBase.php @@ -20,7 +20,7 @@ abstract class LanguageTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp(); $this->installConfig(['language']); diff --git a/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php index 5b364f21d8..9b659573f6 100644 --- a/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php @@ -45,7 +45,7 @@ abstract class LayoutRestTestBase extends ResourceTestBase { /** * {@inheritdoc} */ - public function setUp() { + protected function setUp(): void { parent::setUp(); $assert_session = $this->assertSession(); diff --git a/core/modules/layout_builder/tests/src/Functional/Rest/OverrideSectionsTest.php b/core/modules/layout_builder/tests/src/Functional/Rest/OverrideSectionsTest.php index 9ea9fccec1..9f7f75d39f 100644 --- a/core/modules/layout_builder/tests/src/Functional/Rest/OverrideSectionsTest.php +++ b/core/modules/layout_builder/tests/src/Functional/Rest/OverrideSectionsTest.php @@ -28,7 +28,7 @@ class OverrideSectionsTest extends LayoutRestTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // @todo Figure why field definitions have to cleared in // https://www.drupal.org/project/drupal/issues/2985882. diff --git a/core/modules/layout_builder/tests/src/FunctionalJavascript/InlineBlockTestBase.php b/core/modules/layout_builder/tests/src/FunctionalJavascript/InlineBlockTestBase.php index dbf68d6179..293c450a91 100644 --- a/core/modules/layout_builder/tests/src/FunctionalJavascript/InlineBlockTestBase.php +++ b/core/modules/layout_builder/tests/src/FunctionalJavascript/InlineBlockTestBase.php @@ -44,7 +44,7 @@ abstract class InlineBlockTestBase extends WebDriverTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->drupalPlaceBlock('local_tasks_block'); diff --git a/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderCompatibilityTestBase.php b/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderCompatibilityTestBase.php index 526492f9f5..f4dab45b32 100644 --- a/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderCompatibilityTestBase.php +++ b/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderCompatibilityTestBase.php @@ -37,7 +37,7 @@ abstract class LayoutBuilderCompatibilityTestBase extends EntityKernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('entity_test_base_field_display'); diff --git a/core/modules/locale/tests/src/Functional/LocaleUpdateBase.php b/core/modules/locale/tests/src/Functional/LocaleUpdateBase.php index e6ddd71ee3..8edaa63773 100644 --- a/core/modules/locale/tests/src/Functional/LocaleUpdateBase.php +++ b/core/modules/locale/tests/src/Functional/LocaleUpdateBase.php @@ -52,7 +52,7 @@ abstract class LocaleUpdateBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Setup timestamps to identify old and new translation sources. diff --git a/core/modules/media/tests/src/Functional/MediaFunctionalTestTrait.php b/core/modules/media/tests/src/Functional/MediaFunctionalTestTrait.php index 379ba74717..702518dac3 100644 --- a/core/modules/media/tests/src/Functional/MediaFunctionalTestTrait.php +++ b/core/modules/media/tests/src/Functional/MediaFunctionalTestTrait.php @@ -56,7 +56,7 @@ trait MediaFunctionalTestTrait { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Have two users ready to be used in tests. diff --git a/core/modules/media/tests/src/Functional/Rest/MediaResourceTestBase.php b/core/modules/media/tests/src/Functional/Rest/MediaResourceTestBase.php index e3889ca802..eddbd54083 100644 --- a/core/modules/media/tests/src/Functional/Rest/MediaResourceTestBase.php +++ b/core/modules/media/tests/src/Functional/Rest/MediaResourceTestBase.php @@ -41,7 +41,7 @@ abstract class MediaResourceTestBase extends EntityResourceTestBase { /** * {@inheritdoc} */ - public function setUp() { + protected function setUp(): void { parent::setUp(); \Drupal::configFactory() diff --git a/core/modules/media/tests/src/FunctionalJavascript/MediaSourceTestBase.php b/core/modules/media/tests/src/FunctionalJavascript/MediaSourceTestBase.php index be926347c3..aadfcc54b2 100644 --- a/core/modules/media/tests/src/FunctionalJavascript/MediaSourceTestBase.php +++ b/core/modules/media/tests/src/FunctionalJavascript/MediaSourceTestBase.php @@ -14,7 +14,7 @@ abstract class MediaSourceTestBase extends MediaJavascriptTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Let's set the canonical flag in the base class of the source tests, diff --git a/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php b/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php index 231356635b..46c327def2 100644 --- a/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php +++ b/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php @@ -67,7 +67,7 @@ abstract class MediaEmbedFilterTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installSchema('file', ['file_usage']); diff --git a/core/modules/media/tests/src/Kernel/MediaKernelTestBase.php b/core/modules/media/tests/src/Kernel/MediaKernelTestBase.php index 8996f03fa4..34219df620 100644 --- a/core/modules/media/tests/src/Kernel/MediaKernelTestBase.php +++ b/core/modules/media/tests/src/Kernel/MediaKernelTestBase.php @@ -56,7 +56,7 @@ abstract class MediaKernelTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); diff --git a/core/modules/menu_link_content/tests/src/Kernel/Plugin/migrate/process/LinkUriTest.php b/core/modules/menu_link_content/tests/src/Kernel/Plugin/migrate/process/LinkUriTest.php index 0166df80c9..f52bd0f990 100644 --- a/core/modules/menu_link_content/tests/src/Kernel/Plugin/migrate/process/LinkUriTest.php +++ b/core/modules/menu_link_content/tests/src/Kernel/Plugin/migrate/process/LinkUriTest.php @@ -31,7 +31,7 @@ class LinkUriTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->setUpCurrentUser(); $this->installEntitySchema('node'); diff --git a/core/modules/migrate/tests/src/Kernel/MigrateExecutableTest.php b/core/modules/migrate/tests/src/Kernel/MigrateExecutableTest.php index 90f16acf70..3edd8d3146 100644 --- a/core/modules/migrate/tests/src/Kernel/MigrateExecutableTest.php +++ b/core/modules/migrate/tests/src/Kernel/MigrateExecutableTest.php @@ -19,7 +19,7 @@ class MigrateExecutableTest extends MigrateTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); $this->installEntitySchema('entity_test'); diff --git a/core/modules/migrate/tests/src/Kernel/MigrateExternalTranslatedTest.php b/core/modules/migrate/tests/src/Kernel/MigrateExternalTranslatedTest.php index 5a019ec2fd..f7e8ffae3a 100644 --- a/core/modules/migrate/tests/src/Kernel/MigrateExternalTranslatedTest.php +++ b/core/modules/migrate/tests/src/Kernel/MigrateExternalTranslatedTest.php @@ -31,7 +31,7 @@ class MigrateExternalTranslatedTest extends MigrateTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installSchema('system', ['sequences']); $this->installSchema('node', ['node_access']); diff --git a/core/modules/migrate/tests/src/Kernel/MigrateLookupTest.php b/core/modules/migrate/tests/src/Kernel/MigrateLookupTest.php index 4b2ec45b7d..4225653dda 100644 --- a/core/modules/migrate/tests/src/Kernel/MigrateLookupTest.php +++ b/core/modules/migrate/tests/src/Kernel/MigrateLookupTest.php @@ -36,7 +36,7 @@ class MigrateLookupTest extends MigrateTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->setTestLogger(); $this->migrateLookup = $this->container->get('migrate.lookup'); diff --git a/core/modules/migrate/tests/src/Kernel/MigrateSourceTestBase.php b/core/modules/migrate/tests/src/Kernel/MigrateSourceTestBase.php index 9efe7d0d4f..0c351aac4b 100644 --- a/core/modules/migrate/tests/src/Kernel/MigrateSourceTestBase.php +++ b/core/modules/migrate/tests/src/Kernel/MigrateSourceTestBase.php @@ -53,7 +53,7 @@ abstract class MigrateSourceTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create a mock migration. This will be injected into the source plugin diff --git a/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php b/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php index cac26168c2..e7a26205cd 100644 --- a/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php +++ b/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php @@ -63,7 +63,7 @@ abstract class MigrateTestBase extends KernelTestBase implements MigrateMessageI /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->createMigrationConnection(); $this->sourceDatabase = Database::getConnection('default', 'migrate'); @@ -104,7 +104,7 @@ private function createMigrationConnection() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { $this->cleanupMigrateConnection(); parent::tearDown(); $this->collectMessages = FALSE; diff --git a/core/modules/migrate/tests/src/Kernel/MigrationPluginManagerTest.php b/core/modules/migrate/tests/src/Kernel/MigrationPluginManagerTest.php index 17ca386f1d..44fe7878ba 100644 --- a/core/modules/migrate/tests/src/Kernel/MigrationPluginManagerTest.php +++ b/core/modules/migrate/tests/src/Kernel/MigrationPluginManagerTest.php @@ -26,7 +26,7 @@ class MigrationPluginManagerTest extends MigrateTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->migrationPluginManager = \Drupal::service('plugin.manager.migration'); } diff --git a/core/modules/migrate/tests/src/Kernel/Plugin/LogTest.php b/core/modules/migrate/tests/src/Kernel/Plugin/LogTest.php index f03d624187..299f7e5e13 100644 --- a/core/modules/migrate/tests/src/Kernel/Plugin/LogTest.php +++ b/core/modules/migrate/tests/src/Kernel/Plugin/LogTest.php @@ -37,7 +37,7 @@ class LogTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $definition = [ 'source' => [ diff --git a/core/modules/migrate/tests/src/Kernel/Plugin/id_map/SqlTest.php b/core/modules/migrate/tests/src/Kernel/Plugin/id_map/SqlTest.php index 6267771c46..dad421fbdc 100644 --- a/core/modules/migrate/tests/src/Kernel/Plugin/id_map/SqlTest.php +++ b/core/modules/migrate/tests/src/Kernel/Plugin/id_map/SqlTest.php @@ -49,7 +49,7 @@ class SqlTest extends MigrateTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->database = \Drupal::database(); $this->eventDispatcher = $this->prophesize(EventDispatcherInterface::class) diff --git a/core/modules/migrate/tests/src/Unit/MigrationPluginManagerTest.php b/core/modules/migrate/tests/src/Unit/MigrationPluginManagerTest.php index a6ff0931ea..49eb4bbd39 100644 --- a/core/modules/migrate/tests/src/Unit/MigrationPluginManagerTest.php +++ b/core/modules/migrate/tests/src/Unit/MigrationPluginManagerTest.php @@ -22,7 +22,7 @@ class MigrationPluginManagerTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Get a plugin manager for testing. diff --git a/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityTestBase.php b/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityTestBase.php index 2d2e1b4cd6..4a5ff3d8a1 100644 --- a/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityTestBase.php +++ b/core/modules/migrate/tests/src/Unit/Plugin/migrate/destination/EntityTestBase.php @@ -41,7 +41,7 @@ class EntityTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->migration = $this->prophesize(MigrationInterface::class); diff --git a/core/modules/migrate/tests/src/Unit/process/MigrateProcessTestCase.php b/core/modules/migrate/tests/src/Unit/process/MigrateProcessTestCase.php index cff1ee7359..0f50059a3f 100644 --- a/core/modules/migrate/tests/src/Unit/process/MigrateProcessTestCase.php +++ b/core/modules/migrate/tests/src/Unit/process/MigrateProcessTestCase.php @@ -24,7 +24,7 @@ abstract class MigrateProcessTestCase extends MigrateTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { $this->row = $this->getMockBuilder('Drupal\migrate\Row') ->disableOriginalConstructor() ->getMock(); diff --git a/core/modules/migrate/tests/src/Unit/process/MigrationLookupTestCase.php b/core/modules/migrate/tests/src/Unit/process/MigrationLookupTestCase.php index c22127dd9d..f23883aa8c 100644 --- a/core/modules/migrate/tests/src/Unit/process/MigrationLookupTestCase.php +++ b/core/modules/migrate/tests/src/Unit/process/MigrationLookupTestCase.php @@ -28,7 +28,7 @@ abstract class MigrationLookupTestCase extends MigrateProcessTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->migrateStub = $this->prophesize(MigrateStub::class); $this->migrateLookup = $this->prophesize(MigrateLookupInterface::class); diff --git a/core/modules/migrate_drupal/tests/src/Kernel/IdMapTableNoDummyTest.php b/core/modules/migrate_drupal/tests/src/Kernel/IdMapTableNoDummyTest.php index 6a3ff44f03..23a5667dbe 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/IdMapTableNoDummyTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/IdMapTableNoDummyTest.php @@ -21,7 +21,7 @@ class IdMapTableNoDummyTest extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->pluginManager = $this->container->get('plugin.manager.migration'); $this->pluginManager->createInstance('d6_user'); diff --git a/core/modules/migrate_drupal/tests/src/Kernel/MigrateDrupalTestBase.php b/core/modules/migrate_drupal/tests/src/Kernel/MigrateDrupalTestBase.php index 803fb1fa12..5cb4a95423 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/MigrateDrupalTestBase.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/MigrateDrupalTestBase.php @@ -27,7 +27,7 @@ abstract class MigrateDrupalTestBase extends MigrateTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $module_handler = \Drupal::moduleHandler(); diff --git a/core/modules/migrate_drupal/tests/src/Kernel/MigrateFieldPluginManagerTest.php b/core/modules/migrate_drupal/tests/src/Kernel/MigrateFieldPluginManagerTest.php index 69bde8bfca..ebd4df5be0 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/MigrateFieldPluginManagerTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/MigrateFieldPluginManagerTest.php @@ -39,7 +39,7 @@ class MigrateFieldPluginManagerTest extends MigrateDrupalTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->pluginManager = $this->container->get('plugin.manager.migrate.field'); } diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d6/FieldDiscoveryTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d6/FieldDiscoveryTest.php index 7085fa7239..1e561bcb0f 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d6/FieldDiscoveryTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d6/FieldDiscoveryTest.php @@ -65,7 +65,7 @@ class FieldDiscoveryTest extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installConfig(['node']); $this->executeMigration('d6_node_type'); diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrateDrupal6TestBase.php b/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrateDrupal6TestBase.php index ac58395aaf..3634627457 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrateDrupal6TestBase.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrateDrupal6TestBase.php @@ -29,7 +29,7 @@ abstract class MigrateDrupal6TestBase extends MigrateDrupalTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Add a node classic migrate table to the destination site so that tests // run by default with the classic node migrations. diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrationProcessTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrationProcessTest.php index 2e712542e4..cd08d217e2 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrationProcessTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d6/MigrationProcessTest.php @@ -16,7 +16,7 @@ class MigrationProcessTest extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { self::$modules = array_keys($this->coreModuleListDataProvider()); parent::setUp(); } diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d6/VariableTranslationCheckRequirementsTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d6/VariableTranslationCheckRequirementsTest.php index 03ee60ef0a..8f5767357c 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d6/VariableTranslationCheckRequirementsTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d6/VariableTranslationCheckRequirementsTest.php @@ -19,7 +19,7 @@ class VariableTranslationCheckRequirementsTest extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->sourceDatabase->schema()->dropTable('i18n_variable'); } diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php index 5ec106104d..2291ac3d63 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php @@ -70,7 +70,7 @@ class FieldDiscoveryTest extends MigrateDrupal7TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installConfig(static::$modules); $node_types = [ diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrateDrupal7TestBase.php b/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrateDrupal7TestBase.php index d3cc3ead90..58ebb4aa4d 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrateDrupal7TestBase.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrateDrupal7TestBase.php @@ -16,7 +16,7 @@ abstract class MigrateDrupal7TestBase extends MigrateDrupalTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Add a node classic migrate table to the destination site so that tests // run by default with the classic node migrations. diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrationProcessTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrationProcessTest.php index 9d0c24ae3e..24d8f7afe2 100644 --- a/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrationProcessTest.php +++ b/core/modules/migrate_drupal/tests/src/Kernel/d7/MigrationProcessTest.php @@ -16,7 +16,7 @@ class MigrationProcessTest extends MigrateDrupal7TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { self::$modules = array_keys($this->coreModuleListDataProvider()); parent::setUp(); } diff --git a/core/modules/migrate_drupal/tests/src/Unit/FieldDiscoveryTest.php b/core/modules/migrate_drupal/tests/src/Unit/FieldDiscoveryTest.php index 75180de694..809ace5229 100644 --- a/core/modules/migrate_drupal/tests/src/Unit/FieldDiscoveryTest.php +++ b/core/modules/migrate_drupal/tests/src/Unit/FieldDiscoveryTest.php @@ -42,7 +42,7 @@ class FieldDiscoveryTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->fieldPluginManager = $this->prophesize(MigrateFieldPluginManagerInterface::class); $this->migrationPluginManager = $this->prophesize(MigrationPluginManagerInterface::class); diff --git a/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php b/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php index a4ed2628ee..d21e103e4d 100644 --- a/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php +++ b/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php @@ -64,7 +64,7 @@ class DrupalSqlBaseTest extends MigrateTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->pluginDefinition['requirements_met'] = TRUE; $this->pluginDefinition['source_module'] = 'module1'; diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php index 5cb3915817..b77618ad57 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php @@ -14,7 +14,7 @@ abstract class MigrateUpgradeExecuteTestBase extends MigrateUpgradeTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create content. diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php index 1c61113ad3..b4cc93b8fd 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php @@ -46,7 +46,7 @@ abstract class MigrateUpgradeTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->createMigrationConnection(); $this->sourceDatabase = Database::getConnection('default', 'migrate_drupal_ui'); @@ -121,7 +121,7 @@ protected function createMigrationConnection() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { Database::removeConnection('migrate_drupal_ui'); parent::tearDown(); } diff --git a/core/modules/mysql/tests/src/Unit/ConnectionTest.php b/core/modules/mysql/tests/src/Unit/ConnectionTest.php index bb8bebbcbb..878d7672ad 100644 --- a/core/modules/mysql/tests/src/Unit/ConnectionTest.php +++ b/core/modules/mysql/tests/src/Unit/ConnectionTest.php @@ -31,7 +31,7 @@ class ConnectionTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { $this->pdoStatement = $this->prophesize(\PDOStatement::class); $this->pdoConnection = $this->prophesize(\PDO::class); } diff --git a/core/modules/node/tests/src/Functional/NodeTestBase.php b/core/modules/node/tests/src/Functional/NodeTestBase.php index 44dc2faec0..4f33341115 100644 --- a/core/modules/node/tests/src/Functional/NodeTestBase.php +++ b/core/modules/node/tests/src/Functional/NodeTestBase.php @@ -29,7 +29,7 @@ abstract class NodeTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create Basic page and Article node types. diff --git a/core/modules/node/tests/src/Functional/Views/NodeTestBase.php b/core/modules/node/tests/src/Functional/Views/NodeTestBase.php index f8590af4df..03d81554ba 100644 --- a/core/modules/node/tests/src/Functional/Views/NodeTestBase.php +++ b/core/modules/node/tests/src/Functional/Views/NodeTestBase.php @@ -17,7 +17,7 @@ abstract class NodeTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = ['node_test_views']) { + protected function setUp($import_test_views = TRUE, $modules = ['node_test_views']): void { parent::setUp($import_test_views, $modules); } diff --git a/core/modules/node/tests/src/FunctionalJavascript/NodePreviewLinkTest.php b/core/modules/node/tests/src/FunctionalJavascript/NodePreviewLinkTest.php index fd00a0e71c..5265eb9e84 100644 --- a/core/modules/node/tests/src/FunctionalJavascript/NodePreviewLinkTest.php +++ b/core/modules/node/tests/src/FunctionalJavascript/NodePreviewLinkTest.php @@ -25,7 +25,7 @@ class NodePreviewLinkTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $filtered_html_format = FilterFormat::create([ diff --git a/core/modules/node/tests/src/FunctionalJavascript/SettingSummariesContentTypeTest.php b/core/modules/node/tests/src/FunctionalJavascript/SettingSummariesContentTypeTest.php index 238d003b6c..99607edd4d 100644 --- a/core/modules/node/tests/src/FunctionalJavascript/SettingSummariesContentTypeTest.php +++ b/core/modules/node/tests/src/FunctionalJavascript/SettingSummariesContentTypeTest.php @@ -24,7 +24,7 @@ class SettingSummariesContentTypeTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser(['administer content types']); diff --git a/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeDeriverTest.php b/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeDeriverTest.php index 2794f4a616..9eef8e2159 100644 --- a/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeDeriverTest.php +++ b/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeDeriverTest.php @@ -20,7 +20,7 @@ class MigrateNodeDeriverTest extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->pluginManager = $this->container->get('plugin.manager.migration'); } diff --git a/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTestBase.php b/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTestBase.php index e225003d0b..f6a0c3893e 100644 --- a/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTestBase.php +++ b/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTestBase.php @@ -13,7 +13,7 @@ abstract class MigrateNodeTestBase extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('node'); diff --git a/core/modules/node/tests/src/Kernel/NodeAccessTestBase.php b/core/modules/node/tests/src/Kernel/NodeAccessTestBase.php index 32eca5d6ba..c3ff1d6c1c 100644 --- a/core/modules/node/tests/src/Kernel/NodeAccessTestBase.php +++ b/core/modules/node/tests/src/Kernel/NodeAccessTestBase.php @@ -52,7 +52,7 @@ abstract class NodeAccessTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installSchema('system', 'sequences'); $this->installSchema('node', 'node_access'); diff --git a/core/modules/options/tests/src/Functional/OptionsDynamicValuesTestBase.php b/core/modules/options/tests/src/Functional/OptionsDynamicValuesTestBase.php index bc5935771a..87e226e369 100644 --- a/core/modules/options/tests/src/Functional/OptionsDynamicValuesTestBase.php +++ b/core/modules/options/tests/src/Functional/OptionsDynamicValuesTestBase.php @@ -48,7 +48,7 @@ abstract class OptionsDynamicValuesTestBase extends FieldTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $field_name = 'test_options'; diff --git a/core/modules/options/tests/src/Kernel/OptionsFieldUnitTestBase.php b/core/modules/options/tests/src/Kernel/OptionsFieldUnitTestBase.php index af4ccc3421..a4b9b0e069 100644 --- a/core/modules/options/tests/src/Kernel/OptionsFieldUnitTestBase.php +++ b/core/modules/options/tests/src/Kernel/OptionsFieldUnitTestBase.php @@ -49,7 +49,7 @@ abstract class OptionsFieldUnitTestBase extends FieldKernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->fieldStorageDefinition = [ diff --git a/core/modules/options/tests/src/Kernel/Views/OptionsTestBase.php b/core/modules/options/tests/src/Kernel/Views/OptionsTestBase.php index a8395e4b8f..45b8f4f82c 100644 --- a/core/modules/options/tests/src/Kernel/Views/OptionsTestBase.php +++ b/core/modules/options/tests/src/Kernel/Views/OptionsTestBase.php @@ -51,7 +51,7 @@ abstract class OptionsTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp(); $this->mockStandardInstall(); diff --git a/core/modules/path/tests/src/Functional/PathTestBase.php b/core/modules/path/tests/src/Functional/PathTestBase.php index 2bffb4a4fb..8cee5cc1cd 100644 --- a/core/modules/path/tests/src/Functional/PathTestBase.php +++ b/core/modules/path/tests/src/Functional/PathTestBase.php @@ -22,7 +22,7 @@ abstract class PathTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create Basic page and Article node types. diff --git a/core/modules/path/tests/src/Kernel/Migrate/d7/MigrateUrlAliasTestBase.php b/core/modules/path/tests/src/Kernel/Migrate/d7/MigrateUrlAliasTestBase.php index e3341ffd0b..e31fae1c78 100644 --- a/core/modules/path/tests/src/Kernel/Migrate/d7/MigrateUrlAliasTestBase.php +++ b/core/modules/path/tests/src/Kernel/Migrate/d7/MigrateUrlAliasTestBase.php @@ -29,7 +29,7 @@ abstract class MigrateUrlAliasTestBase extends MigrateDrupal7TestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('node'); diff --git a/core/modules/quickedit/tests/src/Kernel/QuickEditTestBase.php b/core/modules/quickedit/tests/src/Kernel/QuickEditTestBase.php index b92af125ac..38a771f6d2 100644 --- a/core/modules/quickedit/tests/src/Kernel/QuickEditTestBase.php +++ b/core/modules/quickedit/tests/src/Kernel/QuickEditTestBase.php @@ -43,7 +43,7 @@ abstract class QuickEditTestBase extends KernelTestBase { /** * Sets the default field storage backend for fields created during tests. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->fields = new \ArrayObject([], \ArrayObject::ARRAY_AS_PROPS); diff --git a/core/modules/responsive_image/tests/src/Kernel/Migrate/d7/MigrateResponsiveImageStylesTest.php b/core/modules/responsive_image/tests/src/Kernel/Migrate/d7/MigrateResponsiveImageStylesTest.php index 3351219df1..1064d22b82 100644 --- a/core/modules/responsive_image/tests/src/Kernel/Migrate/d7/MigrateResponsiveImageStylesTest.php +++ b/core/modules/responsive_image/tests/src/Kernel/Migrate/d7/MigrateResponsiveImageStylesTest.php @@ -20,7 +20,7 @@ class MigrateResponsiveImageStylesTest extends MigrateDrupal7TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Ensure the 'picture' module is enabled in the source. $this->sourceDatabase->update('system') diff --git a/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php b/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php index e618ce22f2..c7fa7abf79 100644 --- a/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php +++ b/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php @@ -179,7 +179,7 @@ protected function provisionEntityResource($single_format = FALSE) { /** * {@inheritdoc} */ - public function setUp() { + protected function setUp(): void { parent::setUp(); // Calculate REST Resource config entity ID. diff --git a/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php b/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php index d95f4cd97c..56bceaf366 100644 --- a/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php +++ b/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php @@ -90,7 +90,7 @@ abstract class FileUploadResourceTestBase extends ResourceTestBase { /** * {@inheritdoc} */ - public function setUp() { + protected function setUp(): void { parent::setUp(); $this->fileStorage = $this->container->get('entity_type.manager') diff --git a/core/modules/rest/tests/src/Functional/ResourceTestBase.php b/core/modules/rest/tests/src/Functional/ResourceTestBase.php index 575bf976dc..5d32aa20bf 100644 --- a/core/modules/rest/tests/src/Functional/ResourceTestBase.php +++ b/core/modules/rest/tests/src/Functional/ResourceTestBase.php @@ -98,7 +98,7 @@ abstract class ResourceTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp() { + protected function setUp(): void { parent::setUp(); $this->serializer = $this->container->get('serializer'); diff --git a/core/modules/rest/tests/src/Functional/Views/RestExportAuthTest.php b/core/modules/rest/tests/src/Functional/Views/RestExportAuthTest.php index 15a1632be5..72a09a1505 100644 --- a/core/modules/rest/tests/src/Functional/Views/RestExportAuthTest.php +++ b/core/modules/rest/tests/src/Functional/Views/RestExportAuthTest.php @@ -25,7 +25,7 @@ class RestExportAuthTest extends ViewTestBase { /** * {@inheritdoc} */ - public function setUp($import_test_views = TRUE, $modules = []): void { + protected function setUp($import_test_views = TRUE, $modules = []): void { parent::setUp($import_test_views, $modules); $this->drupalLogin($this->drupalCreateUser(['administer views'])); diff --git a/core/modules/rest/tests/src/Kernel/RequestHandlerTest.php b/core/modules/rest/tests/src/Kernel/RequestHandlerTest.php index 141a517b1f..3da4471886 100644 --- a/core/modules/rest/tests/src/Kernel/RequestHandlerTest.php +++ b/core/modules/rest/tests/src/Kernel/RequestHandlerTest.php @@ -40,7 +40,7 @@ class RequestHandlerTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $serializer = $this->prophesize(SerializerInterface::class); $serializer->willImplement(DecoderInterface::class); diff --git a/core/modules/serialization/tests/src/Kernel/NormalizerTestBase.php b/core/modules/serialization/tests/src/Kernel/NormalizerTestBase.php index 8941394ea1..d3c7219ab3 100644 --- a/core/modules/serialization/tests/src/Kernel/NormalizerTestBase.php +++ b/core/modules/serialization/tests/src/Kernel/NormalizerTestBase.php @@ -29,7 +29,7 @@ abstract class NormalizerTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('entity_test_mulrev'); diff --git a/core/modules/shortcut/tests/src/Functional/ShortcutTestBase.php b/core/modules/shortcut/tests/src/Functional/ShortcutTestBase.php index 282ee3a44a..0bd0cd7c66 100644 --- a/core/modules/shortcut/tests/src/Functional/ShortcutTestBase.php +++ b/core/modules/shortcut/tests/src/Functional/ShortcutTestBase.php @@ -50,7 +50,7 @@ abstract class ShortcutTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); if ($this->profile != 'standard') { diff --git a/core/modules/statistics/tests/src/Functional/StatisticsTestBase.php b/core/modules/statistics/tests/src/Functional/StatisticsTestBase.php index 5f1e10da69..64188b1171 100644 --- a/core/modules/statistics/tests/src/Functional/StatisticsTestBase.php +++ b/core/modules/statistics/tests/src/Functional/StatisticsTestBase.php @@ -26,7 +26,7 @@ abstract class StatisticsTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Create Basic page node type. diff --git a/core/modules/system/tests/src/Functional/Cache/PageCacheTagsTestBase.php b/core/modules/system/tests/src/Functional/Cache/PageCacheTagsTestBase.php index 74f71bf331..8823e45b99 100644 --- a/core/modules/system/tests/src/Functional/Cache/PageCacheTagsTestBase.php +++ b/core/modules/system/tests/src/Functional/Cache/PageCacheTagsTestBase.php @@ -13,7 +13,7 @@ abstract class PageCacheTagsTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Enable page caching. diff --git a/core/modules/system/tests/src/Functional/Database/DatabaseTestBase.php b/core/modules/system/tests/src/Functional/Database/DatabaseTestBase.php index b10bb6f620..ff1e476d22 100644 --- a/core/modules/system/tests/src/Functional/Database/DatabaseTestBase.php +++ b/core/modules/system/tests/src/Functional/Database/DatabaseTestBase.php @@ -26,7 +26,7 @@ abstract class DatabaseTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->connection = Database::getConnection(); $this->addSampleData(); diff --git a/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php b/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php index 9c17f03c7c..34019fdddb 100644 --- a/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php +++ b/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php @@ -50,7 +50,7 @@ abstract class EntityCacheTagsTestBase extends PageCacheTagsTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Give anonymous users permission to view test entities, so that we can diff --git a/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php b/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php index 4f4d3e769c..eb03f83506 100644 --- a/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php +++ b/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php @@ -27,7 +27,7 @@ abstract class ModuleTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->adminUser = $this->drupalCreateUser([ diff --git a/core/modules/system/tests/src/Functional/Module/PrepareUninstallTest.php b/core/modules/system/tests/src/Functional/Module/PrepareUninstallTest.php index fa4d1456b9..4452c17740 100644 --- a/core/modules/system/tests/src/Functional/Module/PrepareUninstallTest.php +++ b/core/modules/system/tests/src/Functional/Module/PrepareUninstallTest.php @@ -44,7 +44,7 @@ class PrepareUninstallTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser(['administer modules']); diff --git a/core/modules/system/tests/src/Kernel/Token/TokenReplaceKernelTestBase.php b/core/modules/system/tests/src/Kernel/Token/TokenReplaceKernelTestBase.php index 469c2b91fa..ce9e0c05fd 100644 --- a/core/modules/system/tests/src/Kernel/Token/TokenReplaceKernelTestBase.php +++ b/core/modules/system/tests/src/Kernel/Token/TokenReplaceKernelTestBase.php @@ -33,7 +33,7 @@ abstract class TokenReplaceKernelTestBase extends EntityKernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Install default system configuration. $this->installConfig(['system']); diff --git a/core/modules/taxonomy/tests/src/Functional/TaxonomyTestBase.php b/core/modules/taxonomy/tests/src/Functional/TaxonomyTestBase.php index bc1f4ee65d..7371aa2a24 100644 --- a/core/modules/taxonomy/tests/src/Functional/TaxonomyTestBase.php +++ b/core/modules/taxonomy/tests/src/Functional/TaxonomyTestBase.php @@ -24,7 +24,7 @@ abstract class TaxonomyTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->drupalPlaceBlock('system_breadcrumb_block'); diff --git a/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyFieldFilterTest.php b/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyFieldFilterTest.php index 6f646c109c..14462824c2 100644 --- a/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyFieldFilterTest.php +++ b/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyFieldFilterTest.php @@ -60,7 +60,7 @@ class TaxonomyFieldFilterTest extends ViewTestBase { /** * {@inheritdoc} */ - public function setUp($import_test_views = TRUE, $modules = []): void { + protected function setUp($import_test_views = TRUE, $modules = []): void { parent::setUp($import_test_views, $modules); // Add two new languages. diff --git a/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyTestBase.php b/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyTestBase.php index 82f070603c..ed0235b1ac 100644 --- a/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyTestBase.php +++ b/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyTestBase.php @@ -55,7 +55,7 @@ abstract class TaxonomyTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = []) { + protected function setUp($import_test_views = TRUE, $modules = []): void { // Important: taxonomy_test_views module must not be in the $modules to // avoid an issue that particular view is already exists. parent::setUp($import_test_views, $modules); diff --git a/core/modules/taxonomy/tests/src/Functional/VocabularySerializationTest.php b/core/modules/taxonomy/tests/src/Functional/VocabularySerializationTest.php index 2386bfb5d3..b7fec2dec1 100644 --- a/core/modules/taxonomy/tests/src/Functional/VocabularySerializationTest.php +++ b/core/modules/taxonomy/tests/src/Functional/VocabularySerializationTest.php @@ -31,7 +31,7 @@ class VocabularySerializationTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); Vocabulary::create(['vid' => 'test'])->save(); diff --git a/core/modules/taxonomy/tests/src/Kernel/Views/TaxonomyTestBase.php b/core/modules/taxonomy/tests/src/Kernel/Views/TaxonomyTestBase.php index a2f902fb9e..e1f71f32be 100644 --- a/core/modules/taxonomy/tests/src/Kernel/Views/TaxonomyTestBase.php +++ b/core/modules/taxonomy/tests/src/Kernel/Views/TaxonomyTestBase.php @@ -74,7 +74,7 @@ abstract class TaxonomyTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp($import_test_views); // Install node config to create body field. diff --git a/core/modules/tour/tests/src/Functional/TourTestBasic.php b/core/modules/tour/tests/src/Functional/TourTestBasic.php index fb2fec7a0c..7a878ee1d6 100644 --- a/core/modules/tour/tests/src/Functional/TourTestBasic.php +++ b/core/modules/tour/tests/src/Functional/TourTestBasic.php @@ -42,7 +42,7 @@ abstract class TourTestBasic extends TourTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Make sure we are using distinct default and administrative themes for diff --git a/core/modules/tour/tests/src/FunctionalJavascript/TourJavascriptTest.php b/core/modules/tour/tests/src/FunctionalJavascript/TourJavascriptTest.php index 64ccd4dde0..51494d25e3 100644 --- a/core/modules/tour/tests/src/FunctionalJavascript/TourJavascriptTest.php +++ b/core/modules/tour/tests/src/FunctionalJavascript/TourJavascriptTest.php @@ -28,7 +28,7 @@ class TourJavascriptTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser([ diff --git a/core/modules/tour/tests/src/FunctionalJavascript/TourLegacyTest.php b/core/modules/tour/tests/src/FunctionalJavascript/TourLegacyTest.php index 2217f73bd3..0b485e2e44 100644 --- a/core/modules/tour/tests/src/FunctionalJavascript/TourLegacyTest.php +++ b/core/modules/tour/tests/src/FunctionalJavascript/TourLegacyTest.php @@ -29,7 +29,7 @@ class TourLegacyTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser([ diff --git a/core/modules/user/tests/src/Functional/Views/AccessTestBase.php b/core/modules/user/tests/src/Functional/Views/AccessTestBase.php index 2ef0b1d36c..d565bb099b 100644 --- a/core/modules/user/tests/src/Functional/Views/AccessTestBase.php +++ b/core/modules/user/tests/src/Functional/Views/AccessTestBase.php @@ -45,7 +45,7 @@ abstract class AccessTestBase extends UserTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = []) { + protected function setUp($import_test_views = TRUE, $modules = []): void { parent::setUp($import_test_views, $modules); $this->drupalPlaceBlock('system_breadcrumb_block'); diff --git a/core/modules/user/tests/src/Functional/Views/UserTestBase.php b/core/modules/user/tests/src/Functional/Views/UserTestBase.php index f860acad2e..4cacda4bf4 100644 --- a/core/modules/user/tests/src/Functional/Views/UserTestBase.php +++ b/core/modules/user/tests/src/Functional/Views/UserTestBase.php @@ -34,7 +34,7 @@ abstract class UserTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = ['user_test_views']) { + protected function setUp($import_test_views = TRUE, $modules = ['user_test_views']): void { parent::setUp($import_test_views, $modules); $this->users[] = $this->drupalCreateUser(); diff --git a/core/modules/user/tests/src/Kernel/Migrate/d6/ProfileFieldCheckRequirementsTest.php b/core/modules/user/tests/src/Kernel/Migrate/d6/ProfileFieldCheckRequirementsTest.php index fd6b057d2c..d6f5866d06 100644 --- a/core/modules/user/tests/src/Kernel/Migrate/d6/ProfileFieldCheckRequirementsTest.php +++ b/core/modules/user/tests/src/Kernel/Migrate/d6/ProfileFieldCheckRequirementsTest.php @@ -15,7 +15,7 @@ class ProfileFieldCheckRequirementsTest extends MigrateDrupal6TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->sourceDatabase->schema()->dropTable('profile_fields'); } diff --git a/core/modules/user/tests/src/Kernel/Migrate/d7/ProfileFieldCheckRequirementsTest.php b/core/modules/user/tests/src/Kernel/Migrate/d7/ProfileFieldCheckRequirementsTest.php index 9d3c2d166c..4bda849e95 100644 --- a/core/modules/user/tests/src/Kernel/Migrate/d7/ProfileFieldCheckRequirementsTest.php +++ b/core/modules/user/tests/src/Kernel/Migrate/d7/ProfileFieldCheckRequirementsTest.php @@ -15,7 +15,7 @@ class ProfileFieldCheckRequirementsTest extends MigrateDrupal7TestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->sourceDatabase->schema()->dropTable('profile_field'); } diff --git a/core/modules/user/tests/src/Kernel/Views/UserKernelTestBase.php b/core/modules/user/tests/src/Kernel/Views/UserKernelTestBase.php index 5f359956fe..1cefe22bd7 100644 --- a/core/modules/user/tests/src/Kernel/Views/UserKernelTestBase.php +++ b/core/modules/user/tests/src/Kernel/Views/UserKernelTestBase.php @@ -41,7 +41,7 @@ abstract class UserKernelTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp(); ViewTestData::createTestViews(static::class, ['user_test_views']); diff --git a/core/modules/user/tests/src/Unit/Plugin/Action/RoleUserTestBase.php b/core/modules/user/tests/src/Unit/Plugin/Action/RoleUserTestBase.php index 668fbd09ac..118835f1cc 100644 --- a/core/modules/user/tests/src/Unit/Plugin/Action/RoleUserTestBase.php +++ b/core/modules/user/tests/src/Unit/Plugin/Action/RoleUserTestBase.php @@ -26,7 +26,7 @@ abstract class RoleUserTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->account = $this diff --git a/core/modules/views/tests/src/Functional/Plugin/MonthDatePluginTest.php b/core/modules/views/tests/src/Functional/Plugin/MonthDatePluginTest.php index 270b1f88af..b9281a829e 100644 --- a/core/modules/views/tests/src/Functional/Plugin/MonthDatePluginTest.php +++ b/core/modules/views/tests/src/Functional/Plugin/MonthDatePluginTest.php @@ -48,7 +48,7 @@ class MonthDatePluginTest extends ViewTestBase { /** * {@inheritdoc} */ - public function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { + protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { parent::setUp($import_test_views, $modules); $utc = new \DateTimeZone('UTC'); $format = 'Y-m-d h:i:s'; diff --git a/core/modules/views/tests/src/Functional/Plugin/ViewsBulkTest.php b/core/modules/views/tests/src/Functional/Plugin/ViewsBulkTest.php index ba20754116..c0be12e33d 100644 --- a/core/modules/views/tests/src/Functional/Plugin/ViewsBulkTest.php +++ b/core/modules/views/tests/src/Functional/Plugin/ViewsBulkTest.php @@ -33,7 +33,7 @@ class ViewsBulkTest extends ViewTestBase { /** * {@inheritdoc} */ - public function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { + protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { parent::setUp($import_test_views, $modules); $this->drupalCreateContentType(['type' => 'page']); diff --git a/core/modules/views/tests/src/Functional/ViewTestBase.php b/core/modules/views/tests/src/Functional/ViewTestBase.php index 86eec8c09d..de7eeb084f 100644 --- a/core/modules/views/tests/src/Functional/ViewTestBase.php +++ b/core/modules/views/tests/src/Functional/ViewTestBase.php @@ -39,7 +39,7 @@ abstract class ViewTestBase extends BrowserTestBase { * @param array $modules * The module directories to look in for test views. */ - protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']) { + protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { parent::setUp(); if ($import_test_views) { ViewTestData::createTestViews(static::class, $modules); diff --git a/core/modules/views/tests/src/Functional/ViewTranslationTest.php b/core/modules/views/tests/src/Functional/ViewTranslationTest.php index 62cd09b1f8..b29df6c6c9 100644 --- a/core/modules/views/tests/src/Functional/ViewTranslationTest.php +++ b/core/modules/views/tests/src/Functional/ViewTranslationTest.php @@ -31,7 +31,7 @@ class ViewTranslationTest extends ViewTestBase { /** * {@inheritdoc} */ - public function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { + protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { parent::setUp($import_test_views, $modules); $this->enableViewsTestModule(); diff --git a/core/modules/views/tests/src/Functional/Wizard/WizardTestBase.php b/core/modules/views/tests/src/Functional/Wizard/WizardTestBase.php index e85540a79d..8bf877ce13 100644 --- a/core/modules/views/tests/src/Functional/Wizard/WizardTestBase.php +++ b/core/modules/views/tests/src/Functional/Wizard/WizardTestBase.php @@ -19,7 +19,7 @@ abstract class WizardTestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = []) { + protected function setUp($import_test_views = TRUE, $modules = []): void { parent::setUp($import_test_views, $modules); // Create and log in a user with administer views permission. diff --git a/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php b/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php index 8a8e864106..27b399434d 100644 --- a/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php +++ b/core/modules/views/tests/src/FunctionalJavascript/BlockExposedFilterAJAXTest.php @@ -32,7 +32,7 @@ class BlockExposedFilterAJAXTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); ViewTestData::createTestViews(self::class, ['views_test_config']); $this->createContentType(['type' => 'page']); diff --git a/core/modules/views/tests/src/Kernel/Handler/FieldFieldAccessTestBase.php b/core/modules/views/tests/src/Kernel/Handler/FieldFieldAccessTestBase.php index 6c515446ba..b963c8d58c 100644 --- a/core/modules/views/tests/src/Kernel/Handler/FieldFieldAccessTestBase.php +++ b/core/modules/views/tests/src/Kernel/Handler/FieldFieldAccessTestBase.php @@ -35,7 +35,7 @@ abstract class FieldFieldAccessTestBase extends ViewsKernelTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp($import_test_views); $this->installEntitySchema('user'); diff --git a/core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php b/core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php index e3af455137..3ab59f3c93 100644 --- a/core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php +++ b/core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php @@ -44,7 +44,7 @@ abstract class ViewsKernelTestBase extends KernelTestBase { * to setup some additional stuff, like fields, you need to call false and * then call createTestViews for your own. */ - protected function setUp($import_test_views = TRUE) { + protected function setUp($import_test_views = TRUE): void { parent::setUp(); $this->installSchema('system', ['sequences']); diff --git a/core/modules/views/tests/src/Unit/Plugin/views/query/MysqlDateSqlTest.php b/core/modules/views/tests/src/Unit/Plugin/views/query/MysqlDateSqlTest.php index 908597e757..be5e30d877 100644 --- a/core/modules/views/tests/src/Unit/Plugin/views/query/MysqlDateSqlTest.php +++ b/core/modules/views/tests/src/Unit/Plugin/views/query/MysqlDateSqlTest.php @@ -25,7 +25,7 @@ class MysqlDateSqlTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->database = $this->prophesize(Connection::class)->reveal(); } diff --git a/core/modules/views/tests/src/Unit/Plugin/views/query/PostgresqlDateSqlTest.php b/core/modules/views/tests/src/Unit/Plugin/views/query/PostgresqlDateSqlTest.php index 2ea1f72fca..e1892b9612 100644 --- a/core/modules/views/tests/src/Unit/Plugin/views/query/PostgresqlDateSqlTest.php +++ b/core/modules/views/tests/src/Unit/Plugin/views/query/PostgresqlDateSqlTest.php @@ -25,7 +25,7 @@ class PostgresqlDateSqlTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->database = $this->prophesize(Connection::class)->reveal(); } diff --git a/core/modules/views/tests/src/Unit/Plugin/views/query/SqliteDateSqlTest.php b/core/modules/views/tests/src/Unit/Plugin/views/query/SqliteDateSqlTest.php index d07f67cbe3..3de9ba72fa 100644 --- a/core/modules/views/tests/src/Unit/Plugin/views/query/SqliteDateSqlTest.php +++ b/core/modules/views/tests/src/Unit/Plugin/views/query/SqliteDateSqlTest.php @@ -25,7 +25,7 @@ class SqliteDateSqlTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->database = $this->prophesize(Connection::class)->reveal(); } diff --git a/core/modules/views_ui/tests/src/Functional/UITestBase.php b/core/modules/views_ui/tests/src/Functional/UITestBase.php index 0bbe120005..3f5cb0476b 100644 --- a/core/modules/views_ui/tests/src/Functional/UITestBase.php +++ b/core/modules/views_ui/tests/src/Functional/UITestBase.php @@ -33,7 +33,7 @@ abstract class UITestBase extends ViewTestBase { /** * {@inheritdoc} */ - protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']) { + protected function setUp($import_test_views = TRUE, $modules = ['views_test_config']): void { parent::setUp($import_test_views, $modules); $this->enableViewsTestModule(); diff --git a/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php b/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php index 559acbb481..254468e899 100644 --- a/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php @@ -44,7 +44,7 @@ class DisplayTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); ViewTestData::createTestViews(self::class, ['views_test_config']); diff --git a/core/modules/views_ui/tests/src/FunctionalJavascript/FilterCriteriaTest.php b/core/modules/views_ui/tests/src/FunctionalJavascript/FilterCriteriaTest.php index 857dcf61f0..f1bc9e42e5 100644 --- a/core/modules/views_ui/tests/src/FunctionalJavascript/FilterCriteriaTest.php +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/FilterCriteriaTest.php @@ -24,7 +24,7 @@ class FilterCriteriaTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser([ diff --git a/core/modules/views_ui/tests/src/FunctionalJavascript/FilterOptionsTest.php b/core/modules/views_ui/tests/src/FunctionalJavascript/FilterOptionsTest.php index ab58d5f0a2..7a2b4c75e8 100644 --- a/core/modules/views_ui/tests/src/FunctionalJavascript/FilterOptionsTest.php +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/FilterOptionsTest.php @@ -29,7 +29,7 @@ class FilterOptionsTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser([ diff --git a/core/modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php b/core/modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php index 0064cca39b..4184efd769 100644 --- a/core/modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php @@ -39,7 +39,7 @@ class PreviewTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); ViewTestData::createTestViews(self::class, ['views_test_config']); diff --git a/core/modules/workspaces/tests/src/Functional/WorkspaceTest.php b/core/modules/workspaces/tests/src/Functional/WorkspaceTest.php index a0058d73b6..5c04a00ba2 100644 --- a/core/modules/workspaces/tests/src/Functional/WorkspaceTest.php +++ b/core/modules/workspaces/tests/src/Functional/WorkspaceTest.php @@ -52,7 +52,7 @@ class WorkspaceTest extends BrowserTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $permissions = [ 'access administration pages', diff --git a/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php index e13b450200..ef6f17d24e 100644 --- a/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php +++ b/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php @@ -152,7 +152,7 @@ abstract class BuildTestBase extends TestCase { /** * {@inheritdoc} */ - public static function setUpBeforeClass() { + public static function setUpBeforeClass(): void { parent::setUpBeforeClass(); static::checkClassCommandRequirements(); } @@ -160,7 +160,7 @@ public static function setUpBeforeClass() { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); static::checkMethodCommandRequirements($this->getName()); $this->phpFinder = new PhpExecutableFinder(); @@ -176,7 +176,7 @@ protected function setUp() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { parent::tearDown(); $this->stopServer(); diff --git a/core/tests/Drupal/FunctionalJavascriptTests/Ajax/ThrobberTest.php b/core/tests/Drupal/FunctionalJavascriptTests/Ajax/ThrobberTest.php index 610c00daca..11451559f3 100644 --- a/core/tests/Drupal/FunctionalJavascriptTests/Ajax/ThrobberTest.php +++ b/core/tests/Drupal/FunctionalJavascriptTests/Ajax/ThrobberTest.php @@ -30,7 +30,7 @@ class ThrobberTest extends WebDriverTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $admin_user = $this->drupalCreateUser([ diff --git a/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php b/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php index 20f0478273..7f92b9ed00 100644 --- a/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php +++ b/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php @@ -90,7 +90,7 @@ protected function initFrontPage() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { if ($this->mink) { $status = $this->getStatus(); if ($status === BaseTestRunner::STATUS_ERROR || $status === BaseTestRunner::STATUS_WARNING || $status === BaseTestRunner::STATUS_FAILURE) { diff --git a/core/tests/Drupal/FunctionalTests/Image/ToolkitTestBase.php b/core/tests/Drupal/FunctionalTests/Image/ToolkitTestBase.php index 9c015971ef..28298cd154 100644 --- a/core/tests/Drupal/FunctionalTests/Image/ToolkitTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Image/ToolkitTestBase.php @@ -55,7 +55,7 @@ abstract class ToolkitTestBase extends BrowserTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Set the image factory service. diff --git a/core/tests/Drupal/FunctionalTests/Installer/InstallerTestBase.php b/core/tests/Drupal/FunctionalTests/Installer/InstallerTestBase.php index 1cc8300aad..5bf4918d08 100644 --- a/core/tests/Drupal/FunctionalTests/Installer/InstallerTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Installer/InstallerTestBase.php @@ -89,7 +89,7 @@ protected function installParameters() { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUpAppRoot(); $this->isInstalled = FALSE; diff --git a/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php b/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php index fa0ba28ed7..22b6aeabc7 100644 --- a/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php @@ -125,7 +125,7 @@ abstract class UpdatePathTestBase extends BrowserTestBase { * then needed to set various things such as the config directories and the * container that would normally be done via the installer. */ - protected function setUp() { + protected function setUp(): void { parent::setUpAppRoot(); $this->zlibInstalled = function_exists('gzopen'); diff --git a/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php b/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php index 5661d5b596..0e67d2348f 100644 --- a/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php @@ -104,7 +104,7 @@ protected function getCacheBackend($bin = NULL) { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { $this->cachebackends = []; $this->defaultValue = $this->randomMachineName(10); @@ -116,7 +116,7 @@ protected function setUp() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { // Destruct the registered backend, each test will get a fresh instance, // properly emptying it here ensure that on persistent data backends they // will come up empty the next test. diff --git a/core/tests/Drupal/KernelTests/Core/Database/DatabaseTestBase.php b/core/tests/Drupal/KernelTests/Core/Database/DatabaseTestBase.php index 82a9210fd0..d6b8284ad4 100644 --- a/core/tests/Drupal/KernelTests/Core/Database/DatabaseTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/Database/DatabaseTestBase.php @@ -28,7 +28,7 @@ abstract class DatabaseTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->connection = Database::getConnection(); $this->installSampleSchema(); diff --git a/core/tests/Drupal/KernelTests/Core/Entity/EntityAccessControlHandlerTest.php b/core/tests/Drupal/KernelTests/Core/Entity/EntityAccessControlHandlerTest.php index 56ebe98459..3f303dc90f 100644 --- a/core/tests/Drupal/KernelTests/Core/Entity/EntityAccessControlHandlerTest.php +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityAccessControlHandlerTest.php @@ -28,7 +28,7 @@ class EntityAccessControlHandlerTest extends EntityLanguageTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('entity_test_no_uuid'); diff --git a/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php b/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php index 2e061cdd77..1b83fee07d 100644 --- a/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php @@ -58,7 +58,7 @@ abstract class EntityKernelTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->entityTypeManager = $this->container->get('entity_type.manager'); diff --git a/core/tests/Drupal/KernelTests/Core/Entity/EntityLanguageTestBase.php b/core/tests/Drupal/KernelTests/Core/Entity/EntityLanguageTestBase.php index efeb109d70..6066118ff7 100644 --- a/core/tests/Drupal/KernelTests/Core/Entity/EntityLanguageTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityLanguageTestBase.php @@ -44,7 +44,7 @@ abstract class EntityLanguageTestBase extends EntityKernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->languageManager = $this->container->get('language_manager'); diff --git a/core/tests/Drupal/KernelTests/Core/Entity/EntityRepositoryTest.php b/core/tests/Drupal/KernelTests/Core/Entity/EntityRepositoryTest.php index bd36cad7b0..c6f99a11e8 100644 --- a/core/tests/Drupal/KernelTests/Core/Entity/EntityRepositoryTest.php +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityRepositoryTest.php @@ -48,7 +48,7 @@ class EntityRepositoryTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->entityTypeManager = $this->container->get('entity_type.manager'); diff --git a/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php b/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php index 374bf6239e..2b052f83fa 100644 --- a/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php @@ -35,7 +35,7 @@ abstract class FileTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // \Drupal\KernelTests\KernelTestBase::bootKernel() sets a global override // for the default scheme because core relies on it in diff --git a/core/tests/Drupal/KernelTests/Core/File/StreamWrapperTest.php b/core/tests/Drupal/KernelTests/Core/File/StreamWrapperTest.php index c706cb30fc..af7d8d2350 100644 --- a/core/tests/Drupal/KernelTests/Core/File/StreamWrapperTest.php +++ b/core/tests/Drupal/KernelTests/Core/File/StreamWrapperTest.php @@ -40,7 +40,7 @@ class StreamWrapperTest extends FileTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Add file_private_path setting. diff --git a/core/tests/Drupal/KernelTests/Core/KeyValueStore/StorageTestBase.php b/core/tests/Drupal/KernelTests/Core/KeyValueStore/StorageTestBase.php index aa599187a3..cc64775f1e 100644 --- a/core/tests/Drupal/KernelTests/Core/KeyValueStore/StorageTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/KeyValueStore/StorageTestBase.php @@ -33,7 +33,7 @@ abstract class StorageTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Define two data collections, diff --git a/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginBaseTest.php b/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginBaseTest.php index 28b762ffcc..bb2d4dd501 100644 --- a/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginBaseTest.php +++ b/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginBaseTest.php @@ -32,7 +32,7 @@ class ContextAwarePluginBaseTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $configuration = [ 'context' => [ diff --git a/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginTraitTest.php b/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginTraitTest.php index b5a7aeb2e7..98df3076b7 100644 --- a/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginTraitTest.php +++ b/core/tests/Drupal/KernelTests/Core/Plugin/Context/ContextAwarePluginTraitTest.php @@ -45,7 +45,7 @@ class ContextAwarePluginTraitTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $plugin_definition = new TestContextAwarePluginDefinition(); $plugin_definition->addContextDefinition('nato_letter', ContextDefinition::create('string')); diff --git a/core/tests/Drupal/KernelTests/Core/Plugin/PluginTestBase.php b/core/tests/Drupal/KernelTests/Core/Plugin/PluginTestBase.php index 0b4bcedfce..16c87953ad 100644 --- a/core/tests/Drupal/KernelTests/Core/Plugin/PluginTestBase.php +++ b/core/tests/Drupal/KernelTests/Core/Plugin/PluginTestBase.php @@ -32,7 +32,7 @@ abstract class PluginTestBase extends KernelTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Real modules implementing plugin types may expose a module-specific API diff --git a/core/tests/Drupal/KernelTests/Core/TypedData/RecursiveContextualValidatorTest.php b/core/tests/Drupal/KernelTests/Core/TypedData/RecursiveContextualValidatorTest.php index 6e5269e7db..acff891975 100644 --- a/core/tests/Drupal/KernelTests/Core/TypedData/RecursiveContextualValidatorTest.php +++ b/core/tests/Drupal/KernelTests/Core/TypedData/RecursiveContextualValidatorTest.php @@ -24,7 +24,7 @@ class RecursiveContextualValidatorTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->installEntitySchema('user'); $this->installEntitySchema('entity_test'); diff --git a/core/tests/Drupal/KernelTests/KernelTestBase.php b/core/tests/Drupal/KernelTests/KernelTestBase.php index 43d7e21f2b..b95549cee9 100644 --- a/core/tests/Drupal/KernelTests/KernelTestBase.php +++ b/core/tests/Drupal/KernelTests/KernelTestBase.php @@ -229,7 +229,7 @@ abstract class KernelTestBase extends TestCase implements ServiceProviderInterfa /** * {@inheritdoc} */ - public static function setUpBeforeClass() { + public static function setUpBeforeClass(): void { parent::setUpBeforeClass(); VarDumper::setHandler(TestVarDumper::class . '::cliHandler'); @@ -240,7 +240,7 @@ public static function setUpBeforeClass() { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Allow tests to compare MarkupInterface objects via assertEquals(). @@ -615,7 +615,7 @@ protected function getConfigSchemaExclusions() { /** * {@inheritdoc} */ - protected function assertPostConditions() { + protected function assertPostConditions(): void { // Execute registered Drupal shutdown functions prior to tearing down. // @see _drupal_shutdown_function() $callbacks = &drupal_register_shutdown_function(); @@ -635,7 +635,7 @@ protected function assertPostConditions() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { // Destroy the testing kernel. if (isset($this->kernel)) { $this->kernel->shutdown(); diff --git a/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php b/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php index 1a17d27df7..01055923fa 100644 --- a/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php +++ b/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php @@ -83,11 +83,6 @@ private static function alterTestCase(ClassLoader $autoloader): void { $alteredCode = file_get_contents($alteredFile); $alteredCode = preg_replace('/abstract class TestCase[^\{]+\{/', '$0 ' . \PHP_EOL . " use \Symfony\Bridge\PhpUnit\Legacy\PolyfillTestCaseTrait;" . \PHP_EOL, $alteredCode, 1); $alteredCode = str_replace("__DIR__ . '/../Util/", "'$phpunit_dir/src/Util/", $alteredCode); - // While Drupal still allows methods in test base classes that inherit from - // TestCase with no void return typehints specified, we also alter TestCase - // to remove the typehints. - // @see https://www.drupal.org/project/drupal/issues/3182103 - $alteredCode = preg_replace('/^ ((?:protected|public)(?: static)? function \w+\(\)): void/m', ' $1', $alteredCode); include static::flushAlteredCodeToFile('TestCase.php', $alteredCode); } diff --git a/core/tests/Drupal/Tests/BrowserTestBase.php b/core/tests/Drupal/Tests/BrowserTestBase.php index 4c452d0051..a9efc89fdf 100644 --- a/core/tests/Drupal/Tests/BrowserTestBase.php +++ b/core/tests/Drupal/Tests/BrowserTestBase.php @@ -209,7 +209,7 @@ abstract class BrowserTestBase extends TestCase { /** * {@inheritdoc} */ - public static function setUpBeforeClass() { + public static function setUpBeforeClass(): void { parent::setUpBeforeClass(); VarDumper::setHandler(TestVarDumper::class . '::cliHandler'); } @@ -349,7 +349,7 @@ protected function registerSessions() {} /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->setUpAppRoot(); @@ -429,7 +429,7 @@ protected function cleanupEnvironment() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { parent::tearDown(); // Destroy the testing kernel. diff --git a/core/tests/Drupal/Tests/Component/Annotation/Doctrine/Ticket/DCOM58Test.php b/core/tests/Drupal/Tests/Component/Annotation/Doctrine/Ticket/DCOM58Test.php index 9423fd26b3..8f0d3f945a 100644 --- a/core/tests/Drupal/Tests/Component/Annotation/Doctrine/Ticket/DCOM58Test.php +++ b/core/tests/Drupal/Tests/Component/Annotation/Doctrine/Ticket/DCOM58Test.php @@ -20,7 +20,7 @@ */ class DCOM58Test extends TestCase { - public function setUp(): void + protected function setUp(): void { // Some class named Entity in the global namespace. include __DIR__ .'/DCOM58Entity.php'; diff --git a/core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageBase.php b/core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageBase.php index 60a78af855..671dee7c2d 100644 --- a/core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageBase.php +++ b/core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageBase.php @@ -42,7 +42,7 @@ abstract class MTimeProtectedFileStorageBase extends PhpStorageTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Random generator. diff --git a/core/tests/Drupal/Tests/Component/PhpStorage/PhpStorageTestBase.php b/core/tests/Drupal/Tests/Component/PhpStorage/PhpStorageTestBase.php index 72903fe809..c670bebadf 100644 --- a/core/tests/Drupal/Tests/Component/PhpStorage/PhpStorageTestBase.php +++ b/core/tests/Drupal/Tests/Component/PhpStorage/PhpStorageTestBase.php @@ -22,7 +22,7 @@ abstract class PhpStorageTestBase extends TestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); vfsStream::setup('exampleDir'); $this->directory = vfsStream::url('exampleDir'); diff --git a/core/tests/Drupal/Tests/Component/Serialization/YamlTest.php b/core/tests/Drupal/Tests/Component/Serialization/YamlTest.php index 5156293290..1aa6b8ddae 100644 --- a/core/tests/Drupal/Tests/Component/Serialization/YamlTest.php +++ b/core/tests/Drupal/Tests/Component/Serialization/YamlTest.php @@ -23,7 +23,7 @@ class YamlTest extends TestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->mockParser = $this->getMockBuilder('\stdClass') ->addMethods(['encode', 'decode', 'getFileExtension']) @@ -34,7 +34,7 @@ public function setUp(): void { /** * {@inheritdoc} */ - public function tearDown(): void { + protected function tearDown(): void { YamlParserProxy::setMock(NULL); parent::tearDown(); } diff --git a/core/tests/Drupal/Tests/Composer/Plugin/Scaffold/Fixtures.php b/core/tests/Drupal/Tests/Composer/Plugin/Scaffold/Fixtures.php index 147bd98b53..5391087cf1 100644 --- a/core/tests/Drupal/Tests/Composer/Plugin/Scaffold/Fixtures.php +++ b/core/tests/Drupal/Tests/Composer/Plugin/Scaffold/Fixtures.php @@ -301,7 +301,7 @@ public function createIsolatedComposerCacheDir() { /** * Calls 'tearDown' in any test that copies fixtures to transient locations. */ - public function tearDown(): void { + public function tearDown() { // Remove any temporary directories that were created. $filesystem = new Filesystem(); foreach ($this->tmpDirs as $dir) { diff --git a/core/tests/Drupal/Tests/Composer/Plugin/VendorHardening/VendorHardeningPluginTest.php b/core/tests/Drupal/Tests/Composer/Plugin/VendorHardening/VendorHardeningPluginTest.php index c393593ebf..5b43d9a034 100644 --- a/core/tests/Drupal/Tests/Composer/Plugin/VendorHardening/VendorHardeningPluginTest.php +++ b/core/tests/Drupal/Tests/Composer/Plugin/VendorHardening/VendorHardeningPluginTest.php @@ -25,7 +25,7 @@ class VendorHardeningPluginTest extends TestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); vfsStream::setup('vendor', NULL, [ 'drupal' => [ diff --git a/core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php b/core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php index 05e7a51cbc..0ae737516e 100644 --- a/core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php +++ b/core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php @@ -45,7 +45,7 @@ class AssertLegacyTraitTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->page = $this->prophesize(DocumentElement::class); diff --git a/core/tests/Drupal/Tests/Core/Assert/WebAssertArgumentsTest.php b/core/tests/Drupal/Tests/Core/Assert/WebAssertArgumentsTest.php index bb5de5fc43..1e2476514d 100644 --- a/core/tests/Drupal/Tests/Core/Assert/WebAssertArgumentsTest.php +++ b/core/tests/Drupal/Tests/Core/Assert/WebAssertArgumentsTest.php @@ -46,7 +46,7 @@ class WebAssertArgumentsTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->page = $this->prophesize(DocumentElement::class); diff --git a/core/tests/Drupal/Tests/Core/Cache/Context/SessionCacheContextTest.php b/core/tests/Drupal/Tests/Core/Cache/Context/SessionCacheContextTest.php index 794f645e23..50219f31d2 100644 --- a/core/tests/Drupal/Tests/Core/Cache/Context/SessionCacheContextTest.php +++ b/core/tests/Drupal/Tests/Core/Cache/Context/SessionCacheContextTest.php @@ -37,7 +37,7 @@ class SessionCacheContextTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { $this->request = new Request(); $this->requestStack = new RequestStack(); diff --git a/core/tests/Drupal/Tests/Core/Command/GenerateThemeTest.php b/core/tests/Drupal/Tests/Core/Command/GenerateThemeTest.php index 14dfdda5db..5aa980067d 100644 --- a/core/tests/Drupal/Tests/Core/Command/GenerateThemeTest.php +++ b/core/tests/Drupal/Tests/Core/Command/GenerateThemeTest.php @@ -27,7 +27,7 @@ class GenerateThemeTest extends QuickStartTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { if (version_compare(\SQLite3::version()['versionString'], Tasks::SQLITE_MINIMUM_VERSION) < 0) { $this->markTestSkipped(); } diff --git a/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php b/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php index 61d4a55d23..bcce6a91a4 100644 --- a/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php +++ b/core/tests/Drupal/Tests/Core/Command/QuickStartTest.php @@ -49,7 +49,7 @@ class QuickStartTest extends TestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $php_executable_finder = new PhpExecutableFinder(); $this->php = $php_executable_finder->find(); @@ -65,7 +65,7 @@ public function setUp(): void { /** * {@inheritdoc} */ - public function tearDown(): void { + protected function tearDown(): void { if ($this->testDb) { $test_site_directory = $this->root . DIRECTORY_SEPARATOR . $this->testDb->getTestSitePath(); if (file_exists($test_site_directory)) { diff --git a/core/tests/Drupal/Tests/Core/Field/BaseFieldDefinitionTestBase.php b/core/tests/Drupal/Tests/Core/Field/BaseFieldDefinitionTestBase.php index 1ef112f65b..c2f45ae311 100644 --- a/core/tests/Drupal/Tests/Core/Field/BaseFieldDefinitionTestBase.php +++ b/core/tests/Drupal/Tests/Core/Field/BaseFieldDefinitionTestBase.php @@ -23,7 +23,7 @@ abstract class BaseFieldDefinitionTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // getModuleAndPath() returns an array of the module name and directory. diff --git a/core/tests/Drupal/Tests/Core/Form/FormStateDecoratorBaseTest.php b/core/tests/Drupal/Tests/Core/Form/FormStateDecoratorBaseTest.php index f8d2db7677..114340c472 100644 --- a/core/tests/Drupal/Tests/Core/Form/FormStateDecoratorBaseTest.php +++ b/core/tests/Drupal/Tests/Core/Form/FormStateDecoratorBaseTest.php @@ -35,7 +35,7 @@ class FormStateDecoratorBaseTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->decoratedFormState = $this->prophesize(FormStateInterface::class); diff --git a/core/tests/Drupal/Tests/Core/Form/FormTestBase.php b/core/tests/Drupal/Tests/Core/Form/FormTestBase.php index 068e78ab81..f10f79be83 100644 --- a/core/tests/Drupal/Tests/Core/Form/FormTestBase.php +++ b/core/tests/Drupal/Tests/Core/Form/FormTestBase.php @@ -145,7 +145,7 @@ abstract class FormTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Add functions to the global namespace for testing. @@ -193,7 +193,7 @@ protected function setUp() { /** * {@inheritdoc} */ - protected function tearDown() { + protected function tearDown(): void { Html::resetSeenIds(); (new FormState())->clearErrors(); } diff --git a/core/tests/Drupal/Tests/Core/Menu/LocalTaskIntegrationTestBase.php b/core/tests/Drupal/Tests/Core/Menu/LocalTaskIntegrationTestBase.php index 052a969ab9..ec5a48ed79 100644 --- a/core/tests/Drupal/Tests/Core/Menu/LocalTaskIntegrationTestBase.php +++ b/core/tests/Drupal/Tests/Core/Menu/LocalTaskIntegrationTestBase.php @@ -40,7 +40,7 @@ abstract class LocalTaskIntegrationTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $container = new ContainerBuilder(); diff --git a/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php b/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php index f35d1e054d..e96a2d864d 100644 --- a/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php +++ b/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php @@ -46,7 +46,7 @@ abstract class LazyPluginCollectionTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { $this->pluginManager = $this->createMock('Drupal\Component\Plugin\PluginManagerInterface'); $this->pluginManager->expects($this->any()) ->method('getDefinitions') diff --git a/core/tests/Drupal/Tests/Core/Render/RendererTestBase.php b/core/tests/Drupal/Tests/Core/Render/RendererTestBase.php index 1321379a4f..45684f4632 100644 --- a/core/tests/Drupal/Tests/Core/Render/RendererTestBase.php +++ b/core/tests/Drupal/Tests/Core/Render/RendererTestBase.php @@ -115,7 +115,7 @@ abstract class RendererTestBase extends UnitTestCase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->controllerResolver = $this->createMock('Drupal\Core\Controller\ControllerResolverInterface'); diff --git a/core/tests/Drupal/Tests/Core/Routing/LazyRouteCollectionTest.php b/core/tests/Drupal/Tests/Core/Routing/LazyRouteCollectionTest.php index e143664067..41844022c5 100644 --- a/core/tests/Drupal/Tests/Core/Routing/LazyRouteCollectionTest.php +++ b/core/tests/Drupal/Tests/Core/Routing/LazyRouteCollectionTest.php @@ -32,7 +32,7 @@ class LazyRouteCollectionTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->routeProvider = $this->createMock(RouteProviderInterface::class); $this->testRoutes = new \ArrayIterator([ diff --git a/core/tests/Drupal/Tests/Core/Template/TwigExtensionTest.php b/core/tests/Drupal/Tests/Core/Template/TwigExtensionTest.php index 38836fccfe..956ccec64a 100644 --- a/core/tests/Drupal/Tests/Core/Template/TwigExtensionTest.php +++ b/core/tests/Drupal/Tests/Core/Template/TwigExtensionTest.php @@ -71,7 +71,7 @@ class TwigExtensionTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->renderer = $this->createMock('\Drupal\Core\Render\RendererInterface'); diff --git a/core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php b/core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php index befd41cfee..1b6abf836f 100644 --- a/core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php +++ b/core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php @@ -40,7 +40,7 @@ class AjaxBasePageNegotiatorTest extends UnitTestCase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); $this->tokenGenerator = $this->prophesize(CsrfTokenGenerator::class); diff --git a/core/tests/Drupal/Tests/Listeners/DrupalListener.php b/core/tests/Drupal/Tests/Listeners/DrupalListener.php index 0b288bce96..758124cf8b 100644 --- a/core/tests/Drupal/Tests/Listeners/DrupalListener.php +++ b/core/tests/Drupal/Tests/Listeners/DrupalListener.php @@ -28,21 +28,6 @@ class DrupalListener implements TestListener { use DrupalComponentTestListenerTrait; use DrupalStandardsListenerTrait; - /** - * A list of methods to be checked for void return typehint. - * - * @var string[] - */ - protected $methodsWithVoidReturn = [ - 'setUpBeforeClass', - 'setUp', - 'assertPreConditions', - 'assertPostConditions', - 'tearDown', - 'tearDownAfterClass', - 'onNotSuccessfulTest', - ]; - /** * The wrapped Symfony test listener. * @@ -88,21 +73,8 @@ public function startTest(Test $test): void { // that handles expected deprecations. $this->registerErrorHandler(); $this->symfonyListener->startTest($test); - // Check for missing void return typehints in concrete test classes' - // methods. If the method is inherited from a base test class, do - // nothing. - $class = new \ReflectionClass($test); - foreach ($this->methodsWithVoidReturn as $method) { - if ($class->hasMethod($method)) { - $reflected_method = $class->getMethod($method); - if ($reflected_method->getDeclaringClass()->getName() === get_class($test)) { - if (!$reflected_method->hasReturnType() || $reflected_method->getReturnType()->getName() !== 'void') { - @trigger_error("Declaring ::$method without a void return typehint in " . get_class($test) . " is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724", E_USER_DEPRECATED); - } - } - } - } // Check for incorrect visibility of the $modules property. + $class = new \ReflectionClass($test); if ($class->hasProperty('modules') && !$class->getProperty('modules')->isProtected()) { @trigger_error('The ' . get_class($test) . '::$modules property must be declared protected. See https://www.drupal.org/node/2909426', E_USER_DEPRECATED); } diff --git a/core/tests/Drupal/Tests/UnitTestCase.php b/core/tests/Drupal/Tests/UnitTestCase.php index e6b0da2fe3..bb2062e206 100644 --- a/core/tests/Drupal/Tests/UnitTestCase.php +++ b/core/tests/Drupal/Tests/UnitTestCase.php @@ -46,7 +46,7 @@ abstract class UnitTestCase extends TestCase { /** * {@inheritdoc} */ - public static function setUpBeforeClass() { + public static function setUpBeforeClass(): void { parent::setUpBeforeClass(); VarDumper::setHandler(TestVarDumper::class . '::cliHandler'); } @@ -54,7 +54,7 @@ public static function setUpBeforeClass() { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); // Ensure that an instantiated container in the global state of \Drupal from // a previous test does not leak into this test. diff --git a/core/themes/classy/tests/src/Kernel/ClassyTest.php b/core/themes/classy/tests/src/Kernel/ClassyTest.php index 4bcfd20401..689d0d0cd0 100644 --- a/core/themes/classy/tests/src/Kernel/ClassyTest.php +++ b/core/themes/classy/tests/src/Kernel/ClassyTest.php @@ -20,7 +20,7 @@ class ClassyTest extends KernelTestBase { /** * {@inheritdoc} */ - public function setUp(): void { + protected function setUp(): void { parent::setUp(); // Use the classy theme.