diff -u b/core/modules/media/src/Entity/Media.php b/core/modules/media/src/Entity/Media.php --- b/core/modules/media/src/Entity/Media.php +++ b/core/modules/media/src/Entity/Media.php @@ -417,9 +417,12 @@ if (!$translation->hasField($entity_field_name)) { continue; } - // Populate the field value in one of these scenarios: 1) The caller of - // this function asked for it explicitly, 2) The entity field is empty, - // or 3) The media source field has changed. + /** + * Populate the field value in one of these scenarios: + * - The caller of this function asked for it explicitly. + * - The entity field is empty. + * - The media source field has changed. + */ if ($overwrite_existing || $translation->get($entity_field_name)->isEmpty() || $translation->hasSourceFieldChanged()) { $translation->set($entity_field_name, $media_source->getMetadata($translation, $metadata_attribute_name)); } diff -u b/core/modules/media/tests/src/Functional/MediaUpdateMetadataControllerTest.php b/core/modules/media/tests/src/Functional/MediaUpdateMetadataControllerTest.php --- b/core/modules/media/tests/src/Functional/MediaUpdateMetadataControllerTest.php +++ b/core/modules/media/tests/src/Functional/MediaUpdateMetadataControllerTest.php @@ -2,6 +2,7 @@ namespace Drupal\Tests\media\Functional; +use Drupal\file\Entity\File as FileEntity use Drupal\media\Entity\Media; use Drupal\media\Plugin\media\Source\File; @@ -27,7 +28,7 @@ $source_plugin = $media_type->getSource(); // Initially the "name" metadata is the filename. - $file = \Drupal\file\Entity\File::create([ + $file = FileEntity::create([ 'uri' => 'public://foo.txt', 'uid' => 1, ]);