diff --git a/accessibility_scanner.module b/accessibility_scanner.module index ee3bddf..3139018 100644 --- a/accessibility_scanner.module +++ b/accessibility_scanner.module @@ -25,12 +25,12 @@ function accessibility_scanner_theme($existing, $type, $theme, $path) { */ function accessibility_scanner_views_pre_view($view, $display_id, array &$args) { if ($view->id() == 'web_page_archive_individual' && $display_id == 'individual_run_page' && isset($args[0]) && is_numeric($args[0])) { - $item = array( + $item = [ 'id' => 'achecker_result', 'table' => 'views', 'field' => 'achecker_result', 'plugin_id' => 'achecker_result', - ); + ]; $view->setHandler($display_id, 'header', 'achecker_result', $item); } diff --git a/js/gchart.js b/js/gchart.js index 0532e00..2dd883d 100644 --- a/js/gchart.js +++ b/js/gchart.js @@ -24,7 +24,7 @@ } /** - * Draws the problem table. + * Draws the pass/fail table. */ Drupal.accessibilityScanner.drawPassFailChart = function () { var data = new google.visualization.DataTable(); diff --git a/src/EventSubscriber/WebPageArchiveEventSubscriber.php b/src/EventSubscriber/WebPageArchiveEventSubscriber.php index 3d8b78c..0922358 100644 --- a/src/EventSubscriber/WebPageArchiveEventSubscriber.php +++ b/src/EventSubscriber/WebPageArchiveEventSubscriber.php @@ -83,8 +83,11 @@ class WebPageArchiveEventSubscriber implements EventSubscriberInterface { $captured = $event->runEntity->getCapturedArray(); foreach ($captured as $captured_item) { $value = $captured_item->getValue(); - $capture_item_result = !empty($value['value']) ? unserialize($value['value']) : ''; - if ($capture_item_result['capture_response']->getId() != 'wpa_achecker_capture_response') { + if (empty($value['value'])) { + continue; + } + $capture_item_result = unserialize($value['value']); + if (!isset($capture_item_result['capture_response']) || $capture_item_result['capture_response']->getId() != 'wpa_achecker_capture_response') { continue; } $summary = $capture_item_result['capture_response']->retrieveFileContents()->summary; @@ -107,8 +110,6 @@ class WebPageArchiveEventSubscriber implements EventSubscriberInterface { } $this->acheckerStorage->addResult($result); - - \Drupal::logger('accessibility_scanner')->notice(json_encode($result)); } } diff --git a/templates/wpa-achecker-history.html.twig b/templates/wpa-achecker-history.html.twig index 22b5ea5..1db6dfd 100644 --- a/templates/wpa-achecker-history.html.twig +++ b/templates/wpa-achecker-history.html.twig @@ -19,8 +19,8 @@

This chart shows pass/fail trends over time.

{% endtrans %}