here.
- $id = $element['#views_ui_ajax_data']['wrapper'];
+ $id = substr($element['#views_ui_ajax_data']['wrapper_selector'], 1);
$refresh_element += [
'#prefix' => '',
'#suffix' => '',
diff --git a/core/modules/views_ui/js/ajax.es6.js b/core/modules/views_ui/js/ajax.es6.js
index 90856f212a..75482d504f 100644
--- a/core/modules/views_ui/js/ajax.es6.js
+++ b/core/modules/views_ui/js/ajax.es6.js
@@ -245,7 +245,7 @@
return true;
}
- elementSettings.wrapper = 'views-preview-wrapper';
+ elementSettings.wrapper_selector = '.views-preview-wrapper';
elementSettings.method = 'replaceWith';
elementSettings.base = $(this).attr('id');
elementSettings.element = this;
@@ -273,7 +273,7 @@
return true;
}
- elementSettings.wrapper = 'views-preview-wrapper';
+ elementSettings.wrapper_selector = '.views-preview-wrapper';
elementSettings.method = 'replaceWith';
elementSettings.event = 'click';
elementSettings.base = $(this).attr('id');
diff --git a/core/modules/views_ui/js/ajax.js b/core/modules/views_ui/js/ajax.js
index b7b9dcf53b..0619537e92 100644
--- a/core/modules/views_ui/js/ajax.js
+++ b/core/modules/views_ui/js/ajax.js
@@ -113,7 +113,7 @@
return true;
}
- elementSettings.wrapper = 'views-preview-wrapper';
+ elementSettings.wrapper_selector = '.views-preview-wrapper';
elementSettings.method = 'replaceWith';
elementSettings.base = $(this).attr('id');
elementSettings.element = this;
@@ -132,7 +132,7 @@
return true;
}
- elementSettings.wrapper = 'views-preview-wrapper';
+ elementSettings.wrapper_selector = '.views-preview-wrapper';
elementSettings.method = 'replaceWith';
elementSettings.event = 'click';
elementSettings.base = $(this).attr('id');
diff --git a/core/modules/views_ui/src/ViewPreviewForm.php b/core/modules/views_ui/src/ViewPreviewForm.php
index 1e5a2a6632..7926363a66 100644
--- a/core/modules/views_ui/src/ViewPreviewForm.php
+++ b/core/modules/views_ui/src/ViewPreviewForm.php
@@ -18,7 +18,7 @@ class ViewPreviewForm extends ViewFormBase {
public function form(array $form, FormStateInterface $form_state) {
$view = $this->entity;
- $form['#prefix'] = '
';
+ $form['#prefix'] = '
';
$form['#suffix'] = '
';
$form['#id'] = 'views-ui-preview-form';
@@ -87,7 +87,7 @@ protected function actions(array $form, FormStateInterface $form_state) {
'#id' => 'preview-submit',
'#ajax' => [
'url' => Url::fromRoute('entity.view.preview_form', ['view' => $view->id(), 'display_id' => $this->displayID]),
- 'wrapper' => 'views-preview-wrapper',
+ 'wrapper_selector' => '.views-preview-wrapper',
'event' => 'click',
'progress' => ['type' => 'fullscreen'],
'method' => 'replaceWith',
diff --git a/core/tests/Drupal/Tests/Core/Render/Element/RenderElementTest.php b/core/tests/Drupal/Tests/Core/Render/Element/RenderElementTest.php
index 3b52f9a4a1..86046bee0a 100644
--- a/core/tests/Drupal/Tests/Core/Render/Element/RenderElementTest.php
+++ b/core/tests/Drupal/Tests/Core/Render/Element/RenderElementTest.php
@@ -44,33 +44,72 @@ protected function setUp() {
/**
* @covers ::preRenderAjaxForm
+ * @dataProvider providerTestPreRenderAjaxForm
+ *
+ * @group legacy
*/
- public function testPreRenderAjaxForm() {
+ public function testPreRenderAjaxForm($element, $expected, $url) {
$request = Request::create('/test');
$request->query->set('foo', 'bar');
$this->requestStack->push($request);
$prophecy = $this->prophesize('Drupal\Core\Routing\UrlGeneratorInterface');
- $url = '/test?foo=bar&ajax_form=1';
$prophecy->generateFromRoute('
', [], ['query' => ['foo' => 'bar', FormBuilderInterface::AJAX_FORM_REQUEST => TRUE]], TRUE)
->willReturn((new GeneratedUrl())->setCacheContexts(['route'])->setGeneratedUrl($url));
$url_generator = $prophecy->reveal();
$this->container->set('url_generator', $url_generator);
- $element = [
- '#type' => 'select',
- '#id' => 'test',
- '#ajax' => [
- 'wrapper' => 'foo',
+
+ $result = RenderElement::preRenderAjaxForm($element);
+
+ $this->assertTrue($result['#ajax_processed']);
+ $this->assertSame($expected, $result['#attached']['drupalSettings']['ajax']['test']);
+ }
+
+ /**
+ * Provides test data for testPreRenderAjaxForm().
+ */
+ public function providerTestPreRenderAjaxForm() {
+ $data = [];
+ $data['wrapper_selector'] = [
+ [
+ '#type' => 'select',
+ '#id' => 'test',
+ '#ajax' => [
+ 'wrapper_selector' => '#foo',
+ 'callback' => 'test-callback',
+ ],
+ ],
+ [
+ 'wrapper_selector' => '#foo',
'callback' => 'test-callback',
+ 'event' => 'change',
+ 'url' => '/test?foo=bar&ajax_form=1',
+ 'dialogType' => 'ajax',
],
+ '/test?foo=bar&ajax_form=1',
];
-
- $element = RenderElement::preRenderAjaxForm($element);
-
- $this->assertTrue($element['#ajax_processed']);
- $this->assertEquals($url, $element['#attached']['drupalSettings']['ajax']['test']['url']);
+ // @todo Remove support for 'wrapper' and solely use 'wrapper_selector'.
+ $data['wrapper'] = [
+ [
+ '#type' => 'select',
+ '#id' => 'test',
+ '#ajax' => [
+ 'wrapper' => 'foo',
+ 'callback' => 'test-callback',
+ ],
+ ],
+ [
+ 'callback' => 'test-callback',
+ 'event' => 'change',
+ 'wrapper_selector' => '#foo',
+ 'url' => '/test?foo=bar&ajax_form=1',
+ 'dialogType' => 'ajax',
+ ],
+ '/test?foo=bar&ajax_form=1',
+ ];
+ return $data;
}
/**
@@ -93,7 +132,7 @@ public function testPreRenderAjaxFormWithQueryOptions() {
'#type' => 'select',
'#id' => 'test',
'#ajax' => [
- 'wrapper' => 'foo',
+ 'wrapper_selector' => '#foo',
'callback' => 'test-callback',
'options' => [
'query' => [