Fine thanks.
',
+ 'body[0][format]' => 'filtered_html',
+ 'op' => t('Save'),
+ ];
+ // Assume there is another field on this page, which doesn't use a custom
+ // render pipeline, but the default one, and it uses the "full" view mode.
+ $post += ['other_view_modes[]' => 'full'];
+
+ // Submit field form and check response. Should render with the custom
+ // render pipeline.
+ $response = $client->post($custom_render_url, [
+ 'body' => http_build_query($post),
+ 'query' => [MainContentViewSubscriber::WRAPPER_FORMAT => 'drupal_ajax'],
+ 'cookies' => $this->getSessionCookies(),
+ 'headers' => [
+ 'Accept' => 'application/json',
+ 'Content-Type' => 'application/x-www-form-urlencoded',
+ ],
+ 'http_errors' => FALSE,
+ ]);
+ $ajax_commands = Json::decode($response->getBody());
+ $this->assertIdentical(1, count($ajax_commands), 'The field form HTTP request results in one AJAX command.');
+ $this->assertIdentical('quickeditFieldFormSaved', $ajax_commands[0]['command'], 'The first AJAX command is a quickeditFieldFormSaved command.');
+ $this->assertTrue(strpos($ajax_commands[0]['data'], 'Fine thanks.'), 'Form value saved and printed back.');
+ $this->assertTrue(strpos($ajax_commands[0]['data'], '') !== FALSE, 'Custom render pipeline used to render the value.');
+ $this->assertIdentical(array_keys($ajax_commands[0]['other_view_modes']), ['full'], 'Field was also rendered in the "full" view mode.');
+ $this->assertTrue(strpos($ajax_commands[0]['other_view_modes']['full'], 'Fine thanks.'), '"full" version of field contains the form value.');
+ }
+
+}
diff --git a/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditAutocompleteTermTest.php b/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditAutocompleteTermTest.php
new file mode 100644
index 0000000000..71b0f3ebec
--- /dev/null
+++ b/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditAutocompleteTermTest.php
@@ -0,0 +1,206 @@
+drupalCreateContentType([
+ 'type' => 'article',
+ ]);
+ // Create the vocabulary for the tag field.
+ $this->vocabulary = Vocabulary::create([
+ 'name' => 'quickedit testing tags',
+ 'vid' => 'quickedit_testing_tags',
+ ]);
+ $this->vocabulary->save();
+ $this->fieldName = 'field_' . $this->vocabulary->id();
+
+ $handler_settings = [
+ 'target_bundles' => [
+ $this->vocabulary->id() => $this->vocabulary->id(),
+ ],
+ 'auto_create' => TRUE,
+ ];
+ $this->createEntityReferenceField('node', 'article', $this->fieldName, 'Tags', 'taxonomy_term', 'default', $handler_settings, FieldStorageDefinitionInterface::CARDINALITY_UNLIMITED);
+
+ entity_get_form_display('node', 'article', 'default')
+ ->setComponent($this->fieldName, [
+ 'type' => 'entity_reference_autocomplete_tags',
+ 'weight' => -4,
+ ])
+ ->save();
+
+ entity_get_display('node', 'article', 'default')
+ ->setComponent($this->fieldName, [
+ 'type' => 'entity_reference_label',
+ 'weight' => 10,
+ ])
+ ->save();
+ entity_get_display('node', 'article', 'teaser')
+ ->setComponent($this->fieldName, [
+ 'type' => 'entity_reference_label',
+ 'weight' => 10,
+ ])
+ ->save();
+
+ $this->term1 = $this->createTerm();
+ $this->term2 = $this->createTerm();
+
+ $node = [];
+ $node['type'] = 'article';
+ $node[$this->fieldName][]['target_id'] = $this->term1->id();
+ $node[$this->fieldName][]['target_id'] = $this->term2->id();
+ $this->node = $this->drupalCreateNode($node);
+
+ $this->editorUser = $this->drupalCreateUser([
+ 'access content',
+ 'create article content',
+ 'edit any article content',
+ 'administer nodes',
+ 'access contextual links',
+ 'access in-place editing',
+ ]);
+ }
+
+ /**
+ * Tests Quick Edit autocomplete term behavior.
+ */
+ public function testAutocompleteQuickEdit() {
+ $page = $this->getSession()->getPage();
+ $assert = $this->assertSession();
+
+ $this->drupalLogin($this->editorUser);
+ $this->drupalGet('node/' . $this->node->id());
+
+ // Wait "Quick edit" button for node.
+ $assert->waitForElement('css', '[data-quickedit-entity-id="node/' . $this->node->id() . '"] .contextual .quickedit');
+ // Click by "Quick edit".
+ $this->clickContextualLink('[data-quickedit-entity-id="node/' . $this->node->id() . '"]', 'Quick edit');
+ // Switch to body field.
+ $page->find('css', '[data-quickedit-field-id="node/' . $this->node->id() . '/' . $this->fieldName . '/' . $this->node->language()->getId() . '/full"]')->click();
+
+ // Open quickeditor.
+ $quickedit_field_locator = '[name="field_quickedit_testing_tags[target_id]"]';
+ $tag_field = $assert->waitForElementVisible('css', $quickedit_field_locator);
+ $tag_field->focus();
+ $tags = $tag_field->getValue();
+
+ // Check existing terms.
+ $this->assertTrue(strpos($tags, $this->term1->label()) !== FALSE);
+ $this->assertTrue(strpos($tags, $this->term2->label()) !== FALSE);
+
+ // Add new term.
+ $new_tag = $this->randomMachineName();
+ $tags .= ', ' . $new_tag;
+ $assert->waitForElementVisible('css', $quickedit_field_locator)->setValue($tags);
+ $assert->waitOnAutocomplete();
+ // Wait and click by "Save" button after body field was changed.
+ $assert->waitForElementVisible('css', '.quickedit-toolgroup.ops [type="submit"][aria-hidden="false"]')->click();
+ $assert->waitOnAutocomplete();
+
+ // Reload the page and check new term.
+ $this->drupalGet('node/' . $this->node->id());
+ $assert->waitForLink($new_tag);
+ }
+
+ /**
+ * Returns a new term with random name and description in $this->vocabulary.
+ *
+ * @return \Drupal\Core\Entity\EntityInterface|\Drupal\taxonomy\Entity\Term
+ * The created taxonomy term.
+ *
+ * @throws \Drupal\Core\Entity\EntityStorageException
+ */
+ protected function createTerm() {
+ $filter_formats = filter_formats();
+ $format = array_pop($filter_formats);
+ $term = Term::create([
+ 'name' => $this->randomMachineName(),
+ 'description' => $this->randomMachineName(),
+ // Use the first available text format.
+ 'format' => $format->id(),
+ 'vid' => $this->vocabulary->id(),
+ 'langcode' => LanguageInterface::LANGCODE_NOT_SPECIFIED,
+ ]);
+ $term->save();
+ return $term;
+ }
+
+}
diff --git a/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php b/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php
new file mode 100644
index 0000000000..3ff8b475b3
--- /dev/null
+++ b/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php
@@ -0,0 +1,378 @@
+ 'filtered_html',
+ 'name' => 'Filtered HTML',
+ 'weight' => 0,
+ 'filters' => [],
+ ]);
+ $filtered_html_format->save();
+
+ // Create a node type.
+ $this->drupalCreateContentType([
+ 'type' => 'article',
+ 'name' => 'Article',
+ ]);
+
+ // Set the node type to initially not have revisions.
+ // Testing with revisions will be done later.
+ $node_type = NodeType::load('article');
+ $node_type->setNewRevision(FALSE);
+ $node_type->save();
+
+ // Create one node of the above node type using the above text format.
+ $this->testNode = $this->drupalCreateNode([
+ 'type' => 'article',
+ 'body' => [
+ 0 => [
+ 'value' => '
How are you?
',
+ 'format' => 'filtered_html',
+ ],
+ ],
+ 'revision_log' => $this->randomString(),
+ ]);
+
+ // Create 2 users, the only difference being the ability to use in-place
+ // editing
+ $basic_permissions = [
+ 'access content',
+ 'create article content',
+ 'edit any article content',
+ 'use text format filtered_html',
+ 'access contextual links',
+ ];
+ $this->authorUser = $this->drupalCreateUser($basic_permissions);
+ $this->editorUser = $this->drupalCreateUser(array_merge($basic_permissions, ['access in-place editing']));
+ }
+
+ /**
+ * Test the loading of Quick Edit with different permissions.
+ */
+ public function testUserPermissions() {
+ $assert = $this->assertSession();
+ $this->drupalLogin($this->authorUser);
+ $this->drupalGet('node/1');
+
+ // Library and in-place editors.
+ $this->assertNoRaw('core/modules/quickedit/js/quickedit.js', 'Quick Edit library not loaded.');
+ $this->assertNoRaw('core/modules/quickedit/js/editors/formEditor.js', "'form' in-place editor not loaded.");
+
+ // HTML annotation and title class does not exist for users without
+ // permission to in-place edit.
+ $this->assertNoRaw('data-quickedit-entity-id="node/1"');
+ $this->assertNoRaw('data-quickedit-field-id="node/1/body/en/full"');
+ $this->assertNoFieldByXPath('//h1[contains(@class, "js-quickedit-page-title")]');
+ $assert->linkNotExists('Quick edit');
+
+ // Tests the loading of Quick Edit when a user does have access to it.
+ // Also ensures lazy loading of in-place editors works.
+ $nid = $this->testNode->id();
+
+ $this->drupalLogin($this->editorUser);
+ $this->drupalGet('node/' . $nid);
+ $page = $this->getSession()->getPage();
+
+ // Wait "Quick edit" button for node.
+ $assert->waitForElement('css', '[data-quickedit-entity-id="node/' . $nid . '"] .contextual .quickedit');
+ // Click by "Quick edit".
+ $this->clickContextualLink('[data-quickedit-entity-id="node/' . $nid . '"]', 'Quick edit');
+ // Switch to body field.
+ $page->find('css', '[data-quickedit-field-id="node/' . $nid . '/body/en/full"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ // Wait and update body field.
+ $body_field_locator = '[name="body[0][value]"]';
+ $body_text = 'Fine thanks.';
+ $assert->waitForElementVisible('css', $body_field_locator)->setValue('
' . $body_text . '
');
+
+ // Wait and click by "Save" button after body field was changed.
+ $assert->waitForElementVisible('css', '.quickedit-toolgroup.ops [type="submit"][aria-hidden="false"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ // Ensure that the changes take effect.
+ $assert->responseMatches("|\s*$body_text\s*|");
+
+ // Reload the page and check for updated body.
+ $this->drupalGet('node/' . $nid);
+ $assert->pageTextContains($body_text);
+ }
+
+ /**
+ * Test quickedit does not appear for entities with pending revisions.
+ */
+ public function testWithPendingRevision() {
+ $this->drupalLogin($this->editorUser);
+
+ // Verify that the preview is loaded correctly.
+ $this->drupalPostForm('node/add/article', ['title[0][value]' => 'foo'], 'Preview');
+ // Verify that quickedit is not active on preview.
+ $this->assertNoRaw('data-quickedit-entity-id="node/' . $this->testNode->id() . '"');
+ $this->assertNoRaw('data-quickedit-field-id="node/' . $this->testNode->id() . '/title/' . $this->testNode->language()->getId() . '/full"');
+
+ $this->drupalGet('node/' . $this->testNode->id());
+ $this->assertRaw('data-quickedit-entity-id="node/' . $this->testNode->id() . '"');
+ $this->assertRaw('data-quickedit-field-id="node/' . $this->testNode->id() . '/title/' . $this->testNode->language()->getId() . '/full"');
+
+ $this->testNode->title = 'Updated node';
+ $this->testNode->setNewRevision(TRUE);
+ $this->testNode->isDefaultRevision(FALSE);
+ $this->testNode->save();
+
+ $this->drupalGet('node/' . $this->testNode->id());
+ $this->assertNoRaw('data-quickedit-entity-id="node/' . $this->testNode->id() . '"');
+ $this->assertNoRaw('data-quickedit-field-id="node/' . $this->testNode->id() . '/title/' . $this->testNode->language()->getId() . '/full"');
+ }
+
+ /**
+ * Tests the loading of Quick Edit for the title base field.
+ */
+ public function testTitleBaseField() {
+ $page = $this->getSession()->getPage();
+ $assert = $this->assertSession();
+ $nid = $this->testNode->id();
+
+ $this->drupalLogin($this->editorUser);
+ $this->drupalGet('node/' . $nid);
+
+ // Wait "Quick edit" button for node.
+ $assert->waitForElement('css', '[data-quickedit-entity-id="node/' . $nid . '"] .contextual .quickedit');
+ // Click by "Quick edit".
+ $this->clickContextualLink('[data-quickedit-entity-id="node/' . $nid . '"]', 'Quick edit');
+ // Switch to title field.
+ $page->find('css', '[data-quickedit-field-id="node/' . $nid . '/title/en/full"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ // Wait and update title field.
+ $field_locator = '.field--name-title';
+ $text_new = 'Obligatory question';
+ $assert->waitForElementVisible('css', $field_locator)->setValue($text_new);
+
+ // Wait and click by "Save" button after title field was changed.
+ $this->assertSession()->waitForElementVisible('css', '.quickedit-toolgroup.ops [type="submit"][aria-hidden="false"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ // Ensure that the changes take effect.
+ $assert->responseMatches("|\s*$text_new\s*|");
+
+ // Reload the page and check for updated title.
+ $this->drupalGet('node/' . $nid);
+ $assert->pageTextContains($text_new);
+ }
+
+ /**
+ * Tests that Quick Edit doesn't make fields rendered with display options
+ * editable.
+ */
+ public function testDisplayOptions() {
+ $node = Node::load('1');
+ $display_settings = [
+ 'label' => 'inline',
+ ];
+ $build = $node->body->view($display_settings);
+ $output = \Drupal::service('renderer')->renderRoot($build);
+ $this->assertFalse(strpos($output, 'data-quickedit-field-id'), 'data-quickedit-field-id attribute not added when rendering field using dynamic display options.');
+ }
+
+ /**
+ * Tests Quick Edit on a node that was concurrently edited on the full node
+ * form.
+ */
+ public function testConcurrentEdit() {
+ $nid = $this->testNode->id();
+ $this->drupalLogin($this->authorUser);
+
+ // Open the edit page in the default session.
+ $this->drupalGet('node/' . $nid . '/edit');
+
+ // Switch to a concurrent session and save a quick edit change.
+ // We need to do some bookkeeping to keep track of the logged in user.
+ $logged_in_user = $this->loggedInUser;
+ $this->loggedInUser = FALSE;
+ // Register a session to preform concurrent editing.
+ $driver = $this->getDefaultDriverInstance();
+ $session = new Session($driver);
+ $this->mink->registerSession('concurrent', $session);
+ $this->mink->setDefaultSessionName('concurrent');
+ $this->initFrontPage();
+ $this->drupalLogin($this->editorUser);
+ $this->drupalGet('node/' . $nid);
+
+ $assert = $this->assertSession();
+ $page = $this->getSession()->getPage();
+
+ // Wait "Quick edit" button for node.
+ $assert->waitForElement('css', '[data-quickedit-entity-id="node/' . $nid . '"] .contextual .quickedit');
+ // Click by "Quick edit".
+ $this->clickContextualLink('[data-quickedit-entity-id="node/' . $nid . '"]', 'Quick edit');
+ // Switch to body field.
+ $page->find('css', '[data-quickedit-field-id="node/' . $nid . '/body/en/full"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ // Wait and update body field.
+ $body_field_locator = '[name="body[0][value]"]';
+ $body_text = 'Fine thanks.';
+ $assert->waitForElementVisible('css', $body_field_locator)->setValue('
' . $body_text . '
');
+
+ // Wait and click by "Save" button after body field was changed.
+ $assert->waitForElementVisible('css', '.quickedit-toolgroup.ops [type="submit"][aria-hidden="false"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ // Ensure that the changes take effect.
+ $assert->responseMatches("|\s*$body_text\s*|");
+
+ // Switch back to the default session.
+ $this->mink->setDefaultSessionName('default');
+ $this->loggedInUser = $logged_in_user;
+ // Ensure different save timestamps for field editing.
+ sleep(2);
+ $this->drupalPostForm(NULL, ['body[0][value]' => '
Concurrent edit!
'], 'Save');
+
+ $this->getSession()->getPage()->hasContent('The content has either been modified by another user, or you have already submitted modifications. As a result, your changes cannot be saved.');
+ }
+
+ /**
+ * Tests that Quick Edit's data- attributes are present for content blocks.
+ */
+ public function testContentBlock() {
+ \Drupal::service('module_installer')->install(['block_content']);
+
+ // Create and place a content_block block.
+ $block = BlockContent::create([
+ 'info' => $this->randomMachineName(),
+ 'type' => 'basic',
+ 'langcode' => 'en',
+ ]);
+ $block->save();
+ $this->drupalPlaceBlock('block_content:' . $block->uuid());
+
+ // Check that the data- attribute is present.
+ $this->drupalLogin($this->editorUser);
+ $this->drupalGet('');
+ $this->assertRaw('data-quickedit-entity-id="block_content/1"');
+ }
+
+ /**
+ * Tests that Quick Edit can handle an image field.
+ */
+ public function testImageField() {
+ $page = $this->getSession()->getPage();
+ $assert = $this->assertSession();
+
+ // Add an image field to the content type.
+ FieldStorageConfig::create([
+ 'field_name' => 'field_image',
+ 'type' => 'image',
+ 'entity_type' => 'node',
+ ])->save();
+ FieldConfig::create([
+ 'field_name' => 'field_image',
+ 'field_type' => 'image',
+ 'label' => t('Image'),
+ 'entity_type' => 'node',
+ 'bundle' => 'article',
+ ])->save();
+ entity_get_form_display('node', 'article', 'default')
+ ->setComponent('field_image', [
+ 'type' => 'image_image',
+ ])
+ ->save();
+ $display = EntityViewDisplay::load('node.article.default');
+ $display->setComponent('field_image', [
+ 'type' => 'image',
+ ])->save();
+
+ // Add an image to the node.
+ $this->drupalLogin($this->editorUser);
+ $this->drupalGet('node/1/edit');
+ $image = $this->drupalGetTestFiles('image')[0];
+ $image_path = $this->container->get('file_system')->realpath($image->uri);
+ $page->attachFileToField('files[field_image_0]', $image_path);
+ $alt_field = $assert->waitForField('field_image[0][alt]');
+ $this->assertNotEmpty($alt_field);
+ $this->drupalPostForm(NULL, [
+ 'field_image[0][alt]' => 'Vivamus aliquet elit',
+ ], t('Save'));
+
+ // The image field form should load normally.
+ // Wait "Quick edit" button for node.
+ $assert->waitForElement('css', '[data-quickedit-entity-id="node/1"] .contextual .quickedit');
+ // Click by "Quick edit".
+ $this->clickContextualLink('[data-quickedit-entity-id="node/1"]', 'Quick edit');
+ // Switch to body field.
+ $assert->waitForElement('css', '[data-quickedit-field-id="node/1/field_image/en/full"]')->click();
+ $assert->assertWaitOnAjaxRequest();
+
+ $field_locator = '.field--name-field-image';
+ $assert->waitForElementVisible('css', $field_locator);
+ }
+
+}