Index: views.module =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/views/views.module,v retrieving revision 1.166.2.41 diff -u -r1.166.2.41 views.module --- views.module 8 Jun 2007 03:58:00 -0000 1.166.2.41 +++ views.module 15 Jun 2007 13:31:26 -0000 @@ -565,11 +565,13 @@ } $query = db_rewrite_sql($info['query'], 'node'); + $query = str_replace('[SUBQUERY]', $info['subquery'], $query); $items = array(); if ($query) { if ($view->use_pager) { $cquery = db_rewrite_sql($info['countquery'], 'node', 'nid', $info['rewrite_args']); + $cquery = str_replace('[SUBQUERY]', $info['subquery'], $cquery); $result = pager_query($query, $view->pager_limit, $view->use_pager - 1, $cquery, $info['args']); $view->total_rows = $GLOBALS['pager_total_items'][$view->use_pager - 1]; } Index: views_query.inc =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/views/views_query.inc,v retrieving revision 1.51.2.11 diff -u -r1.51.2.11 views_query.inc --- views_query.inc 12 Apr 2007 15:18:59 -0000 1.51.2.11 +++ views_query.inc 15 Jun 2007 13:31:26 -0000 @@ -63,9 +63,10 @@ $info['query'] = $query->query(); $info['countquery'] = $query->query(true); + $info['subquery'] = $query->subquery(); $info['summary'] = $summary; $info['level'] = $level; - $info['args'] = $query->where_args; + $info['args'] = array_merge($query->subquery_args, $query->where_args); return $info; @@ -289,11 +290,13 @@ $this->primary_table = $primary_table; $this->primary_field = $primary_field; $this->joins = array(); + $this->subquery = array(); $this->where = array(); $this->orderby = array(); $this->groupby = array(); $this->tables = array(); $this->where_args = array(); + $this->subquery_args = array(); $this->use_alias_prefix = $alias_prefix; // Joins care about order, so we put our tables in a queue to make sure // the order is correct. @@ -443,6 +446,24 @@ } /* + * Add a subquery as a table join to the query. + * + * @param $query + * The SQL of the subquery to add. + * @param $args + * The subquery's replacable arguments + * @param $joininfo + * specify how to join the table + * @param $alias + * the alias name associated with the subquery + */ + function add_subquery($query, $args, $joininfo, $alias) { + $this->subquery[$alias] = $query; + $this->joins[$alias][0] = $joininfo; + $this->subquery_args = array_merge($this->subquery_args, $args); + } + + /* * This function will add a table to the query. * * @param $table @@ -580,6 +601,9 @@ $this->no_distinct = TRUE; } + // Add a placeholder for sub-queries + $joins = count($this->subquery) ? '[SUBQUERY]' : ''; + // Add all the tables to the query via joins. We assume all LEFT joins. foreach ($this->tablequeue as $tinfo) { $table = $tinfo['table']; @@ -658,6 +682,26 @@ return $query; } + + /* + * Return the join clauses for all of the sub-queries. + * Do this here instead of in query() because db_rewrite_sql() improperly + * rewrites sub-queries. See http://drupal.org/node/151910 + */ + function subquery() { + // Add the subqueries to the query via joins. + foreach ($this->subquery as $alias => $query) { + $joininfo = $this->joins[$alias][0]; + + $left_table_alias = isset($joininfo['left']['alias']) ? $joininfo['left']['alias'] : $tinfo['alias_prefix']; + $left_table_alias .= $joininfo['left']['table']; + + $join_type = $joininfo['type'] == 'inner' ? 'INNER' : 'LEFT'; + $joins .= " $join_type JOIN (" . $query . ") $alias ON " . $left_table_alias .".". + $joininfo['left']['field'] . " = $alias." . $joininfo['right']['field']; + } + return $joins; + } } /*