diff -u b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NodeNewComments.php b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NodeNewComments.php --- b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NodeNewComments.php +++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NodeNewComments.php @@ -57,7 +57,7 @@ $this->field_alias = $this->table . '_' . $this->field; } - public function preRender(&$values) { + function pre_render(&$values) { global $user; if (!$user->uid || empty($values)) { return; @@ -91,7 +91,7 @@ $this->field_alias = $this->table . '_' . $this->field; } - function pre_render(&$values) { + public function preRender(&$values) { global $user; if (!$user->uid || empty($values)) { return; diff -u b/core/modules/user/lib/Drupal/user/Plugin/views/field/Permissions.php b/core/modules/user/lib/Drupal/user/Plugin/views/field/Permissions.php --- b/core/modules/user/lib/Drupal/user/Plugin/views/field/Permissions.php +++ b/core/modules/user/lib/Drupal/user/Plugin/views/field/Permissions.php @@ -35,7 +35,7 @@ $this->field_alias = $this->aliases['uid']; } - public function preRender(&$values) { + function pre_render(&$values) { $uids = array(); $this->items = array(); @@ -69,7 +69,7 @@ $this->field_alias = $this->aliases['uid']; } - function pre_render(&$values) { + public function preRender(&$values) { $uids = array(); $this->items = array(); diff -u b/core/modules/user/lib/Drupal/user/Plugin/views/field/Roles.php b/core/modules/user/lib/Drupal/user/Plugin/views/field/Roles.php --- b/core/modules/user/lib/Drupal/user/Plugin/views/field/Roles.php +++ b/core/modules/user/lib/Drupal/user/Plugin/views/field/Roles.php @@ -35,7 +35,7 @@ $this->field_alias = $this->aliases['uid']; } - public function preRender(&$values) { + function pre_render(&$values) { $uids = array(); $this->items = array(); @@ -69,7 +69,7 @@ $this->field_alias = $this->aliases['uid']; } - function pre_render(&$values) { + public function preRender(&$values) { $uids = array(); $this->items = array(); diff -u b/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php b/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php --- b/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php +++ b/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php @@ -49,7 +49,7 @@ $view = views_get_view('test_views_handler_field_role'); $this->executeView($view); $view->row_index = 0; - // The role field is populated during pre_render. + // The role field is populated during preRender. $view->field['rid']->preRender($view->result); $render = $view->field['rid']->advancedRender($view->result[0]); reverted: --- b/core/modules/views/lib/Drupal/views/Plugin/views/area/Title.php +++ a/core/modules/views/lib/Drupal/views/Plugin/views/area/Title.php @@ -45,7 +45,7 @@ } /** + * Overrides Drupal\views\Plugin\views\AreaPluginBase::preRender(). - * {@inheritdoc} */ public function preRender(array $results) { parent::preRender($results); only in patch2: unchanged: --- a/core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php +++ b/core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php @@ -274,7 +274,7 @@ public function buildOptionsForm(&$form, &$form_state) { // Some form elements belong in a fieldset for presentation, but can't // be moved into one because of the form_state['values'] hierarchy. Those // elements can add a #fieldset => 'fieldset_name' property, and they'll - // be moved to their fieldset during pre_render. + // be moved to their fieldset during preRender. $form['#pre_render'][] = 'views_ui_pre_render_add_fieldset_markup'; $form['admin_label'] = array( only in patch2: unchanged: --- a/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.php +++ b/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.php @@ -184,7 +184,7 @@ public function buildOptionsForm(&$form, &$form_state) { // Some form elements belong in a fieldset for presentation, but can't // be moved into one because of the form_state['values'] hierarchy. Those // elements can add a #fieldset => 'fieldset_name' property, and they'll - // be moved to their fieldset during pre_render. + // be moved to their fieldset during preRender. $form['#pre_render'][] = 'views_ui_pre_render_add_fieldset_markup'; } only in patch2: unchanged: --- a/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php +++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php @@ -493,8 +493,8 @@ public function showExposeButton(&$form, &$form_state) { public function buildExposeForm(&$form, &$form_state) { $form['#theme'] = 'views_ui_expose_filter_form'; // #flatten will move everything from $form['expose'][$key] to $form[$key] - // prior to rendering. That's why the pre_render for it needs to run first, - // so that when the next pre_render (the one for fieldsets) runs, it gets + // prior to rendering. That's why the preRender for it needs to run first, + // so that when the next preRender (the one for fieldsets) runs, it gets // the flattened data. array_unshift($form['#pre_render'], 'views_ui_pre_render_flatten_data'); $form['expose']['#flatten'] = TRUE; @@ -836,8 +836,8 @@ protected function buildExposedFiltersGroupForm(&$form, &$form_state) { $form['#theme'] = 'views_ui_build_group_filter_form'; // #flatten will move everything from $form['group_info'][$key] to $form[$key] - // prior to rendering. That's why the pre_render for it needs to run first, - // so that when the next pre_render (the one for fieldsets) runs, it gets + // prior to rendering. That's why the preRender for it needs to run first, + // so that when the next preRender (the one for fieldsets) runs, it gets // the flattened data. array_unshift($form['#pre_render'], 'views_ui_pre_render_flatten_data'); $form['group_info']['#flatten'] = TRUE; only in patch2: unchanged: --- a/core/modules/views/lib/Drupal/views/Plugin/views/sort/SortPluginBase.php +++ b/core/modules/views/lib/Drupal/views/Plugin/views/sort/SortPluginBase.php @@ -188,8 +188,8 @@ protected function sortOptions() { public function buildExposeForm(&$form, &$form_state) { // #flatten will move everything from $form['expose'][$key] to $form[$key] - // prior to rendering. That's why the pre_render for it needs to run first, - // so that when the next pre_render (the one for fieldsets) runs, it gets + // prior to rendering. That's why the preRender for it needs to run first, + // so that when the next preRender (the one for fieldsets) runs, it gets // the flattened data. array_unshift($form['#pre_render'], 'views_ui_pre_render_flatten_data'); $form['expose']['#flatten'] = TRUE; only in patch2: unchanged: --- a/core/modules/views/views.api.php +++ b/core/modules/views/views.api.php @@ -431,7 +431,7 @@ function hook_views_pre_execute(ViewExecutable &$view) { /** * Act on the view immediately after the query has been executed. * - * At this point the query has been executed, but the pre_render() phase has + * At this point the query has been executed, but the preRender() phase has * not yet happened for handlers. * * Output can be added to the view by setting $view->attachment_before @@ -455,7 +455,7 @@ function hook_views_post_execute(ViewExecutable &$view) { /** * Act on the view immediately before rendering it. * - * At this point the query has been executed, and the pre_render() phase has + * At this point the query has been executed, and the preRender() phase has * already happened for handlers, so all data should be available. This hook * can be utilized by themes. * only in patch2: unchanged: --- a/core/modules/views_ui/admin.inc +++ b/core/modules/views_ui/admin.inc @@ -258,7 +258,7 @@ function views_ui_taxonomy_autocomplete_validate($element, &$form_state) { * * Many views forms use #tree = TRUE to keep their values in a hierarchy for * easier storage. Moving the form elements into fieldsets during form building - * would break up that hierarchy. Therefore, we wait until the pre_render stage, + * would break up that hierarchy. Therefore, we wait until the preRender stage, * where any changes we make affect presentation only and aren't reflected in * $form_state['values']. */