diff --git a/core/modules/block/custom_block/lib/Drupal/custom_block/Tests/CustomBlockFieldTest.php b/core/modules/block/custom_block/lib/Drupal/custom_block/Tests/CustomBlockFieldTest.php index ab2f78c..0185523 100644 --- a/core/modules/block/custom_block/lib/Drupal/custom_block/Tests/CustomBlockFieldTest.php +++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Tests/CustomBlockFieldTest.php @@ -71,7 +71,7 @@ public function testBlockFields() { )); $this->field->save(); $this->instance = entity_create('field_instance', array( - 'field_name' => $this->field['field_name'], + 'field_name' => $this->field->id(), 'entity_type' => 'custom_block', 'bundle' => 'link', 'settings' => array( diff --git a/core/modules/contact/lib/Drupal/contact/Tests/Views/ContactFieldsTest.php b/core/modules/contact/lib/Drupal/contact/Tests/Views/ContactFieldsTest.php index 2263ea0..e7c7aa1 100644 --- a/core/modules/contact/lib/Drupal/contact/Tests/Views/ContactFieldsTest.php +++ b/core/modules/contact/lib/Drupal/contact/Tests/Views/ContactFieldsTest.php @@ -46,7 +46,7 @@ protected function setUp() { $this->field->save(); entity_create('field_instance', array( - 'field_name' => $this->field['field_name'], + 'field_name' => $this->field->id(), 'entity_type' => 'contact_message', 'bundle' => 'contact_message', ))->save(); @@ -58,7 +58,6 @@ protected function setUp() { * Tests the views data generation. */ public function testViewsData() { - $field_name = $this->field['field_name']; $table_name = _field_sql_storage_tablename($this->field); $data = $this->container->get('views.views_data')->get($table_name); @@ -66,7 +65,7 @@ public function testViewsData() { $expected = array('', '_value', '_format'); $this->assertEqual(count($data), count($expected), 'The expected amount of array keys were found.'); foreach ($expected as $suffix) { - $this->assertTrue(isset($data[$field_name . $suffix])); + $this->assertTrue(isset($data[$this->field->id() . $suffix])); } $this->assertTrue(empty($data['table']['join']), 'The field is not joined to the non existent contact message base table.'); } diff --git a/core/modules/datetime/lib/Drupal/datetime/Tests/DatetimeFieldTest.php b/core/modules/datetime/lib/Drupal/datetime/Tests/DatetimeFieldTest.php index a01e120..7c56c3e 100644 --- a/core/modules/datetime/lib/Drupal/datetime/Tests/DatetimeFieldTest.php +++ b/core/modules/datetime/lib/Drupal/datetime/Tests/DatetimeFieldTest.php @@ -56,7 +56,7 @@ function setUp() { )); $this->field->save(); $this->instance = entity_create('field_instance', array( - 'field_name' => $this->field['field_name'], + 'field_name' => $this->field->id(), 'entity_type' => 'entity_test', 'bundle' => 'entity_test', 'settings' => array( @@ -65,8 +65,8 @@ function setUp() { )); $this->instance->save(); - entity_get_form_display($this->instance['entity_type'], $this->instance['bundle'], 'default') - ->setComponent($this->field['field_name'], array( + entity_get_form_display($this->instance->entity_type, $this->instance->bundle, 'default') + ->setComponent($this->field->id(), array( 'type' => 'datetime_default', )) ->save(); @@ -76,8 +76,8 @@ function setUp() { 'label' => 'hidden', 'settings' => array('format_type' => 'medium'), ); - entity_get_display($this->instance['entity_type'], $this->instance['bundle'], 'full') - ->setComponent($this->field['field_name'], $this->display_options) + entity_get_display($this->instance->entity_type, $this->instance->bundle, 'full') + ->setComponent($this->field->id(), $this->display_options) ->save(); } @@ -85,12 +85,12 @@ function setUp() { * Tests date field functionality. */ function testDateField() { - + $field_name = $this->field->id(); // Display creation form. $this->drupalGet('entity_test/add'); $langcode = Language::LANGCODE_NOT_SPECIFIED; - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][date]", '', 'Date element found.'); - $this->assertNoFieldByName("{$this->field['field_name']}[$langcode][0][value][time]", '', 'Time element not found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][date]", '', 'Date element found.'); + $this->assertNoFieldByName("$field_name[$langcode][0][value][time]", '', 'Time element not found.'); // Submit a valid date and ensure it is accepted. $value = '2012-12-31 00:00:00'; @@ -102,7 +102,7 @@ function testDateField() { $edit = array( 'user_id' => 1, 'name' => $this->randomName(), - "{$this->field['field_name']}[$langcode][0][value][date]" => $date->format($date_format), + "$field_name[$langcode][0][value][date]" => $date->format($date_format), ); $this->drupalPost(NULL, $edit, t('Save')); preg_match('|entity_test/manage/(\d+)/edit|', $this->url, $match); @@ -122,8 +122,8 @@ function testDateField() { foreach ($values as $new_value) { // Update the entity display settings. $this->display_options['settings'] = array($setting => $new_value); - $display = entity_get_display($this->instance['entity_type'], $this->instance['bundle'], 'full') - ->setComponent($this->instance['field_name'], $this->display_options) + entity_get_display($this->instance->entity_type, $this->instance->bundle, 'full') + ->setComponent($field_name, $this->display_options) ->save(); $this->renderTestEntity($id); @@ -140,8 +140,8 @@ function testDateField() { // Verify that the plain formatter works. $this->display_options['type'] = 'datetime_plain'; - $display = entity_get_display($this->instance['entity_type'], $this->instance['bundle'], 'full') - ->setComponent($this->instance['field_name'], $this->display_options) + entity_get_display($this->instance->entity_type, $this->instance->bundle, 'full') + ->setComponent($field_name, $this->display_options) ->save(); $expected = $date->format(DATETIME_DATE_STORAGE_FORMAT); $this->renderTestEntity($id); @@ -152,7 +152,7 @@ function testDateField() { * Tests date and time field. */ function testDatetimeField() { - + $field_name = $this->field->id(); // Change the field to a datetime field. $this->field['settings']['datetime_type'] = 'datetime'; $this->field->save(); @@ -160,8 +160,8 @@ function testDatetimeField() { // Display creation form. $this->drupalGet('entity_test/add'); $langcode = Language::LANGCODE_NOT_SPECIFIED; - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][date]", '', 'Date element found.'); - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][time]", '', 'Time element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][date]", '', 'Date element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][time]", '', 'Time element found.'); // Submit a valid date and ensure it is accepted. $value = '2012-12-31 00:00:00'; @@ -173,8 +173,8 @@ function testDatetimeField() { $edit = array( 'user_id' => 1, 'name' => $this->randomName(), - "{$this->field['field_name']}[$langcode][0][value][date]" => $date->format($date_format), - "{$this->field['field_name']}[$langcode][0][value][time]" => $date->format($time_format), + "$field_name[$langcode][0][value][date]" => $date->format($date_format), + "$field_name[$langcode][0][value][time]" => $date->format($time_format), ); $this->drupalPost(NULL, $edit, t('Save')); preg_match('|entity_test/manage/(\d+)/edit|', $this->url, $match); @@ -191,8 +191,8 @@ function testDatetimeField() { foreach ($values as $new_value) { // Update the entity display settings. $this->display_options['settings'] = array($setting => $new_value); - $display = entity_get_display($this->instance['entity_type'], $this->instance['bundle'], 'full') - ->setComponent($this->instance['field_name'], $this->display_options) + entity_get_display($this->instance->entity_type, $this->instance->bundle, 'full') + ->setComponent($field_name, $this->display_options) ->save(); $this->renderTestEntity($id); @@ -209,8 +209,8 @@ function testDatetimeField() { // Verify that the plain formatter works. $this->display_options['type'] = 'datetime_plain'; - $display = entity_get_display($this->instance['entity_type'], $this->instance['bundle'], 'full') - ->setComponent($this->instance['field_name'], $this->display_options) + entity_get_display($this->instance->entity_type, $this->instance->bundle, 'full') + ->setComponent($field_name, $this->display_options) ->save(); $expected = $date->format(DATETIME_DATETIME_STORAGE_FORMAT); $this->renderTestEntity($id); @@ -221,14 +221,14 @@ function testDatetimeField() { * Tests Date List Widget functionality. */ function testDatelistWidget() { - + $field_name = $this->field->id(); // Change the field to a datetime field. - $this->field['settings']['datetime_type'] = 'datetime'; + $this->field->settings['datetime_type'] = 'datetime'; $this->field->save(); // Change the widget to a datelist widget. - entity_get_form_display($this->instance['entity_type'], $this->instance['bundle'], 'default') - ->setComponent($this->instance['field_name'], array( + entity_get_form_display($this->instance->entity_type, $this->instance->bundle, 'default') + ->setComponent($field_name, array( 'type' => 'datetime_datelist', 'settings' => array( 'increment' => 1, @@ -241,7 +241,6 @@ function testDatelistWidget() { // Display creation form. $this->drupalGet('entity_test/add'); - $field_name = $this->field['field_name']; $langcode = Language::LANGCODE_NOT_SPECIFIED; $this->assertFieldByXPath("//*[@id=\"edit-$field_name-$langcode-0-value-year\"]", NULL, 'Year element found.'); @@ -260,7 +259,6 @@ function testDatelistWidget() { // Submit a valid date and ensure it is accepted. $date_value = array('year' => 2012, 'month' => 12, 'day' => 31, 'hour' => 5, 'minute' => 15); - $date = new DrupalDateTime($date_value); $edit = array( 'user_id' => 1, @@ -269,7 +267,7 @@ function testDatelistWidget() { // Add the ampm indicator since we are testing 12 hour time. $date_value['ampm'] = 'am'; foreach ($date_value as $part => $value) { - $edit["{$this->field['field_name']}[$langcode][0][value][$part]"] = $value; + $edit["$field_name[$langcode][0][value][$part]"] = $value; } $this->drupalPost(NULL, $edit, t('Save')); @@ -291,12 +289,13 @@ function testDatelistWidget() { function testDefaultValue() { // Change the field to a datetime field. - $this->field['settings']['datetime_type'] = 'datetime'; + $this->field->settings['datetime_type'] = 'datetime'; $this->field->save(); + $field_name = $this->field->id(); // Set the default value to 'now'. - $this->instance['settings']['default_value'] = 'now'; - $this->instance['default_value_function'] = 'datetime_default_value'; + $this->instance->settings['default_value'] = 'now'; + $this->instance->default_value_function = 'datetime_default_value'; $this->instance->save(); // Display creation form. @@ -309,12 +308,12 @@ function testDefaultValue() { // it may be a few seconds between the time the comparison date is created // and the form date, so we just test the date and that the time is not // empty. - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][date]", $date->format($date_format), 'Date element found.'); - $this->assertNoFieldByName("{$this->field['field_name']}[$langcode][0][value][time]", '', 'Time element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][date]", $date->format($date_format), 'Date element found.'); + $this->assertNoFieldByName("$field_name[$langcode][0][value][time]", '', 'Time element found.'); // Set the default value to 'blank'. - $this->instance['settings']['default_value'] = 'blank'; - $this->instance['default_value_function'] = 'datetime_default_value'; + $this->instance->settings['default_value'] = 'blank'; + $this->instance->default_value_function = 'datetime_default_value'; $this->instance->save(); // Display creation form. @@ -322,8 +321,8 @@ function testDefaultValue() { $this->drupalGet('entity_test/add'); // See that no date is set. - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][date]", '', 'Date element found.'); - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][time]", '', 'Time element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][date]", '', 'Date element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][time]", '', 'Time element found.'); } /** @@ -332,44 +331,45 @@ function testDefaultValue() { function testInvalidField() { // Change the field to a datetime field. - $this->field['settings']['datetime_type'] = 'datetime'; + $this->field->settings['datetime_type'] = 'datetime'; $this->field->save(); + $field_name = $this->field->id(); // Display creation form. $this->drupalGet('entity_test/add'); $langcode = Language::LANGCODE_NOT_SPECIFIED; - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][date]", '', 'Date element found.'); - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value][time]", '', 'Time element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][date]", '', 'Date element found.'); + $this->assertFieldByName("$field_name[$langcode][0][value][time]", '', 'Time element found.'); // Submit invalid dates and ensure they is not accepted. $date_value = ''; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => '12:00:00', + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => '12:00:00', ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', 'Empty date value has been caught.'); $date_value = 'aaaa-12-01'; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => '00:00:00', + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => '00:00:00', ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', format_string('Invalid year value %date has been caught.', array('%date' => $date_value))); $date_value = '2012-75-01'; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => '00:00:00', + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => '00:00:00', ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', format_string('Invalid month value %date has been caught.', array('%date' => $date_value))); $date_value = '2012-12-99'; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => '00:00:00', + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => '00:00:00', ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', format_string('Invalid day value %date has been caught.', array('%date' => $date_value))); @@ -377,8 +377,8 @@ function testInvalidField() { $date_value = '2012-12-01'; $time_value = ''; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => $time_value, + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => $time_value, ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', 'Empty time value has been caught.'); @@ -386,8 +386,8 @@ function testInvalidField() { $date_value = '2012-12-01'; $time_value = '49:00:00'; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => $time_value, + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => $time_value, ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', format_string('Invalid hour value %time has been caught.', array('%time' => $time_value))); @@ -395,8 +395,8 @@ function testInvalidField() { $date_value = '2012-12-01'; $time_value = '12:99:00'; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => $time_value, + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => $time_value, ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', format_string('Invalid minute value %time has been caught.', array('%time' => $time_value))); @@ -404,8 +404,8 @@ function testInvalidField() { $date_value = '2012-12-01'; $time_value = '12:15:99'; $edit = array( - "{$this->field['field_name']}[$langcode][0][value][date]" => $date_value, - "{$this->field['field_name']}[$langcode][0][value][time]" => $time_value, + "$field_name[$langcode][0][value][date]" => $date_value, + "$field_name[$langcode][0][value][time]" => $time_value, ); $this->drupalPost(NULL, $edit, t('Save')); $this->assertText('date is invalid', format_string('Invalid second value %time has been caught.', array('%time' => $time_value))); diff --git a/core/modules/edit/lib/Drupal/edit/Tests/EditTestBase.php b/core/modules/edit/lib/Drupal/edit/Tests/EditTestBase.php index 8c455f0..649f033 100644 --- a/core/modules/edit/lib/Drupal/edit/Tests/EditTestBase.php +++ b/core/modules/edit/lib/Drupal/edit/Tests/EditTestBase.php @@ -54,12 +54,11 @@ function setUp() { */ function createFieldWithInstance($field_name, $type, $cardinality, $label, $instance_settings, $widget_type, $widget_settings, $formatter_type, $formatter_settings) { $field = $field_name . '_field'; - $this->field = array( + $this->$field = entity_create('field_entity', array( 'field_name' => $field_name, 'type' => $type, 'cardinality' => $cardinality, - ); - $this->$field = entity_create('field_entity', $this->field); + )); $this->$field->save(); $instance = $field_name . '_instance'; diff --git a/core/modules/edit/lib/Drupal/edit/Tests/EditorSelectionTest.php b/core/modules/edit/lib/Drupal/edit/Tests/EditorSelectionTest.php index e78ad0f..c1982c5 100644 --- a/core/modules/edit/lib/Drupal/edit/Tests/EditorSelectionTest.php +++ b/core/modules/edit/lib/Drupal/edit/Tests/EditorSelectionTest.php @@ -79,23 +79,23 @@ function testText() { $this->assertEqual('direct', $this->getSelectedEditor($items, $field_name), "Without text processing, cardinality 1, the 'direct' editor is selected."); // Editor selection with text processing, cardinality 1. - $this->field_text_instance['settings']['text_processing'] = 1; + $this->field_text_instance->settings['text_processing'] = 1; $this->field_text_instance->save(); $this->assertEqual('form', $this->getSelectedEditor($items, $field_name), "With text processing, cardinality 1, the 'form' editor is selected."); // Editor selection without text processing, cardinality 1 (again). - $this->field_text_instance['settings']['text_processing'] = 0; + $this->field_text_instance->settings['text_processing'] = 0; $this->field_text_instance->save(); $this->assertEqual('direct', $this->getSelectedEditor($items, $field_name), "Without text processing again, cardinality 1, the 'direct' editor is selected."); // Editor selection without text processing, cardinality >1 - $this->field_text_field['cardinality'] = 2; + $this->field_text_field->cardinality = 2; $this->field_text_field->save(); $items[] = array('value' => 'Hallo, wereld!', 'format' => 'full_html'); $this->assertEqual('form', $this->getSelectedEditor($items, $field_name), "Without text processing, cardinality >1, the 'form' editor is selected."); // Editor selection with text processing, cardinality >1 - $this->field_text_instance['settings']['text_processing'] = 1; + $this->field_text_instance->settings['text_processing'] = 1; $this->field_text_instance->save(); $this->assertEqual('form', $this->getSelectedEditor($items, $field_name), "With text processing, cardinality >1, the 'form' editor is selected."); } @@ -133,7 +133,7 @@ function testTextWysiwyg() { $this->assertEqual('wysiwyg', $this->getSelectedEditor($items, $field_name), "With cardinality 1, and the full_html text format, the 'wysiwyg' editor is selected."); // Editor selection with text processing, cardinality >1 - $this->field_textarea_field['cardinality'] = 2; + $this->field_textarea_field->cardinality = 2; $this->field_textarea_field->save(); $items[] = array('value' => 'Hallo, wereld!', 'format' => 'full_html'); $this->assertEqual('form', $this->getSelectedEditor($items, $field_name), "With cardinality >1, and both items using the full_html text format, the 'form' editor is selected."); @@ -163,7 +163,7 @@ function testNumber() { $this->assertEqual('form', $this->getSelectedEditor($items, $field_name), "With cardinality 1, the 'form' editor is selected."); // Editor selection with cardinality >1. - $this->field_nr_field['cardinality'] = 2; + $this->field_nr_field->cardinality = 2; $this->field_nr_field->save(); $this->assertEqual('form', $this->getSelectedEditor($items, $field_name), "With cardinality >1, the 'form' editor is selected."); } diff --git a/core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.php b/core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.php index 43c71ea..e9e3418 100644 --- a/core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.php +++ b/core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.php @@ -137,7 +137,7 @@ function testEditorSelection() { $this->assertEqual('editor', $this->getSelectedEditor($items, $this->field_name), "With cardinality 1, and the full_html text format, the 'editor' editor is selected."); // Editor selection with text processing, cardinality >1 - $this->field_textarea_field['cardinality'] = 2; + $this->field_textarea_field->cardinality = 2; $this->field_textarea_field->save(); $items[] = array('value' => 'Hallo, wereld!', 'format' => 'full_html'); $this->assertEqual('form', $this->getSelectedEditor($items, $this->field_name), "With cardinality >1, and both items using the full_html text format, the 'form' editor is selected."); diff --git a/core/modules/email/lib/Drupal/email/Tests/EmailFieldTest.php b/core/modules/email/lib/Drupal/email/Tests/EmailFieldTest.php index 7e9e072..2192cf3 100644 --- a/core/modules/email/lib/Drupal/email/Tests/EmailFieldTest.php +++ b/core/modules/email/lib/Drupal/email/Tests/EmailFieldTest.php @@ -46,21 +46,22 @@ function setUp() { */ function testEmailField() { // Create a field with settings to validate. - $this->field = array( - 'field_name' => drupal_strtolower($this->randomName()), + $field_name = drupal_strtolower($this->randomName()); + $this->field = entity_create('field_entity', array( + 'field_name' => $field_name, 'type' => 'email', - ); - entity_create('field_entity', $this->field)->save(); - $this->instance = array( - 'field_name' => $this->field['field_name'], + )); + $this->field->save(); + $this->instance = entity_create('field_instance', array( + 'field_name' => $field_name, 'entity_type' => 'entity_test', 'bundle' => 'entity_test', - ); - entity_create('field_instance', $this->instance)->save(); + )); + $this->instance->save(); // Create a form display for the default form mode. entity_get_form_display('entity_test', 'entity_test', 'default') - ->setComponent($this->field['field_name'], array( + ->setComponent($field_name, array( 'type' => 'email_default', 'settings' => array( 'placeholder' => 'example@example.com', @@ -69,7 +70,7 @@ function testEmailField() { ->save(); // Create a display for the full view mode. entity_get_display('entity_test', 'entity_test', 'full') - ->setComponent($this->field['field_name'], array( + ->setComponent($field_name, array( 'type' => 'email_mailto', )) ->save(); @@ -77,7 +78,7 @@ function testEmailField() { // Display creation form. $this->drupalGet('entity_test/add'); $langcode = Language::LANGCODE_NOT_SPECIFIED; - $this->assertFieldByName("{$this->field['field_name']}[$langcode][0][value]", '', 'Widget found.'); + $this->assertFieldByName("$field_name[$langcode][0][value]", '', 'Widget found.'); $this->assertRaw('placeholder="example@example.com"'); // Submit a valid e-mail address and ensure it is accepted. @@ -85,7 +86,7 @@ function testEmailField() { $edit = array( 'user_id' => 1, 'name' => $this->randomName(), - "{$this->field['field_name']}[$langcode][0][value]" => $value, + "$field_name[$langcode][0][value]" => $value, ); $this->drupalPost(NULL, $edit, t('Save')); preg_match('|entity_test/manage/(\d+)/edit|', $this->url, $match); diff --git a/core/modules/email/lib/Drupal/email/Tests/EmailItemTest.php b/core/modules/email/lib/Drupal/email/Tests/EmailItemTest.php index 9fc5bcc..7e72163 100644 --- a/core/modules/email/lib/Drupal/email/Tests/EmailItemTest.php +++ b/core/modules/email/lib/Drupal/email/Tests/EmailItemTest.php @@ -35,17 +35,15 @@ public function setUp() { parent::setUp(); // Create an email field and instance for validation. - $this->field = array( + entity_create('field_entity', array( 'field_name' => 'field_email', 'type' => 'email', - ); - entity_create('field_entity', $this->field)->save(); - $this->instance = array( + ))->save(); + entity_create('field_instance', array( 'entity_type' => 'entity_test', 'field_name' => 'field_email', 'bundle' => 'entity_test', - ); - entity_create('field_instance', $this->instance)->save(); + ))->save(); // Create a form display for the default form mode. entity_get_form_display('entity_test', 'entity_test', 'default') diff --git a/core/modules/entity/lib/Drupal/entity/Tests/EntityDisplayTest.php b/core/modules/entity/lib/Drupal/entity/Tests/EntityDisplayTest.php index e33f487..24cb092 100644 --- a/core/modules/entity/lib/Drupal/entity/Tests/EntityDisplayTest.php +++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityDisplayTest.php @@ -139,22 +139,23 @@ public function testFieldComponent() { 'mode' => 'default', )); + $field_name = 'test_field'; // Create a field and an instance. - $field = array( - 'field_name' => 'test_field', + $field = entity_create('field_entity', array( + 'field_name' => $field_name, 'type' => 'test_field' - ); - entity_create('field_entity', $field)->save(); - $instance = array( - 'field_name' => $field['field_name'], + )); + $field->save(); + $instance = entity_create('field_instance', array( + 'field_name' => $field_name, 'entity_type' => 'entity_test', 'bundle' => 'entity_test', - ); - entity_create('field_instance', $instance)->save(); + )); + $instance->save(); // Check that providing no options results in default values being used. - $display->setComponent($field['field_name']); - $field_type_info = field_info_field_types($field['type']); + $display->setComponent($field_name); + $field_type_info = field_info_field_types($field->type); $default_formatter = $field_type_info['default_formatter']; $default_settings = field_info_formatter_settings($default_formatter); $expected = array( @@ -163,10 +164,10 @@ public function testFieldComponent() { 'type' => $default_formatter, 'settings' => $default_settings, ); - $this->assertEqual($display->getComponent($field['field_name']), $expected); + $this->assertEqual($display->getComponent($field_name), $expected); // Check that the getFormatter() method returns the correct formatter plugin. - $formatter = $display->getFormatter($field['field_name']); + $formatter = $display->getFormatter($field_name); $this->assertEqual($formatter->getPluginId(), $default_formatter); $this->assertEqual($formatter->getSettings(), $default_settings); @@ -174,26 +175,26 @@ public function testFieldComponent() { // arbitrary property and reading it back. $random_value = $this->randomString(); $formatter->randomValue = $random_value; - $formatter = $display->getFormatter($field['field_name']); + $formatter = $display->getFormatter($field_name); $this->assertEqual($formatter->randomValue, $random_value); // Check that changing the definition creates a new formatter. - $display->setComponent($field['field_name'], array( + $display->setComponent($field_name, array( 'type' => 'field_test_multiple', )); - $formatter = $display->getFormatter($field['field_name']); + $formatter = $display->getFormatter($field_name); $this->assertEqual($formatter->getPluginId(), 'field_test_multiple'); $this->assertFalse(isset($formatter->randomValue)); // Check that specifying an unknown formatter (e.g. case of a disabled // module) gets stored as is in the display, but results in the default // formatter being used. - $display->setComponent($field['field_name'], array( + $display->setComponent($field_name, array( 'type' => 'unknown_formatter', )); - $options = $display->getComponent($field['field_name']); + $options = $display->getComponent($field_name); $this->assertEqual($options['type'], 'unknown_formatter'); - $formatter = $display->getFormatter($field['field_name']); + $formatter = $display->getFormatter($field_name); $this->assertEqual($formatter->getPluginId(), $default_formatter); } @@ -232,32 +233,33 @@ public function testRenameDeleteBundle() { public function testDeleteFieldInstance() { $this->enableModules(array('field_sql_storage', 'field_test')); + $field_name = 'test_field'; // Create a field and an instance. $field = entity_create('field_entity', array( - 'field_name' => 'test_field', + 'field_name' => $field_name, 'type' => 'test_field' )); $field->save(); $instance = entity_create('field_instance', array( - 'field_name' => $field['field_name'], + 'field_name' => $field_name, 'entity_type' => 'entity_test', 'bundle' => 'entity_test', )); $instance->save(); // Create an entity display. - $display = entity_create('entity_display', array( + entity_create('entity_display', array( 'targetEntityType' => 'entity_test', 'bundle' => 'entity_test', 'viewMode' => 'default', - ))->setComponent($field['field_name'])->save(); + ))->setComponent($field_name)->save(); // Delete the instance. $instance->delete(); // Check that the component has been removed from the entity display. $display = entity_get_display('entity_test', 'entity_test', 'default'); - $this->assertFalse($display->getComponent($field['field_name'])); + $this->assertFalse($display->getComponent($field_name)); } } diff --git a/core/modules/entity/lib/Drupal/entity/Tests/EntityFormDisplayTest.php b/core/modules/entity/lib/Drupal/entity/Tests/EntityFormDisplayTest.php index 5d199ad..e7cb19d 100644 --- a/core/modules/entity/lib/Drupal/entity/Tests/EntityFormDisplayTest.php +++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityFormDisplayTest.php @@ -62,21 +62,22 @@ public function testFieldComponent() { )); // Create a field and an instance. - $field = array( - 'field_name' => 'test_field', + $field_name = 'test_field'; + $field = entity_create('field_entity', array( + 'field_name' => $field_name, 'type' => 'test_field' - ); - entity_create('field_entity', $field)->save(); - $instance = array( - 'field_name' => $field['field_name'], + )); + $field->save(); + $instance = entity_create('field_instance', array( + 'field_name' => $field_name, 'entity_type' => 'entity_test', 'bundle' => 'entity_test', - ); - entity_create('field_instance', $instance)->save(); + )); + $instance->save(); // Check that providing no options results in default values being used. - $form_display->setComponent($field['field_name']); - $field_type_info = field_info_field_types($field['type']); + $form_display->setComponent($field_name); + $field_type_info = field_info_field_types($field->type); $default_widget = $field_type_info['default_widget']; $default_settings = field_info_widget_settings($default_widget); $expected = array( @@ -84,10 +85,10 @@ public function testFieldComponent() { 'type' => $default_widget, 'settings' => $default_settings, ); - $this->assertEqual($form_display->getComponent($field['field_name']), $expected); + $this->assertEqual($form_display->getComponent($field_name), $expected); // Check that the getWidget() method returns the correct widget plugin. - $widget = $form_display->getWidget($field['field_name']); + $widget = $form_display->getWidget($field_name); $this->assertEqual($widget->getPluginId(), $default_widget); $this->assertEqual($widget->getSettings(), $default_settings); @@ -95,26 +96,26 @@ public function testFieldComponent() { // arbitrary property and reading it back. $random_value = $this->randomString(); $widget->randomValue = $random_value; - $widget = $form_display->getWidget($field['field_name']); + $widget = $form_display->getWidget($field_name); $this->assertEqual($widget->randomValue, $random_value); // Check that changing the definition creates a new widget. - $form_display->setComponent($field['field_name'], array( + $form_display->setComponent($field_name, array( 'type' => 'field_test_multiple', )); - $widget = $form_display->getWidget($field['field_name']); + $widget = $form_display->getWidget($field_name); $this->assertEqual($widget->getPluginId(), 'test_field_widget'); $this->assertFalse(isset($widget->randomValue)); // Check that specifying an unknown widget (e.g. case of a disabled module) // gets stored as is in the display, but results in the default widget being // used. - $form_display->setComponent($field['field_name'], array( + $form_display->setComponent($field_name, array( 'type' => 'unknown_widget', )); - $options = $form_display->getComponent($field['field_name']); + $options = $form_display->getComponent($field_name); $this->assertEqual($options['type'], 'unknown_widget'); - $widget = $form_display->getWidget($field['field_name']); + $widget = $form_display->getWidget($field_name); $this->assertEqual($widget->getPluginId(), $default_widget); } diff --git a/core/modules/entity_reference/entity_reference.module b/core/modules/entity_reference/entity_reference.module index 4703fdf..78182db 100644 --- a/core/modules/entity_reference/entity_reference.module +++ b/core/modules/entity_reference/entity_reference.module @@ -217,7 +217,7 @@ function entity_reference_field_update_field($field, $prior_field, $has_data) { foreach ($field['bundles'] as $entity_type => $bundles) { foreach ($bundles as $bundle) { $instance = field_info_instance($entity_type, $field_name, $bundle); - $instance['settings']['handler_settings'] = array(); + $instance->settings['handler_settings'] = array(); $instance->save(); } } diff --git a/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceAutoCreateTest.php b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceAutoCreateTest.php index 6efe285..2d1f3bb 100644 --- a/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceAutoCreateTest.php +++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceAutoCreateTest.php @@ -35,7 +35,7 @@ function setUp() { $referenced = $this->drupalCreateContentType(); $this->referenced_type = $referenced->type; - $field = array( + entity_create('field_entity', array( 'translatable' => FALSE, 'entity_types' => array(), 'settings' => array( @@ -44,11 +44,9 @@ function setUp() { 'field_name' => 'test_field', 'type' => 'entity_reference', 'cardinality' => FIELD_CARDINALITY_UNLIMITED, - ); - - entity_create('field_entity', $field)->save(); + ))->save(); - $instance = array( + entity_create('field_instance', array( 'label' => 'Entity reference field', 'field_name' => 'test_field', 'entity_type' => 'node', @@ -64,9 +62,7 @@ function setUp() { 'auto_create' => TRUE, ), ), - ); - - entity_create('field_instance', $instance)->save(); + ))->save(); entity_get_form_display('node', $referencing->type, 'default') ->setComponent('test_field', array( diff --git a/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.php b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.php index 253249d..85c13b3 100644 --- a/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.php +++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.php @@ -36,22 +36,20 @@ function setUp() { */ public function testSort() { // Add text field to entity, to sort by. - $field_info = array( + entity_create('field_entity', array( 'field_name' => 'field_text', 'type' => 'text', 'entity_types' => array('node'), - ); - entity_create('field_entity', $field_info)->save(); + ))->save(); - $instance_info = array( + entity_create('field_instance', array( 'label' => 'Text Field', 'field_name' => 'field_text', 'entity_type' => 'node', 'bundle' => 'article', 'settings' => array(), 'required' => FALSE, - ); - entity_create('field_instance', $instance_info)->save(); + ))->save(); // Build a fake field instance.