diff --git a/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php index 5d3986e..0a706f2 100644 --- a/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php +++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php @@ -183,7 +183,7 @@ function click_sort($order) { * to TRUE if not set. */ function click_sortable() { - return isset($this->definition['click sortable']) ? $this->defintion['click sortable'] : TRUE; + return isset($this->definition['click sortable']) ? $this->definition['click sortable'] : TRUE; } /** diff --git a/core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php b/core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php index b9c6257..5b21a67 100644 --- a/core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php +++ b/core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php @@ -47,6 +47,8 @@ protected function setUp() { protected function viewsData() { $data = parent::viewsData(); $data['views_test_data']['job']['field']['id'] = 'test_field'; + $data['views_test_data']['job']['field']['click sortable'] = FALSE; + $data['views_test_data']['id']['field']['click sortable'] = TRUE; return $data; } @@ -514,4 +516,21 @@ function testIsValueEmpty() { $this->assertTrue($field->is_value_empty(NULL, TRUE, FALSE), 'Null should be always seen as empty, regardless of no_skip_empty.'); } + /** + * Tests whether the filters are click sortable as expected. + */ + public function testClickSortable() { + // Test that click_sortable is TRUE by default. + $plugin = views_get_handler('views_test_data', 'name', 'field'); + $this->assertTrue($plugin->click_sortable(), 'TRUE as a default value is correct.'); + + // Test that click_sortable is TRUE by when set TRUE in the data. + $plugin = views_get_handler('views_test_data', 'id', 'field'); + $this->assertTrue($plugin->click_sortable(), 'TRUE as a views data value is correct.'); + + // Test that click_sortable is FALSE by when set FALSE in the data. + $plugin = views_get_handler('views_test_data', 'job', 'field'); + $this->assertFalse($plugin->click_sortable(), 'FALSE as a views data value is correct.'); + } + }