diff --git a/core/modules/language/language.admin.inc b/core/modules/language/language.admin.inc index 3ebaab1..33cc45a 100644 --- a/core/modules/language/language.admin.inc +++ b/core/modules/language/language.admin.inc @@ -335,102 +335,6 @@ function theme_language_negotiation_configure_browser_form_table($variables) { } /** - * Returns the content language settings form. - */ -function language_content_settings_page() { - return drupal_get_form('language_content_settings_form', language_entity_supported()); -} - -/** - * Form constructor for the content language settings form. - * - * @param array $supported - * Entity types with language support. - * - * @see language_content_settings_form_submit() - * - * @ingroup forms - */ -function language_content_settings_form(array $form, array $form_state, array $supported) { - $entity_info = entity_get_info(); - $labels = array(); - $default = array(); - - foreach ($supported as $entity_type) { - $labels[$entity_type] = isset($entity_info[$entity_type]['label']) ? $entity_info[$entity_type]['label'] : $entity_type; - $default[$entity_type] = FALSE; - - // Check whether we have any custom setting. - foreach (entity_get_bundles($entity_type) as $bundle => $bundle_info) { - $conf = language_get_default_configuration($entity_type, $bundle); - if (!empty($conf['language_show']) || $conf['langcode'] != 'site_default') { - $default[$entity_type] = $entity_type; - } - $language_configuration[$entity_type][$bundle] = $conf; - } - } - - asort($labels); - - $path = drupal_get_path('module', 'language'); - $form = array( - '#labels' => $labels, - '#attached' => array( - 'css' => array($path . '/css/language.admin.css'), - ), - ); - - $form['entity_types'] = array( - '#title' => t('Custom language settings'), - '#type' => 'checkboxes', - '#options' => $labels, - '#default_value' => $default, - ); - - $form['settings'] = array('#tree' => TRUE); - - foreach ($labels as $entity_type => $label) { - $info = $entity_info[$entity_type]; - - $form['settings'][$entity_type] = array( - '#title' => $label, - '#type' => 'container', - '#entity_type' => $entity_type, - '#theme' => 'language_content_settings_table', - '#bundle_label' => isset($info['bundle_label']) ? $info['bundle_label'] : $label, - '#states' => array( - 'visible' => array( - ':input[name="entity_types[' . $entity_type . ']"]' => array('checked' => TRUE), - ), - ), - ); - - foreach (entity_get_bundles($entity_type) as $bundle => $bundle_info) { - $form['settings'][$entity_type][$bundle]['settings'] = array( - '#type' => 'item', - '#label' => $bundle_info['label'], - 'language' => array( - '#type' => 'language_configuration', - '#entity_information' => array( - 'entity_type' => $entity_type, - 'bundle' => $bundle, - ), - '#default_value' => $language_configuration[$entity_type][$bundle], - ), - ); - } - } - - $form['actions'] = array('#type' => 'actions'); - $form['actions']['submit'] = array( - '#type' => 'submit', - '#value' => t('Save'), - ); - - return $form; -} - -/** * Implements hook_preprocess_HOOK() for theme_language_content_settings_table(). */ function template_preprocess_language_content_settings_table(&$variables) { @@ -492,19 +396,6 @@ function theme_language_content_settings_table($variables) { } /** - * Form submission handler for language_content_settings_form(). - */ -function language_content_settings_form_submit(array $form, array &$form_state) { - $settings = &$form_state['values']['settings']; - foreach ($settings as $entity_type => $entity_settings) { - foreach ($entity_settings as $bundle => $bundle_settings) { - language_save_default_configuration($entity_type, $bundle, $bundle_settings['settings']['language']); - } - } - drupal_set_message(t('Settings successfully updated.')); -} - -/** * Helper function to disable the language switcher blocks. * * @param array $language_types diff --git a/core/modules/language/language.module b/core/modules/language/language.module index 83f61e9..822e046 100644 --- a/core/modules/language/language.module +++ b/core/modules/language/language.module @@ -124,9 +124,7 @@ function language_menu() { $items['admin/config/regional/content-language'] = array( 'title' => 'Content language settings', 'description' => 'Configure content language support for any multilingual element.', - 'page callback' => 'language_content_settings_page', - 'access arguments' => array('administer languages'), - 'file' => 'language.admin.inc', + 'route_name' => 'language_content_settings', ); return $items; @@ -172,22 +170,6 @@ function language_theme() { } /** - * Returns a list of supported entity types. - * - * @return array - * An array of entity type names. - */ -function language_entity_supported() { - $supported = array(); - foreach (entity_get_info() as $entity_type => $info) { - if (!empty($info['translatable'])) { - $supported[$entity_type] = $entity_type; - } - } - return $supported; -} - -/** * Implements hook_element_info_alter(). */ function language_element_info_alter(&$type) { @@ -301,7 +283,7 @@ function language_configuration_element_process($element, &$form_state, &$form) // Do not add the submit callback for the language content settings page, // which is handled separately. - if (array_search('language_content_settings_form_submit', $form['#submit']) === FALSE) { + if ($form['#form_id'] != 'language_content_settings_form') { // Determine where to attach the language_configuration element submit handler. // @todo Form API: Allow form widgets/sections to declare #submit handlers. if (isset($form['actions']['submit']['#submit']) && array_search('language_configuration_element_submit', $form['actions']['submit']['#submit']) === FALSE) { diff --git a/core/modules/language/language.routing.yml b/core/modules/language/language.routing.yml index c7e8f12..fbb12a5 100644 --- a/core/modules/language/language.routing.yml +++ b/core/modules/language/language.routing.yml @@ -61,3 +61,10 @@ language_negotiation_browser_delete: _form: '\Drupal\language\Form\NegotiationBrowserDeleteForm' requirements: _permission: 'administer languages' + +language_content_settings: + pattern: '/admin/config/regional/content-language' + defaults: + _form: 'Drupal\language\Form\ContentLanguageSettingsForm' + requirements: + _permission: 'administer languages' diff --git a/core/modules/language/lib/Drupal/language/Form/ContentLanguageSettingsForm.php b/core/modules/language/lib/Drupal/language/Form/ContentLanguageSettingsForm.php index 65becdf..02429aa 100644 --- a/core/modules/language/lib/Drupal/language/Form/ContentLanguageSettingsForm.php +++ b/core/modules/language/lib/Drupal/language/Form/ContentLanguageSettingsForm.php @@ -53,22 +53,6 @@ public static function create(ContainerInterface $container) { } /** - * Return a list of entity types for which language settings are supported. - * - * @return array - * A list of entity types which are translatable. - */ - protected function entitySupported() { - $supported = array(); - foreach ($this->entityManager->getDefinitions() as $entity_type => $info) { - if (!empty($info['translatable'])) { - $supported[$entity_type] = $entity_type; - } - } - return $supported; - } - - /** * {@inheritdoc} */ public function getFormID() { @@ -83,14 +67,17 @@ public function buildForm(array $form, array &$form_state) { $labels = array(); $default = array(); - $bundles = entity_get_bundles(); + $bundles = $this->entityManager->getAllBundleInfo(); $language_configuration = array(); - foreach ($this->entitySupported() as $entity_type) { - $labels[$entity_type] = isset($entity_info[$entity_type]['label']) ? $entity_info[$entity_type]['label'] : $entity_type; + foreach ($entity_info as $entity_type =>$info) { + if (empty($info['translatable'])) { + continue; + } + $labels[$entity_type] = isset($info['label']) ? $info['label'] : $entity_type; $default[$entity_type] = FALSE; // Check whether we have any custom setting. - foreach ($bundles as $bundle => $bundle_info) { + foreach ($bundles[$entity_type] as $bundle => $bundle_info) { $conf = language_get_default_configuration($entity_type, $bundle); if (!empty($conf['language_show']) || $conf['langcode'] != 'site_default') { $default[$entity_type] = $entity_type; @@ -135,7 +122,7 @@ public function buildForm(array $form, array &$form_state) { ), ); - foreach ($bundles as $bundle => $bundle_info) { + foreach ($bundles[$entity_type] as $bundle => $bundle_info) { $form['settings'][$entity_type][$bundle]['settings'] = array( '#type' => 'item', '#label' => $bundle_info['label'], @@ -157,7 +144,7 @@ public function buildForm(array $form, array &$form_state) { '#value' => $this->t('Save'), ); - return parent::buildForm($form, $form_state); + return $form; } /** @@ -167,16 +154,14 @@ public function submitForm(array &$form, array &$form_state) { $config = $this->configFactory->get('language.settings'); foreach ($form_state['values']['settings'] as $entity_type => $entity_settings) { foreach ($entity_settings as $bundle => $bundle_settings) { - $config->set(language_get_default_configuration_settings_key($entity_type, $bundle), - array( - 'langcode' => $bundle_settings['settings']['language']['langcode'], - 'language_show' => $bundle_settings['settings']['langcode']['language_show'], - ) - ); + $config->set(language_get_default_configuration_settings_key($entity_type, $bundle), array( + 'langcode' => $bundle_settings['settings']['language']['langcode'], + 'language_show' => $bundle_settings['settings']['language']['language_show'], + )); } } $config->save(); - parent::submitForm($form, $form_state); + drupal_set_message($this->t('Settings successfully updated.')); } }