Hi,

ImageFlow works fine for me, only one little problem.

Once I activate 'Optimize CSS Files' under Performance, a formerly perfectly working view with ImageFlow Slideshow is then showing the images in a vertical alignment, thus from top to bottom instead of left to right.

Thanks for having a look,
Boro

Comments

altparty’s picture

Hi,

Same problem here. Looking for a solution because optimizing CSS files is a must.

Greetzz, Martin.

bserem’s picture

subscribing

same applies from 2.x-dev

aaron’s picture

Status: Active » Closed (won't fix)

The fix is simple. Unfortunately, you have to apply it manually, as the flaw is in the plugin, which is not licensed as GPL, which means I can't put that in the module.

You have to remove the offending first line of imageflow.css contained in the plugin that reads:

@charset "utf-8";

Sorry...

bserem’s picture

Title: Enabling CSS File Optimization makes ImageFlow Container show Images vertical » SOLVED: Enabling CSS File Optimization makes ImageFlow Container show Images vertical

Thank you very much. It works like a charm now!

I suggest adding this piece of information on the project page, after all most of the sites will run in perfomance mode!

Thanks again ;)

jodyfr’s picture

Thanks for the great ImageFlow module.

I'm using version 6.x-2.x-dev in Drupal 6.16, and unfortunately I'm still experiencing the vertical alignment issue even after removing the utf-8 line from the plugin stylesheet and from every other module stylesheet. The alignment is fine as soon as I disable css optimization (not an option for the live site due to IE problems). With optimization off, I opened every stylesheet included in the page to check for charset encoding, and none has it. Do you have any other ideas?

Thanks in advance for your help!

aaron’s picture

Status: Closed (won't fix) » Active

@jodyfr: in general, please set the status of tickets back to active if you need to re-open them, so they don't get lost in the shuffle. (i've done that for you in this case.)

it's odd you're still having the problem. is there anyway you could post a link to the site so i can take a look?

thanks,
aaron

bserem’s picture

may I suggest clearing all of your caches?

jdelaune’s picture

I had the same issue. Removing the @media screen, projection { } as well as the @charset "utf-8"; worked a treat for me.

aaron’s picture

Status: Active » Postponed (maintainer needs more info)

@jodyfr: If you are not able to post a link (you can send it at my contact page if you'd rather), can you at least flush your cache and attach an export of your view to this issue?

Thanks,
Aaron

aaron’s picture

i've updated the project page with instructions to solve this unfortunate bug.

aaron’s picture

@Starnox: Are you saying that you still had the problem when you removed the @charset "utf-8";, but still had the @media screen, projection { }? I only had to remove the first bit to get things working again.

aaron’s picture

With all these similar issues, it might be worth refactoring the module to use another plugin. Perhaps http://www.jacksasylum.eu/ContentFlow/ -- that looks like it covers the same functionality. It still has the licensing issues, but it's been released under MIT, so maybe the author would be willing to dual license to GPL?

jodyfr’s picture

Sorry for the delay in response: I thought I'd get an auto email notice of updates to this thread. Thanks for the quick responses. Yes, I had cleared the cache and removed @charset "utf-8" from the plug-in css file and every other css file it appeared in. I'll try removing @media screen as soon as I can get back to this (the site must go live today, and I've de-activated ImageFlow for now) and will send a link if unsuccessful.

aaron’s picture

Oddly, this was supposed to have been fixed in Drupal 5 core, according to #792578: charset declaration still present when caching css. Also, it looks like this particular issue has been fixed for real in Drupal 7, although I haven't yet found the corresponding issue.

aaron’s picture

or rather, the original issue was at #168620: CSS compress: remove charset declarations for standards compliance; the other is the new issue i opened against it...

bserem’s picture

jodyfr please inform us how things go

for me the problem was solved instantly and my site is live and you can see it here: karnavalikokomitato.gr

note that I have javascript optimazation set to enabled!

jdelaune’s picture

@aaron yup. Just removing the charset didn't work for me, I had to remove the other bits as well.

BoromirOfGondor’s picture

works for me as well, so many thanks!

FreddieK’s picture

Removing the @media screen, projection { } bit solves the vertical images for me, but results in the imageflow view growing outside the div container when optimizing CSS and not even being centered. The image sizes gets calculated differently for some reason.

Drupal 6.16, Slideshow 2.1, Imageflow 2.x-dev that is.

Update: I created a separate issue for this here.

tribsinpa’s picture

I had the same issue as #19. It's not a great solution but it fixes the problem. I did the following

Added to my theme's page.tpl.php under print $styles;

<link type="text/css" rel="stylesheet" href="/sites/all/plugins/imageflow/imageflow.css?6" />

commented out
/sites/all/modules/views_slideshow_imageflow/themes/views_slideshow_imageflow.theme.inc
line 46:

//drupal_add_css($path .'/imageflow.css');
FreddieK’s picture

Thanks, that solved my problem!

unic’s picture

Version: 6.x-1.0-beta1 » 6.x-2.x-dev

I think this solution is better. Just use imageflow.packed.css (rename to) instead of imageflow.css;

aaron’s picture

Status: Postponed (maintainer needs more info) » Fixed

OK, #20 might be the best work-around for folks; thanks @tribsinva. I've added a checkbox on the admin screen so you don't have to hack the module; simply uncheck that box if you're planning to include the file separately. Sorry it's such a PITA; I've linked to this issue from the admin screen as well for reference.

aaron’s picture

Status: Fixed » Needs review

so actually, i also have it using the packed files, and it works locally for me perfectly with CSS optimization, without needing to hack or externally include anything. i'd be very interested to see if this is just a fluke, or if the fix can be reproduced. would be really nice to mark the issue fixed for real...

the change is in CVS right now; you'll see checkboxes in the admin screen for including the packed versions and including/excluding the css.

aaron’s picture

if that doesn't work, i'd next like to try changing the module's system weight. but i'll wait to hear about confirmation. thanks!

aaron’s picture

oops; i'd added a stupid typo, fixed that now. make sure to grab latest from cvs if it hasn't already been packaged...

aaron’s picture

i've also just rolled an alpha release with the changes.

stevenadav’s picture

am using drupal7,i want to install the image plugin "Views Slideshow: ImageFlow",what are the necessary additional plugins i have to install...is it a opensource plugin?plz help me out i liked this image plugin...when am trying it is showing some errors like Views_jqfx (missing),Integrates the Galleria plugin with Views jQFX:Requires: Views_jqfx (missing)...am unable to get those thongs help me out....