User email field need to use Field-Entity-aware formatters in Views

Initial code to remove mail plugin, the only problem here that link to user functionality setting could be achieved by adding a UID field to view and overriding the field with link.
Suppose there should be an option in views like provide a link to entity for each entity fleld.

Also I found that there's 2 UID fields that could be added - probably separate issue

Now clean-up name usage

missed interdiff

Fixed what testbot is complaining about. Not sure if it's right @andypost, let me know otherwise.

I'm sorry but this sounds like a duplicate of #2454145: Replace user_name handler with Field API formatter, but without adding a new formatter ...

...
Let's rescope the issue to just be on emails

@dawehner so #3 does that, do we need to unpublish other patches?

@dawehner so #3 does that, do we need to unpublish other patches?

+++ /dev/null
@@ -1,57 +0,0 @@
-      '#type' => 'radios',
-      '#options' => array(
-        0 => $this->t('No link'),
-        'user' => $this->t('To the user'),
-        'mailto' => $this->t("With a mailto:"),
-      ),
...
-    if ($this->options['link_to_user'] == 'mailto') {
-      $this->options['alter']['make_link'] = TRUE;
-      $this->options['alter']['path'] = "mailto:" . $data;

Where did that option went to?

Currently only string and mailto formatters are supported, to make the field as link:
1) use views aboility to override
2) or inherit the plugin from field

Ah, so there is a specific mailto formatter. +1 for #3

So #3 still applies cleanly

#3 looks fine for me!

So we're fixing a bug here, bad enough to be critical and block D8's release, but we're not adding any test coverage for it. Feels a bit strange.

Talked about this in IRC w/ xjm and dawehner. While in most cases, #2385443: Test that base entity fields on views respect field level access is sufficient to check for this condition (after all, it's highly unlikely that once we've turned something into a field we would un-field it again), this particular field contains sensitive user information so would likely result in a SA if it were to break again.

So let's get a small test here to ensure this stays working as expected.

Started to write some generic test which can be reused for this issue and potentially all others.

Decided to split of the access checking into its own issue, in order to have a more fundamental / wide spread effort to check access.

See #2462589: Provide test coverage for access checking of all views fields.

RE #10, rescoping: did you file another issue to take care of the rest of what is in the summary, and update the meta-issue parent? The summary still says it covers a bunch of fields. We need to cover them *somewhere* and the other issue mentioned in #10 doesn't cover them I think?

We could add all the fields in here, for all the entity types and comment those out, which fail, as they aren't yet converted.

For example the mail field, which is part of this issue, fails currently on the provided test.

Per #2393339-57: [META] Make sure Views base fields are using Field API for formatting, and do not lose functionality, tagging for critical office hours, but if there's a reason to not have this particular child issue in that list, please untag it.

So I'm curious whether we can get the issue in and add the test coverage as part of the other patch (#2462589: Provide test coverage for access checking of all views fields.)

So apparently the patch in #3 is rtbc - can the latest patch be rtbc please? Also I think it is better to introduce a generic test. Access tests are hard to get right and doing it well once makes sense to me.

so, it seems like the tests from the other issue will cover this.
to demonstrate, here are some combined patches.
but 25 without the tests is the rtbc'able committable thing.

Thank you for posting a test only patch but well.

Set the patch of comment NR3. finally back to RTBC again.

I think this shows what @alexpott asked for, that the generic tests will cover this.

We've got the critical followup to add tests so committed the test free patch. Committed 26984ad and pushed to 8.0.x. Thanks!