Closed (fixed)
Project:
Yandex.Metrics
Version:
7.x-3.x-dev
Component:
Miscellaneous
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Mar 2015 at 09:50 UTC
Updated:
27 Apr 2015 at 22:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Konstantin Komelin commentedComment #2
Konstantin Komelin commentedComment #3
Konstantin Komelin commentedComment #4
Konstantin Komelin commentedComment #5
Konstantin Komelin commentedComment #6
Konstantin Komelin commentedComment #7
Niremizov commentedAs it seems to me installing another dependency module (with Update Manager) is simpler than adding external library manually. So Visualization looks Ok, but as I remember there is some troubles with rendering charts on Ajax call.
Comment #8
Pierre.Vriens commentedHey buddies over here!
Thought I'd add a few items to your considerations, which might help for you to decide:
With all this in mind, if I was in your shoes to decide, I would consider this shortlist as options to pick from:
Voilà, just my 2 cents of input to help you in your decision process, OK? I'm curious which route you're going to go for, keep me informed please.
PS 1: let's think positive about this challenge, there HAS to be a way to get this resolved on time, don't you think? A pitty it has taken so long to get something moving in charting-land in Drupal, but may I say "at least I got something going ..."? Of course it would help if "other people" would be willing to start helping/contributing, because for quite some months it has been a pretty lonely road in the direction of my "Chart 2.0" target.
PS 2: consider slightly rewording the title of your issue (it is not the 'chart API', but the "Google Image Charts library")
Comment #9
Konstantin Komelin commentedThanks Pierre. I will read your comment attentively when I have time.
For now:
From the official documentation:
https://developers.google.com/chart/image/
I'm not going to waste time for somebody's perfectionism.
-- Konstantin
Comment #10
Konstantin Komelin commentedComment #11
Niremizov commentedC Visualization API, вариант есть, но мне надо больше времени и это потребует переработать модуль Visualization API.
Возможно перенести ту часть кода, который отвечает за подгрузку графиков через AJAX, прямо в Visualization API. Т.е. будет достаточно просто указать что мы хотим вывести график, а данные можно взять из такого-то URL.
Где 'admin/yandex_metrics_ajax_data/12354/week/genre' - будет возвращать данные счетчика в JSON формате.
Comment #12
kalabroDo we really need AJAX loading in Yandex Metrics reports? Can we refactor yandex_metrics-7.x-3.x instead to use current Visualization API?
Comment #13
Konstantin Komelin commentedВидимо вы не читаете скайп-чат.
Приведу цитату:
Comment #14
Konstantin Komelin commentedМы ищем быстрый и простой вариант как помочь юзерам 7-ой версии. Визуализейшн - это сложно, поэтому смотрим на Charts.
No, we don't.
Comment #15
Konstantin Komelin commentedJust reminder. You and I decided to concentrate on Charts.
Comment #16
Niremizov commentedЕсли AJAX не нужен, то и действий дополнительных не нужно... Так что Visualization, можно использовать прямо как есть. Я могу создать отдельную ветку чтобы Вы посмотрели, ок или не ок...
Comment #17
Konstantin Komelin commentedДа Никит, было бы супер!
Я создал ветку 7.x-3.x (но лучше, наверное, потестить на какой-то другой, можешь создать временно)
Тут же главное, чтобы нам не пришлось сильно переделывать код для графиков.
Comment #18
Pierre.Vriens commentedA pity quite a few recent comments require some language skills I do not have. No worries though, I assume anything relevant "for me" will eventually show up somewhere in a language I am moe comfortable with.
Comment #19
Konstantin Komelin commentedSorry Pierre for using Russian in comments. For some guys it is the only way to go in the conditions of extreme urgency.
To summarize our discussion above, we are choosing between Charts and Visualization and trying to estimate effort needed.
I think we will let you know once we make the final decision.
Thanks,
Konstantin
Comment #20
Niremizov commentedhttp://cgit.drupalcode.org/yandex_metrics/commit/?id=0b47478
Может излишне много кода убрал, а так работает, вроде.
Comment #21
Konstantin Komelin commentedThank you Nikita. It seems like Visualization and new Google API make more things with less code required.
Attached screenshots of Chart and Visualization reports. As you can see, Hourly Traffic doesn't work for some reasons.
Comment #22
Konstantin Komelin commentedComment #23
Konstantin Komelin commentedUpdated the issue description to reflect our latest considerations and decisions.
Comment #24
Konstantin Komelin commentedComment #25
Konstantin Komelin commentedFor Visualization maintainers:
I've tested dev version, it works fine for me. Please consider possibility to release beta1 ? You might want to start collecting feedback from non-tech users as early as possible.
Comment #27
Niremizov commentedHourly Trafic graph does not properly work because of $1913416 issue.
Comment #28
Niremizov commentedCommit 5be0af2 Hourly Traffic visit info number rounded.
Ok, hourly traffic graph have been fixed for now. #1913416 - issue also fixed.
Suppose, I'm done with Yandex.Metrics, now going to fixes Visualization API issues.
Comment #29
Konstantin Komelin commentedThank you Nikita for your efforts. You've done a great job. It's important for us and our users.
I've tested your change. It works like a charm :)
Kate, can you also take a look and then we'll ask Nikita to push to 7.x-3.x?
Best,
Konstantin
Comment #31
Konstantin Komelin commentedWe look forward to a new Visualization release to fix dependency.
Comment #32
Niremizov commentedThere is only one bug left - https://www.drupal.org/node/1915362 to make Visualization API release.
This 'sorting' trouble needs a bit of Christophe assist, I have send him a mail, after he response I would try to resolve this in short time.
Comment #33
Niremizov commentedFixed, would be greate if someone would test Visualization API module...
Comment #34
Pierre.Vriens commentedNikita, great work you seem to have been doing, for this module, but also for the Visualization module (yes I saw all those issue updates you performed there!). In French we say "Chapeau!" (= heads off for you).
I'd like to refer to this issue within the documentation of the chart module (and possibly also in teh visualization docu), to provide samples of other modules who have changed there chart dependency to another module. But by looking at this issue, I've problems (of course) with the various comments that are not in English. Therefor this request for you (or maybe Konstantin?): can you add 1 extra comment please (in English) which summarizes what in the end you had to do? If possible with a patch attached also to illustrate the actual lines you had to change.
Thank you in advance for doing so!
PS: after I finish fighting the chart deadline of april 2015, I plan to work on enhancing the visualization docu. If I'm to decide on that, I would like it to become similar (its topics and structure) to what is now available for charts, and for chart (both are still in a kind of work-in-progress though).
Comment #35
Konstantin Komelin commentedComment #36
Niremizov commentedOk Pierre, I would place required code lines here: https://www.drupal.org/node/1830042 or right here https://www.drupal.org/node/2448311 - And than you could edit it as you wish.
(This would happen on this or next week.)