Bot abuse for #2099131: Use #pre_render pattern for entity render caching.

CommentFileSizeAuthor
#41 interdiff.txt3.5 KBeffulgentsia
#41 pre-render-2099131-216-testfix1.patch143.3 KBeffulgentsia
#40 interdiff.txt1.37 KBWim Leers
#40 pre-render-2099131-200-testfix2.patch145.18 KBWim Leers
#38 interdiff.txt889 bytesWim Leers
#38 pre-render-2099131-200-testfix1.patch144.94 KBWim Leers
#36 interdiff.txt2.66 KBWim Leers
#36 entity_render_build_36.patch114.67 KBWim Leers
#33 interdiff.txt25.69 KBWim Leers
#33 entity_render_build_33.patch114.55 KBWim Leers
#31 interdiff.txt2.48 KBWim Leers
#31 entity_render_build_31.patch97.44 KBWim Leers
#30 interdiff.txt755 bytesWim Leers
#29 entity_render_build_29.patch94.28 KBWim Leers
#27 entity_render_build_27.patch94.58 KBWim Leers
#25 entity_render_build.patch94.59 KBcatch
#23 entity_render_build.patch97.75 KBcatch
#21 2099131-123.patch84.23 KBcatch
#20 2099131-123.patch82.95 KBcatch
#18 2099131-114.patch83.47 KBcatch
#15 2099131-remove-build-defaults.patch81.49 KBcatch
#13 2099131-remove-build-defaults.patch81.5 KBcatch
#10 2099131-clean-up.patch78.73 KBcatch
#9 2099131-remove-build-defaults.patch78.73 KBcatch
#6 2099131-remove-build-defaults.patch76.96 KBcatch
#5 2099131-remove-build-defaults.patch76.96 KBcatch
#3 2099131-remove-build-defaults.patch77.59 KBcatch
2099131-remove-build-defaults.patch77.57 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2099131-remove-build-defaults.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
2099131-remove-build-defaults.patch77.59 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2099131-remove-build-defaults.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
2099131-remove-build-defaults.patch76.96 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
2099131-remove-build-defaults.patch76.96 KB

The last submitted patch, 5: 2099131-remove-build-defaults.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: 2099131-remove-build-defaults.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
2099131-remove-build-defaults.patch78.73 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
2099131-clean-up.patch78.73 KB

The last submitted patch, 9: 2099131-remove-build-defaults.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 10: 2099131-clean-up.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
2099131-remove-build-defaults.patch81.5 KB

Status: Needs review » Needs work

The last submitted patch, 13: 2099131-remove-build-defaults.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
2099131-remove-build-defaults.patch81.49 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: 2099131-remove-build-defaults.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
2099131-114.patch83.47 KB

Status: Needs review » Needs work

The last submitted patch, 18: 2099131-114.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
2099131-123.patch82.95 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
2099131-123.patch84.23 KB

The last submitted patch, 20: 2099131-123.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
entity_render_build.patch97.75 KB

WIP for removing $entity->content

Status: Needs review » Needs work

The last submitted patch, 23: entity_render_build.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
entity_render_build.patch94.59 KB

Status: Needs review » Needs work

The last submitted patch, 25: entity_render_build.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs work » Needs review
FileSize
entity_render_build_27.patch94.58 KB

Straight reroll, chasing HEAD.

Status: Needs review » Needs work

The last submitted patch, 27: entity_render_build_27.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs work » Needs review
FileSize
entity_render_build_29.patch94.28 KB

This should fix many (if not most) exceptions.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
FileSize
interdiff.txt755 bytes

Forgot the (ridiculous) interdiff. :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
FileSize
entity_render_build_31.patch97.44 KB
interdiff.txt2.48 KB

This should also help quite a bit: fixes position of node links and unbreaks rendering of comments.

The last submitted patch, 29: entity_render_build_29.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
FileSize
entity_render_build_33.patch114.55 KB
interdiff.txt25.69 KB

And another one that should help significantly: fixes all hook_entity_view(), hook_entity_view_alter() and friends' hook implementations and documentation. (Those "friends": the node-, comment-, taxonomy term- and user-specific variants of them.)

The last submitted patch, 31: entity_render_build_31.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 33: entity_render_build_33.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs work » Needs review
FileSize
entity_render_build_36.patch114.67 KB
interdiff.txt2.66 KB

Looking at #31, #33 should be *almost* green. I think this small addition will make it completely green.

… and when I wanted to post this, #33 had just come back as very red. The problem is that I renamed a few things for consistency and forgot to include that part in the patch.

Hopeful this one will be green!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Hurray, green!

#36 is re-posted to the main issue at #2099131-128: Use #pre_render pattern for entity render caching.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
FileSize
pre-render-2099131-200-testfix1.patch144.94 KB
interdiff.txt889 bytes

New problem, see #2099131-199: Use #pre_render pattern for entity render caching and the few preceding patches.

This is an attempt to fix that last test failure. I suspect something is wrong with testbot's cache tag invalidation.

Status: Needs review » Needs work

The last submitted patch, 38: pre-render-2099131-200-testfix1.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs work » Needs review
FileSize
pre-render-2099131-200-testfix2.patch145.18 KB
interdiff.txt1.37 KB

This should be the one.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
FileSize
pre-render-2099131-216-testfix1.patch143.3 KB
interdiff.txt3.5 KB

I'm reviewing #2099131-216: Use #pre_render pattern for entity render caching and don't get why our cache tag collection is incompatible with elements generated in #pre_render. Curious what tests fail when we remove the workaround. Interdiff is relative to that patch.

Status: Needs review » Needs work

The last submitted patch, 41: pre-render-2099131-216-testfix1.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Closed (works as designed)

I assume this is no longer needed as the issue being tested is fixed.