Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The title says it.
Steps to test
- clean install of 8.x
- drush dl devel -y
- drush en devel_generate -y
- drush genc --types=page 13
- add new block via comment #6 or #7
Comment | File | Size | Author |
---|---|---|---|
#48 | vdc-2020393.patch | 19.61 KB | dawehner |
#37 | vdc-2020393.patch | 20.26 KB | dawehner |
#19 | views-recent-content.png | 3.61 KB | oadaeh |
#13 | Screen Shot 2013-07-29 at 4.03.53 PM.png | 14.4 KB | bdone |
#8 | 2020393-7-auth-user.png | 248.14 KB | bdone |
Comments
Comment #1
oadaeh CreditAttribution: oadaeh commentedI don't want to hold anyone up who may also be working on this, but I have started this, and I will have patch options as both a display of the curent admin/content view, and as its own view later today.
Comment #2
oadaeh CreditAttribution: oadaeh commentedForgot the tag.
Comment #3
bdone CreditAttribution: bdone commented@oadaeh: still actively working on this? i'd like to try a pass, if you wouldn't mind.
Comment #4
oadaeh CreditAttribution: oadaeh commented@bdone: I haven't had the time available to do anything with this for the past two or three weeks, and I'm sure what I did do would need to be updated to the current state of core, so go for it.
Comment #5
bdone CreditAttribution: bdone commentedComment #6
bdone CreditAttribution: bdone commenteda few questions to get started...
steps to enable this block:
Comment #7
bdone CreditAttribution: bdone commentedalternate patch to add a block display to the existing "content" view, per comment #6 bullet 2.
steps to enable this block:
Comment #8
bdone CreditAttribution: bdone commentedadding screenshots for #2020393-7: Convert "Recent content" block to a View...
as user 1:
as anonymous:
Comment #9
dawehnerThank you very much on working on this issue.
views.view.content.yml is the admin view (admin/content/node) so I would suggest to create a separate view for the block.
Comment #10
dawehnerWe can now override the items per page, let's get this issue up to speed again.
Comment #11
bdone CreditAttribution: bdone commentedthis still needs work, but currently adds the following:
how should access checks for the "More link" to /admin/content be handled? it yields access denied for users without "access content overview". the non-views block used...
Comment #12
bdone CreditAttribution: bdone commentedregarding more links access, let's address that separately in #2053015: Add user access checks to 'more' link.
Comment #13
bdone CreditAttribution: bdone commented@dawehner, thank you for pointing out the option in #10. the patch in #11 works well with it, because it's a default.
Comment #14
dawehnerI would personally say that removing the real more link here is ok, though yeah this needs feedback.
Currently on the recent content block there is a "more" link to admin/content which for sure needs an access check. Views does not have the concept of access check for the read more link.
There are three opportunities:
Comment #15
dawehnerAdd bojhan for an oppinion.
Comment #16
Bojhan CreditAttribution: Bojhan commentedI don't think it makes a whole lot of sense to include a link that goes to admin.
We can add a read more link but ideally that is an actual page that lists the recent content (somewhat like /node). It is what I would expect, and it could be a page view under this view. Given that this is the only block that does this, I think its up to committers if they really think its needed. I don't think so.
Comment #17
dawehnerUploading the actual patch file.
Comment #19
oadaeh CreditAttribution: oadaeh commentedUpdated patch.
I also removed the node block test that was failing (due to the block being removed).
A screen shot is attached, too.
Comment #20
oadaeh CreditAttribution: oadaeh commentedUnassigning.
Comment #20.0
oadaeh CreditAttribution: oadaeh commentedbdone: adding steps for manual tests
Comment #21
dawehnerJust a simple rerole.
Comment #23
pcambraNot sure why the class SyndicateBlock is being removed in #21, here's a reroll without that
Comment #24
dawehnerUps, I am sorry for that.
Comment #25
dawehnerback to RTBC
Comment #26
webchickI left a big-ass review of a sister issue at #2020399-54: Convert "Who's online" block to a View, much of which may apply here, except...
I'm not even getting to step 1 in my review, because the block is not showing up in the block listing, even after a fresh install. :( Can anyone else reproduce?
Comment #27
webchickNo longer applies. Would be great to get into the next alpha though, so tagging.
Comment #28
dawehnerjust a straight reroll.
Comment #29
jibranBack to RTBC.
Comment #30
dawehnerdoh.
Comment #32
webchickDoing testbot's job for it...
Comment #33
olli CreditAttribution: olli commented30: vdc-2020393.patch queued for re-testing.
Comment #34
olli CreditAttribution: olli commentedI think this is not needed/used anymore.
Can we set the more link to "No"?
Instead of removing this test completely, could we change it to test the views block?
Removing this does not seem related to me.
Comment #35
dawehnerWe need this for the more link to point to "admin/content".
As before, this was clearly part of the original code:
Okay, let's try to keep this test coverage.
Comment #36
olli CreditAttribution: olli commentedRight, I misunderstood #14 / #16. Simplytesting #35: the link is not rendered and editing link display show that the link url is empty..?
Comment #37
dawehnerRerolled and opened a follow up after some discusion with xjm: #2162073: Switch the recent content block to use a list instead of a table, matching recent comments block
Comment #38
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)
Comment #39
dawehner37: vdc-2020393.patch queued for re-testing.
Comment #40
jibranSeems like div structure has changed.
Comment #41
dawehnerSo? Views is adding additional divs, that is no problem. If it is, fuckoff.
Comment #42
andypostSuppose this should not be a straight conversion because usability and accessibility issues are closed|postponed on this
We have no dashboard now, please drop this useless links, as was suggested in #849670: Recent content block usability and #2162073: Switch the recent content block to use a list instead of a table, matching recent comments block
Is there a way to add this via views?
Comment #43
dawehnerRegarding 2) No there is not and jessebeach was 100% okay with removing them.
You can figure out later how we replaced this table by some other thing, though we have tests for that, which would blow up the patch and make the freaking thing harder to review.
Comment #44
klonosComment #45
jibranhehe. Sorry to offend you but I was just pointing it. And TBH it is not an issue.
Comment #46
olli CreditAttribution: olli commentedNice work with the test, thanks!
I could not see the more link in #36.
Comment #47
olli CreditAttribution: olli commented.. and does not apply anymore.
Comment #48
dawehnerRerolled.
Comment #49
dawehner48: vdc-2020393.patch queued for re-testing.
Comment #51
jibran48: vdc-2020393.patch queued for re-testing.
Comment #52
damiankloip CreditAttribution: damiankloip commentedLooks good!
Comment #53
webchickCool, validated that this does show up now. :) The block kinda looks like crap, but that's what HEAD looks like too. (I think this block was originally designed for the dashboard.)
Committed and pushed to 8.x. Thanks!