Views exposed autocomplete + ajax view = form submit happens too early

Can you rebuild this view on a normal english drupal installation so we could try to reproduce the bug and based on this fix the bug?

Everytime an issue is easy to reproduce the bug get's fixed much faster :)

Can you also please export the view and attach it here? Thanks!

$handler->display->display_options['filters']['field_author_tid']['id'] = 'field_author_tid';
$handler->display->display_options['filters']['field_author_tid']['table'] = 'field_data_field_author';
$handler->display->display_options['filters']['field_author_tid']['field'] = 'field_author_tid';
$handler->display->display_options['filters']['field_author_tid']['value'] = '';
$handler->display->display_options['filters']['field_author_tid']['exposed'] = TRUE;
$handler->display->display_options['filters']['field_author_tid']['expose']['operator_id'] = 'field_author_tid_op';
$handler->display->display_options['filters']['field_author_tid']['expose']['label'] = 'Author';
$handler->display->display_options['filters']['field_author_tid']['expose']['operator'] = 'field_author_tid_op';
$handler->display->display_options['filters']['field_author_tid']['expose']['identifier'] = 'field_author_tid';
$handler->display->display_options['filters']['field_author_tid']['reduce_duplicates'] = 0;
$handler->display->display_options['filters']['field_author_tid']['vocabulary'] = 'authors';
$handler->display->display_options['filters']['field_author_tid']['error_message'] = 1;

The problem here is that you would have to create the fields manually and make some mistakes there as well.
Additonal this doesn't improve the motiviation to focus on this issue.

So the problem is probably that the focus is not on the autocomplete but on the actual submit element.

The prober fix would be perhaps that drupal autocomplete set's the focus manually

Hey I have the similar issue! Any update or workaround to it?

Same issue here, I tried to add autocomplete to 'tlp_full_name_value' exposed filter in hook_form_views_exposed_form_alter, autocomplete works ok, but when I select a value from autocomplete popup and hit enter, the form is automatically submitted and the selected value isn't used. After ajax load in filter is not selected value but original value. For example I write 'adm' and autocomplete suggest in popup 'Administrator' I select this value and hit enter, after ajax load the value in filter is automatically changed back to 'adm'. I think problem is that the submit is processed before set of the selected value in the popup.

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tl_user_form_views_exposed_form_alter(&$form, &$form_state, $form_id) {
  if ($form['#id'] == 'views-exposed-form-partner-admin-block-partnership-requests' ||
      $form['#id'] == 'views-exposed-form-partner-admin-block-partner-staff-requests' ||
      $form['#id'] == 'views-exposed-form-partner-admin-page') {
    $form['tlp_full_name_value']['#autocomplete_path'] = 'ajax/autocomplete/name';
  }
}

Exported view code: http://pastebin.com/Tx2Esr9k

Edit issue settings for my comment #1264794-12: Views exposed autocomplete + ajax view = form submit happens too early.

There is a cTools patch that fixes this: https://www.drupal.org/node/1708438

Unfortunately came across this issue on a project I'm currently working on. The solution I found was to call Drupal.autocompleteSubmit (in autocomplete.js) within Drupal.ajax.prototype.beforeSerialize (in ajax.js) in order to populate the textbox BEFORE the form is serialized. This solved the issue for me, but doesn't feel like an ideal solution. If anyone has a better suggestion I'm all ears.

@pcrats33: Similar problem and nice patch, but it does not fix this one.

@Drif.io is correct; the problem is a missing trigger of Drupal.autocompleteSubmit when ajax is enabled in a view. Well, autocomplete.js, binds this handler to the form submit event:

$($input[0].form).submit(Drupal.autocompleteSubmit);

However, when ajax is enabled for a view, this event is not fired, and Drupal.autocompleteSubmit should be fired for form input/button with type 'submit' click events. So, this bug can either be fixed from the autocomplete perspective (where the autocompleteSubmit should be also bound to the submit button/input click event), or from the views perspective (where form submit event should be triggered upon ajax submission). I am not sure which is the most proper solution, though, hence not providing a patch or altering the Project value of this issue.

I solved my problem, via a custom js file of my own that only does the following:

Drupal.behaviors.autocompletefix = {
		attach: function (context, settings) {
			$("form[id^=[my-custom-form-id]").find("[type=submit]").click(Drupal.autocompleteSubmit);
		}
	};

The tricky part, is that this js file should be included (therefore executed) after 'misc/autocomplete.js' and before 'views/js/*.js' files. I managed to do that by implementing hook_js_alter; I added a new entry for my custom js file with the same group and scope as 'misc/autocomplete.js' and a slightly bigger weight.

This is definitely not the ideal solution, but it feels better that overriding Drupal.ajax.prototype.beforeSerialize

I decided to move my version of solution into the separate ticket for Core — #2785283: Enter key press in autocomplete results lead to ajax form submission.
Maybe will be useful for someone.

I can reproduce this issue too. An easy way to see it is to make a view of nodes and an exposed filter on "Author uid". If AJAX is disabled and you type "ad" and arrow key down to "admin" and press enter, the autocomplete simple injects "admin" and doesn't submit. But if AJAX is enabled, it will put "ad" into the text field and submit the form.

The CTools patch referred to in #14 doesn't actually fix this for me :-/

The core patch in #17 does work in my testing! However, getting that included in core will be tough. :-/ If there's a way to fix that on the Views end, it'd be better because it'd be easier to get it included in core

Here's a patch that fixes this from Views and works in my limited testing

And for those who are on Views 3.18 here's a re-rolled patch against the last release, since the current -dev changes how the code in the patched file is indented.

However, don't review/merge this patch! Review/merge the one on #21!

reviewed code, looks good.

On Views 7.x-3.18 the patch has given:

patch < views-ajax-autocomplete-1264794-21.patch 
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/js/ajax_view.js b/js/ajax_view.js
|index 51fb806..c3e5bb9 100644
|--- a/js/ajax_view.js
|+++ b/js/ajax_view.js
--------------------------
File to patch: js/ajax_view.js
patching file js/ajax_view.js
Hunk #1 FAILED at 90.
1 out of 1 hunk FAILED -- saving rejects to file js/ajax_view.js.rej

Also after manually applying the patch it didn't fix the problem for me, so probably my use case is different.

@nickonom try this instead:
download/copy the patch file into the views folder and then:
patch -p1 --dry-run < views-ajax-autocomplete-1264794-21.patch

if the --dry-run works (test applying the patch)
then without the --dry-run flag out and actually apply the patch as follows:
patch -p1 < views-ajax-autocomplete-1264794-21.patch

@nickonom was trying with Views 3.18, for which there is a different patch on #22! That one should apply cleanly.

Committed. Thanks all.

Since that change https://www.drupal.org/project/search_api_autocomplete does not work anymore. I have not fully understood why. Maybe someone can give me a hint how to fix.

@semanthis to revert the commit locally, run the above patch in reverse (using the -R flag)

cd sites/all/modules/contrib/views
wget https://www.drupal.org/files/issues/views-ajax-autocomplete-1264794-21-3.18.patch
patch -p1 -R < views-ajax-autocomplete-1264794-21-3.18.patch

or if you don't have wget you can use curl like this

cd sites/all/modules/contrib/views
curl https://www.drupal.org/files/issues/views-ajax-autocomplete-1264794-21-3.18.patch > views-ajax-autocomplete-1264794-21-3.18.patch
patch -p1 -R < views-ajax-autocomplete-1264794-21-3.18.patch

Thank you, joseph.olstad that's what I did. I wrote a ticket for Search API autocomplete, the solution has to happen there. I just have not time at the moment to digg too deep into the problem, so I just reverted the commit.

already was referenced, so removing extra reference, link here:
#2977790: Since Views 3.20 Autocomplete does not work with ajax-views

I know this issue is merged and closed, but I want to leave a warning here for anyone trying to override how autocomplete selects or submit work.
Please check https://www.drupal.org/project/drupal/issues/309088#comment-12790476