Multiple issue fixing in a single patch [#2032189]

Please review and apply this patch.

I merge multiple issue to make this module works out-the-box without any issue.

I list the all issues so you can review this patch and then update the others ones.

I add extras Drupal CS issue. (not completely) I believe the current 1.0 "stable" release it's a joke, you must apply this patch ASAP.

I know small patch help for better review, but in this case, there it's patch in the issues and you did not apply none of them, so, now you have yo test this huge patch, and if you don't want to apply it, then other people will find this only patch really sexy because the 1.0 version does not work well.

Comment	File	Size	Author
#4	multiple-issues-fixing-single-patch-2032189-4.patch	52.76 KB	killua99
#3	multiple-issues-fixing-single-patch-2032189-3.patch	25.6 KB	killua99
#2	multiple-issues-fixing-single-patch-2032189-2.patch	26.89 KB	killua99
	multiple-issues-fixing-single-patch-0.patch	23.42 KB	killua99

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

killua99 CreditAttribution: killua99 commented 1 July 2013 at 11:24

Status:

Active

» Needs review

Now changing the status.

Comment #2

killua99 CreditAttribution: killua99 commented 1 July 2013 at 11:39

File	Size
multiple-issues-fixing-single-patch-2032189-2.patch	26.89 KB

Reroll with the patchs

#1220408: tcpdf is trying to write in /sites/all/libraries/tcpdf/cache
#1986120: Replacement patterns for included view's arguments not shown

Bad timing.

Comment #3

killua99 CreditAttribution: killua99 commented 1 July 2013 at 12:06

File	Size
multiple-issues-fixing-single-patch-2032189-3.patch	25.6 KB

Reroll another patch. Completely HEAD with the current 7.x and with the others patchs apply.

Comment #4

killua99 CreditAttribution: killua99 commented 2 July 2013 at 08:50

File	Size
multiple-issues-fixing-single-patch-2032189-4.patch	52.76 KB

Reroll with extra patchs.

#2032863: Hide fields if they are empty
#1886066: Print views header and footer in PDF

Ready to apply to HEAD 7.x

Comment #5

Simon Georges CreditAttribution: Simon Georges commented 2 July 2013 at 09:42

@killua, I'm fine with you integrating everything in your patch to ease integration in a makefile of yours, but please stop changing status of every other issue in the queue. It's far easier for me to review one (small) patch after the other.
What's more, you're merging bugfixes with feature requests, it's getting hard for me to follow everything... I'll try to give some more love / time to the module in the upcoming weeks, but please let me handle the issue queue, instead of linking your patch in every issue.
I totally appreciate your work, especially reviewing issues to confirming the patch are working, it allows me to integrate them sooner rather than later, but it's quite certain I won't commit your patch directly into the module, it's too hard to review as it is.

Comment #6

killua99 CreditAttribution: killua99 commented 2 July 2013 at 10:12

I understand this patch it's madness, and hard to review. I don't pretend this patch to be commited (or yes who knows) this patch it's a helper for who wants an unique fast patch to handle *all* this issue queue list you have.

I Just change the status to RTBC, not fixed or closed, I just test the patch and see if that patch don't cause any PHP warning/notice and don't break my live/production site. So I think this helps you the attend more fast the issue. I change the status to RTBC and add a link for other not for you. I mean, you have to test each patch, and commit them one by one. But before that others guys want to use this module. But the 1.0 stable, it's not so stable as you believe.

So I don't want to be rude with you, just try to help you reviewing the patchs, and add this kind of FULL fixed for others not for you directly, because it mix like you say bug with feature request, but cleaver feature request.

Regards.

Comment #7

Simon Georges CreditAttribution: Simon Georges commented 2 July 2013 at 14:50

Ok, let's try to bring the module to a good state.
@killua99, you seem to be using the module more than me, would you be interested in helping the maintenance of the module (issue triaging, patch review, as well as commit access, maybe)?