drupal_container() is deprecated, and all calls in the contact module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

CommentFileSizeAuthor
#3 2003596-replace-drupal_container-contact-module.patch1.48 KBddrozdik
#1 2003596-1.patch1.49 KBebeyrent
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ebeyrent’s picture

ebeyrent CreditAttribution: ebeyrent commented
Status: Active » Needs review
FileSize
2003596-1.patch1.49 KB

Status: Needs review » Needs work

The last submitted patch, 2003596-1.patch, failed testing.

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik commented
Assigned: ebeyrent » ddrozdik
Status: Needs work » Needs review
Issue tags: +CodeSprintUA
FileSize
2003596-replace-drupal_container-contact-module.patch1.48 KB

This patch created during Code Sprint UA.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community

#3 looks good
if bot green - RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b96a264 and pushed to 8.x. Thanks!

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik commented
Status: Fixed » Closed (fixed)