CKEditor fails to render customized toolbar [#1905022]

I tried #1890502-84: WYSIWYG: Add CKEditor module to core on Firefox and Chrome. In both cases, when I add the U (underline) button to the toolbar for the Full HTML format, then when I go to edit some text in that format, the toolbar does not include that button.

I breakpointed Drupal.editors.ckeditor.attach() and found that the Underline button item does exist as expected in format.editorSettings passed to CKEDITOR.replace(), so I don't know if it's a bug with CKEditor itself, or if there's some other incompatibility in what's passed.

Comment	File	Size	Author
#4	ckeditor_underline_doesnt_work-1905022-4.patch	1.67 KB	Wim Leers
#4
#3	ckeditor_underline_doesnt_work-1905022-3-do-not-test.patch	940 bytes	Wim Leers
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

effulgentsia CreditAttribution: effulgentsia commented 1 February 2013 at 04:16

Issue tags:

+CKEditor in core

Tagging

Comment #2

effulgentsia CreditAttribution: effulgentsia commented 1 February 2013 at 04:28

Priority:

Major

» Critical

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 1 February 2013 at 07:34

File	Size
ckeditor_underline_doesnt_work-1905022-3-do-not-test.patch	940 bytes

This is because CKEditor loads its default config.js file with the default config, which contains:

	config.removeButtons = 'Underline,Subscript,Superscript';

In previous iterations of the patch at #1890502: WYSIWYG: Add CKEditor module to core, we explicitly unlisted these buttons to be removed.

I consulted with the wwalc of the CKEditor guys, and attached is a patch that implements the proper way to ignore the default config file, and only listen to our instructions instead.

Comment #4

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 1 February 2013 at 13:32

Assigned:

Unassigned

» Wim Leers

File	Size
ckeditor_underline_doesnt_work-1905022-4.patch	1.67 KB

Now with updated tests.

Comment #5

effulgentsia CreditAttribution: effulgentsia commented 2 February 2013 at 00:19

Status:

Postponed

» Closed (duplicate)

Thanks. Since #1890502: WYSIWYG: Add CKEditor module to core needed a reroll anyway, I merged this into it.

Comment #6

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 2 February 2013 at 18:08

Excellent — thanks!

Comment #7

Anonymous (not verified) CreditAttribution: Anonymous commented 8 February 2016 at 15:15

Issue summary:

View changes

Custom buttons still don't show up. I added the buttons for left, right, centered or justified text alignment but the buttons don't show up. I did try to clear the cache but without a change.