I tried #1890502-84: WYSIWYG: Add CKEditor module to core on Firefox and Chrome. In both cases, when I add the U (underline) button to the toolbar for the Full HTML format, then when I go to edit some text in that format, the toolbar does not include that button.

I breakpointed Drupal.editors.ckeditor.attach() and found that the Underline button item does exist as expected in format.editorSettings passed to CKEDITOR.replace(), so I don't know if it's a bug with CKEditor itself, or if there's some other incompatibility in what's passed.

CommentFileSizeAuthor
#4 ckeditor_underline_doesnt_work-1905022-4.patch1.67 KBwim leers
#3 ckeditor_underline_doesnt_work-1905022-3-do-not-test.patch940 byteswim leers

Comments

effulgentsia’s picture

effulgentsia commented
Issue tags: +CKEditor in core

Tagging

effulgentsia’s picture

effulgentsia commented
Priority: Major » Critical
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new ckeditor_underline_doesnt_work-1905022-3-do-not-test.patch940 bytes

This is because CKEditor loads its default config.js file with the default config, which contains:

	config.removeButtons = 'Underline,Subscript,Superscript';

In previous iterations of the patch at #1890502: WYSIWYG: Add CKEditor module to core, we explicitly unlisted these buttons to be removed.

I consulted with the wwalc of the CKEditor guys, and attached is a patch that implements the proper way to ignore the default config file, and only listen to our instructions instead.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
StatusFileSize
new ckeditor_underline_doesnt_work-1905022-4.patch1.67 KB

Now with updated tests.

effulgentsia’s picture

effulgentsia commented
Status: Postponed » Closed (duplicate)

Thanks. Since #1890502: WYSIWYG: Add CKEditor module to core needed a reroll anyway, I merged this into it.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Excellent — thanks!

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes

Custom buttons still don't show up. I added the buttons for left, right, centered or justified text alignment but the buttons don't show up. I did try to clear the cache but without a change.

Anonymous’s picture

Anonymous (not verified) commented

Hm... it looks like for some buttons the allowed HTML tags are added automatically and for some they are not. Not sure which tags I should add for the mentioned buttons but after disabling the limit the buttons are showing up.

Anonymous’s picture

Anonymous (not verified) commented

For anyone else having issues with the mentioned buttons make sure that you have <p class> as an allowed tag and attribute.

mgifford’s picture

mgifford
he/him
Primary language English
commented

@furious_snail This issue has been closed.

It would be best to start a new issue and link both to this one and #1890502: WYSIWYG: Add CKEditor module to core

Thanks!