Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow up from #916388-154: Convert menu links into entities
shortcut_update_8000()
should not use menu_link_save()
and menu_load_links()
Comment | File | Size | Author |
---|---|---|---|
#6 | 1899682-interdiff-6.txt | 666 bytes | andypost |
#6 | 1899682-shortcut-upgrade-6.patch | 4.6 KB | andypost |
#5 | 1899682-shortcut-upgrade-5.patch | 4.6 KB | andypost |
#4 | 1899682-interdiff-4.txt | 2.93 KB | andypost |
#4 | 1899682-shortcut-upgrade-4.patch | 3.74 KB | andypost |
Comments
Comment #1
andypostA part of #916388-155: Convert menu links into entities #155
Comment #2
andypostAdded full test coverage and proper upgrade path
Comment #3
dawehnerMissing empty line at the beginning and the end of the class
Shouldn't we put this test data into a .database.php file? I'm not sure, but at least make a new line after db_insert(), this would improve the readability.
What about using $set->uuid() ?
I'm wondering whether a more indirect test should be done, so removing the manifest files would be easier, but yeah let's keep in there for now.
Comment #4
andypost@dawehner thanx for review!
Here's a fixed version. Also moved test file to proper place
I've checked the existing tests for manifests again and they are the same in
FieldUpgradePathTest
andContactUpgradePathTest
Comment #5
andypostMessed the database file
Comment #6
andypostFinally last copy/paste error
Comment #7
andyposttaggin
Comment #8
sunLooks good to me. Hopefully, testbot will agree.
TBH, I could live without the additional upgrade path test. It performs yet another upgrade path of a full-blown Standard installation, which includes like... a gazillion of modules + updates.
By now, we're probably duplicating the basic Standard profile upgrade path test in a dozen of tests already. All of them are slowing down the total test suite time. :(
Thus, I wouldn't mind if that new test would be left out of the commit.
Comment #9
andypost@sun I filed #1899858: Consider a proper place for upgrade test
Once we move all upgrade tests in one folder we can simply merge them in one tremendous test so minify the count of installs
Comment #10
catchCommitted/pushed (including the test, can't have too many upgrade path tests), to 8.x.