Closed (fixed)
Project:
Drupal.org Testing
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
15 Jun 2007 at 05:10 UTC
Updated:
14 Jul 2012 at 23:18 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwStill don't understand why drupal_execute() isn't hitting the full form in all its glory, and therefore, why the taxonomy terms have to be saved independently, but here's an initial patch.
Comment #2
hunmonk commentedit is. that may have been one of the toughest problems to track down i've ever seen. i'll try to explain what's happening here...
the code above is inherently flawed. _project_get_vid() automagically creates the vocabs if they don't exist, then when taxonomy_get_tree() is called immediately after, it caches the *empty* tree for the newly created vocab (static $children). any future calls to project_use_taxonomy() in the same page load will be FALSE -- like
if (project_use_taxonomy() && $node->project_type) {, which is in _project_save_taxonomy(), which is called from project_project_nodeapi().the fun all starts in devel_enable(), which calls _block_rehash(), which then eventually calls hook_block(), menu_block() fires up a _menu_build(), which gets you to project_menu($may_cache) -- and there's the first call to project_use_taxonomy() -- whew!
i'll leave it to you to file a bug against project module, since i'm not really sure how you want to handle it...
this code will need to be cleaned up once that bug is fixed.
Comment #3
moshe weitzman commentedthat sounds like fun bug! you can remove that block_rehash() call from devel if you wish. i don't think it does anythng anymore.
Comment #4
aclight commentedHere's a reroll to eliminate offset.
I also added the documentation project to the array.
I tested this and it seems to work well. I also modified the comment about why drupal_execute() isn't fully effective here.
Comment #5
dwwCool. Tested and committed to HEAD. Thanks.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #7
dwwdoh! except they're still enabled for releases. ;) I noticed this while testing #325444-20: Make usage statistics EVEN MORE visible. Not sure when I'll have a chance to work on this, so for now I'm setting this back to unassigned.
Comment #8
dwwComment #9
dwwCommitted to HEAD and D5