The menu_editor module has served me well on my own sites, but before I continue working towards an official 1.0 release, or adding more features, I would like to get some feedback from the community:
- Is this module needed and helpful?
- Are there important use cases that I missed to think about?
- Does it work?
- What are the most desired missing features?

If your feedback is just "ah yes, it's useful" or "i installed it, but I don't use it", that's totally fine.

Thanks!

CommentFileSizeAuthor
#15 Picture-4.jpg722.43 KBkarlkablisk2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yustos’s picture

I believe the module is really useful. But I have a problem - I don't see it in admin settings after I installed it.

donquixote’s picture

Look in the admin menu, there should be new items at
Site building > Menus > List menus > [menu name].

This takes you to the new "power edit" tab of that menu, which should look like the screenshot.

jshabazz’s picture

This module is very useful, would you consider combining it with the Menu Path autocomplete module http://drupal.org/project/mpac I have been using that with the mass content creator module to speed up building out site skeletons, and if we had the autocomplete added to your module it would be a real winner.

donquixote’s picture

That's a great idea :)
I hope it doesn't make the entire thing too heavy on client side. There can be a lot of these fields in a big menu!! So I guess I make it an optional submodule.

donquixote’s picture

I made the autocomplete work on my localhost, but I'm not really happy with it.
Drupal's built-in autocomplete only applies to one input field.

What we want is type the title in the title field with an autocomplete dropdown, but then if I select one of the autocomplete choices, I want the path to be inserted in the path input field, and the title in the title field. Then I want the focus to remain on the title field, so I can adjust the title if needed.

I'll see if it can be done - but it will be more than just the normal autocomplete.

austintnacious’s picture

Category: task » feature

Hi, I found your module after a search for "tabindex". . . I'm looking for a way to control the tabindex of all links on my pages.

Anyway, your module came up, I saw your request for feedback and I have frequently been annoyed by the amount of clicks and page refreshes needed to work with large navigation menus.

So I downloaded and installed Menu Editor.
I haven't done any real work with it yet but I really do like the idea and you definitely should keep going with it.

One problem for me though, which I also found with the content types overview module. . . while both of these modules are great enhancements to cluttered pages they both have and create layout issues, my site uses a custom theme based on "basic" with a fixed width, 3 column layout.

I'm assuming your module was developed in Garland, where you have a lot of space to play with.

On my site the power edit layout gets tangled up in my right hand sidebar.

So my question / feedback is have you considered taking an approach similar to the vertical tabs module?
I.e. load the whole list of menu items and editable properties but display only the menu link texts on a vertical column of tabs.
The user can quickly navigate through all the menu items AND edit each of them without constant page refreshes.
I'm not sure if you can combine the vertical tabs idea with drag and drop ordering but if you could then you'd have one of the most kick-ass modules IMHO.

Cheers!

donquixote’s picture

I developed and used the module with my own Zen sub-themes, and I know about the width issue.

The quickest solution for you is to disable the sidebar blocks in the admin area, giving more space for the main content. You can do that in the blocks settings (a lot of redundant work, if you have many blocks), or you can let your theme do it by itself. Or use an admin theme (that can be a sub-theme of your main theme, to make it look seamless).

If I would change the module, I think I would make a collapse/expand for table columns. Which could be a module of its own, that could work for other tables as well :)

jshabazz’s picture

I was thinking that might require that some autopath or URL aliasing was being used so that you can do the auto complete in the path field rather than in the title field. A lot of titles are too long to be menu entries, so it wouldn't be so bad to be able to type in menu titles, and then to be able to just type in a few characters from the title of the node to find the path, since the paths would already be taking advantage of the aliasing.

When you say the auto-complete only applies to one input field do you mean as in only one field type or only the active field. Maybe the autocomplete can apply to just the active field or did I miss it. I'd love to test the version you have your local machine if you want to post it as a developers version.

donquixote’s picture

See #666644: Path Autocomplete for Menu Editor.
I will post a zip there.

donquixote’s picture

@austintnacious (#6):
You can use Region Visibility to get rid of the sidebars for the admin area. I think this is the best solution.

Abdussamad’s picture

Version: 6.x-0.x-dev » 6.x-1.0

This is a very useful module. I just hate the fact that the default drupal menu editor didn't include a mass delete option. Your module does and its very helpful. I have just one request. Please include a javascript powered select all and deselect all checkbox.

Daniel Wentsch’s picture

This module is definately great. It can save you hours of clicking and waiting :)
Thanks a lot!

I found one little bug: if you add a new menu entry and assign a language to it, the language won't get saved and just stays "language neutral".

I think the language selection for menu entries is only shown when i18n module is installed, maybe that's why nobody seems to have notices yet.

donquixote’s picture

@wentsch:
I have not thoroughly tested this module with a multilanguage site. I suspect there is some more work waiting for me. I had some WTFs with the way the menu i18n currently works (without this module), and I was hoping that I could find a solution with this module.

@Abdussamad:
What is your use case for deleting all items in a menu? Is this really an everyday situation?

Daniel Wentsch’s picture

Hey donquixote,

just to let you know: I haven't experienced any other problem using Menu Editor on a multi-language site using i18n ;)

karlkablisk2’s picture

Category: feature » bug
Priority: Normal » Critical
FileSize
722.43 KB

This is a very needed program for creating menus quickly. I used it once and it saved me a LOT of time.

However i used it 2 times afterwards when I created new sites from scratch and one of the first things I did was create the menu list all in one shot something like 8 menus and some with sub categories underneath them. THey appear for the admin and probably signed in users but wont show to anonymous people.

This happened when i went to the power edit menu, clicked the MENU NAME, clicking edit yelided no change. and then put a name in the menu link title. If I DONT add any info and save it will appear for users.

How I know its a bug is if I go to it, and click edit, and save (I typed some content in the content box to test) It will appear for anonymous people but duplicate itself! I get 2 of the same menu.

I can't seem to get menus working on my new sites I create, it only worked that 1st time when I needed it for a site that was already started. I don't know what the problem is but theres a bug for sure I think. Hope you can get it!


I see a problem here, if I create the menus and go there for the first time as admin, it will prompt me to the edit page immediately, thats because the menu was created but there's no PAGE. I dont have a suggestion for how to remedy this, I guess its good anonymous people don't see it but I think this module could work a little better, maybe more options in the power menu creator.

Thanks,
- KKL

donquixote’s picture

@karlkablisk (#15)
Thanks for the feedback!
Could you create a seperate issue for the bug report?

Also I don't completely understand your problem description. From what I understand, these are two separate things - correct?

1. You did some work on a menu, then clicked save, and the menu was messed up. Or at least, it didn't look the way you expected it to look. Is this what happened? Can you explain in more detail what exactly you did, what you expected to happen, and what happened instead? (in the new thread, preferably)

2. The "create content" form.

if I create the menus and go there for the first time as admin, it will prompt me to the edit page immediately, thats because the menu was created but there's no PAGE.

That's exactly what's supposed to happen. There is no page, so you are invited to create it, if you have the permission.
However, I noticed that people often don't understand this concept in the first place, and ask me why they are seeing this page.

Some ideas I had to improve this work flow:
- Better explanation on the "create content" page, to avoid the confusion.
- An option to show an "under construction" page to users who don't have permission to see the "create content" form. Actually I hate the typical dead end links that end in an "under construction" page, and would rather show an empty menu. But if people want to have it, why not, make it optional.
- Tabs or other controls on the "create content" page, that allow to choose a different content type, or even delete or rename the menu item.

It could work like this:
- A new placeholder <under construction> would show a node page saying "under construction", but instead of the [edit] tab, you would see tabs for [create page], [create webform], etc. The active tab would be [under construction]
- The placeholders <new page> or <new webform> would show the same forms as they do now, but they would have tabs for [under construction], [create page], [create webform], etc.

One problem is that you would get really a lot of tabs, if you have many content types. So maybe it can be something else, instead of tabs.

EDIT:
The dev release (once the packaging script will run) does support a "" placeholder, that will link the menu item to an "under construction" page. This is useful for a site in a staging phase.

cjwhite’s picture

Category: bug » feature
Priority: Critical » Normal

Hi,
Thanks for the module which I find very useful.
What I would find especially useful is if a menu item can link to nothing e.g. #
I often find the top level doesn't have a useful page, and i'm creating one just because the menu system forces something to be there! E.g. a drop down menu where the main interest is what drops down - not the parent, which is really just a placeholder/container for the drop down second/third level etc
It may not be good design - but it would save time making up content or having a useless page when none is required
Thanks,
Chris

donquixote’s picture

@cjwhite (#17):
I completely agree with that.

However:
This module (menu_editor) does only provide a new way to manage the table contents of menu_links. There is nothing you could store in this table that would have the desired effect of providing a non-clickable text instead of a link. Everything stored in link_path needs to be either a valid sytem path, or an external URL, or "<front>". Even the placeholders that appear as "<new page>" are in fact valid system paths, just masked as "<new page>" for the admin interface.

One could try to do this on the theme layer, and automatically filter for a specific system path (like "menu/dead/link"), but there will probably remain some places that can't be changed that easily (think of breadcrumbs). From my experience, the menu system is not the most pleasant thing to work with.

Maybe if you send the entire page through a find-and-replace..

I think the desired functionality, if technically possible, would well deserve its own module. I would happily provide assistance for that in menu_editor, if someone would code this thing.

austintnacious’s picture

@cjwhite

Try Menu Firstchild for the non-click-able parent menu item. . .

cjwhite’s picture

@donquixote (#18), @austinacious
Many thanks for the suggestions. I'll use Menu Firstchild for now (which does at it suggests - links a parent to it's first child). And ponder creating a similar module which links a menu item to # in the future. (as my first module)
Cheers,
Chris

donquixote’s picture

@Abdussamad (#11)
"javascript powered select all and deselect all checkbox."

See
#702394-3: Snapshot/Beta Testing for Menu Editor 6.x-2.x
and help testing!

karlkablisk2’s picture

Thanks for the comments donquixote. Sorry it took me so long to get back. No one has had trouble with duplicate menus? This is my biggest hurdle for using this module and I've used it about 4 times now on different sites.

1. I create a bunch of menus
2. I go to the page and see the create a page screen (yeah it took me a while to realize why it didnt default to a blank page like when you normally make a page with nothing in the content feild. I think this is better than a construction page, just treat it like a page that was made with nothing in the content field.)
3. I enter any info I need in there and then poof, I have 2 of that menu.

SOMETIMES when I delete 1, (maybe 1 is original and the other one is the duplicate so its less important) then both go away. But other times only 1 disappears.

Also I've noticed some changes to 1 occur on both the duplicate and the original.

Sorry for putting this in this thread, im not on this site often I probably wouldn't find the issue again if I posted somewhere else lol. You can start one on this topic if you like.

- KKL

donquixote’s picture

@karlkablisk (#22):

"I create a bunch of menus".
"poof, I have 2 of that menu."
Do you actually create a bunch of menus, or a bunch of menu items in one and the same menu? To me it sounds like you are talking all about items, not about menus.

"yeah it took me a while to realize why it didnt default to a blank page like when you normally make a page with nothing in the content field."
The dev snapshot has a new placeholder, "<new>", which gives you exactly what you want - an "under construction" page with the title (to show to your clients, for instance). I am still thinking about a solution that would allow to customize this page.

----

I tried to reproduce this bug with the dev snapshot version, and I can't. It all works as expected.
Atm I don't have a site available that uses the 1.0 version.. maybe another day.
Could you try with the dev snapshot?

----

"You can start one on this topic if you like."
I think an issue like this would deserve at least one post from a person who has actually seen this bug, if it exists! (that would be you) If I can reproduce I will create the issue myself.

donquixote’s picture

I noticed that the module description page is growing too long.

Planned features

Item visibility: The core menu edit form uses the same routine to load menu items like any menu block. As an admin, however, you often want to see the complete menu, with items in all languages, and including broken items or items that would be hidden for you in a regular menu block.

Mutlilanguage: You often want to create "parallel" menu structures for different languages. For all untranslated nodes you want to link to the original version or hide that menu item completely. And to make things worse, some of the menu items don't link to nodes but to other things, which also want to be translated. In future versions of this module I would like to give you more control about the language of menu items.

Textarea for new items: This would allow your client to write a menu structure (consisting of page titles) in a text editor of his/her choice, structured by indentation, without ever touching the admin backend. You (the admin) paste that thing in a textarea, and the new structure is merged into the existing menu tree.

List orphan page nodes: Below the menu table, show a list of page nodes (or node types of your choice) that are not in any other menu, so you can drag them in as new menu items. The idea is that you can easily repair a broken structure, and keep track of nodes created without the <new page> trick.

donquixote’s picture

This thread is not as popular as I thought it could be. Closing this for now.

donquixote’s picture

Status: Active » Closed (fixed)