Is this cool for me to do?

CommentFileSizeAuthor
#313 10.1-3347291-combine-mega-e.patch303.75 KBsrishtiiee
#312 10.1-3347291-combine-mega-d.patch304.04 KBsrishtiiee
#311 10.1-3347291-combine-mega-c.patch303.7 KBtedbow
#310 10.1-3347291-combine-mega-b.patch304.04 KBtedbow
#309 10.1-3347291-combine-mega-a.patch304.12 KBtedbow
#308 3356894-to-2327883.patch199.09 KBtedbow
#307 10.1-3347291-combine-3358049-3358049-f.patch147.51 KBsrishtiiee
#306 10.1-3347291-combine-3358049-3358049-e.patch148.51 KBsrishtiiee
#305 10.1-3347291-combine-3358049-3358049-d.patch148.48 KBtedbow
#304 10.1-3347291-combine-3358049-3358049-c.patch146.21 KBtedbow
#303 10.1-3347291-combine-3358049-3358049-b.patch146.32 KBtedbow
#302 10.1-3347291-combine-3358049-3358049-a.patch146.08 KBtedbow
#300 10.1-3347291-combine-3358049-3358049.patch139.61 KBtedbow
#297 296693-10.1.x.patch35.54 KBtedbow
#296 296693-10.0.x.patch35.38 KBtedbow
#293 Screen Shot 2023-03-10 at 3.15.06 PM.png337.57 KBwim leers
#289 test.patch699 bytesYogesh Sahu
#287 3153168-29.patch96.65 KBadeshsharma
#286 test2.patch5.22 KBYogesh Sahu
#285 test1.patch5.22 KBYogesh Sahu
#277 2992445-11.patch2.48 KBsandeepsingh199
#267 2977515-phpcs-error.patch1.64 KBtedbow
#264 3041885-46_0-cast-no_request_time_fix.patch56.33 KBtedbow
#264 3041885-46_0-cast.patch58.19 KBtedbow
#263 3041885-49-cast.patch56.38 KBtedbow
#261 3041885-49-dataproviderg.patch11.27 KBtedbow
#260 3041885-49-cast_string.patch12.99 KBtedbow
#257 3041885-49-only_get.patch11.31 KBtedbow
#257 3041885-49-http-status1.patch59.87 KBtedbow
#255 3041885-49-http-status.patch59.86 KBtedbow
#252 3041885-49-http-json.patch59.34 KBtedbow
#250 3041885-49-debug-filename.patch58.11 KBtedbow
#248 3041885-49-debug2.patch58 KBtedbow
#246 3041885-49-debug.patch57.8 KBtedbow
#244 3041885-49-cronthrow.patch57.66 KBtedbow
#242 3041885-49-no_cache.patch57.28 KBtedbow
#240 3041885-49-msg_excep.patch57.43 KBtedbow
#238 3041885-49-1call_plus1.patch57.41 KBtedbow
#236 3041885-49-bool_fix.patch58.29 KBtedbow
#234 3041885-cache_data.patch59.52 KBtedbow
#233 3041885-delete_cache1.patch59.54 KBtedbow
#233 3041885-delete_cache.patch59.5 KBtedbow
#231 3041885-49-3113971e.patch98.55 KBtedbow
#229 3041885-49-delete_cache.patch58.59 KBtedbow
#228 3041885-49-fake_time_format.patch59.09 KBtedbow
#225 3041885-49-fake_time.patch58.23 KBtedbow
#225 3041885-49-2days-drupalget.patch58.13 KBtedbow
#222 3041885-49-2days.patch58.08 KBtedbow
#220 3041885-49-drupalci.patch58.08 KBtedbow
#218 3041885-46-encode.patch57.21 KBtedbow
#216 3041885-46-response.patch57 KBtedbow
#215 3041885-46-json-file.patch56.74 KBtedbow
#213 3041885-46-file_get_contents.patch54.89 KBtedbow
#211 3041885-46-what-emptys-test2.patch55.06 KBtedbow
#210 3041885-46-what-emptys-test1.patch55.11 KBtedbow
#209 3041885-46-what-emptys-test.patch55.14 KBtedbow
#207 3041885-46-exceptoins-test.patch54.75 KBtedbow
#205 3041885-46-endpoint-test.patch54.34 KBtedbow
#203 3041885-46-absolute-test.patch54.28 KBtedbow
#201 3041885-46-json-response-code-test.patch54.26 KBtedbow
#199 3041885-46-json-response-test.patch54.08 KBtedbow
#197 3041885-46-controller-test.patch53.93 KBtedbow
#195 3041885-46-empty-test.patch53.71 KBtedbow
#193 3041885-46-response--test.patch53.54 KBtedbow
#190 3041885-46-throwjson-test.patch55.59 KBtedbow
#190 3041885-46-getmsg_testt-test.patch55.57 KBtedbow
#188 3041885-46-assert_message_cnt-test.patch54.75 KBtedbow
#186 3041885-46-1method-test.patch54.65 KBtedbow
#184 3041885-46-send-test.patch58.26 KBtedbow
#182 3041885-46plus-test.patch58.26 KBtedbow
#180 3041885-46.patch57.41 KBtedbow
#179 3041885-43-1test.patch57.43 KBtedbow
#176 3119761-5-set-keys.patch14.56 KBtedbow
#176 3119761-5-set-each-case.patch14.56 KBtedbow
#175 3119761-5-nonowdoc.patch13.33 KBtedbow
#175 3119761-5-dumb.patch14.48 KBtedbow
#175 3119761-5-del-lines.patch14.23 KBtedbow
#174 3119761-5.patch14.46 KBtedbow
#173 3119761-5.patch14.53 KBtedbow
#172 3119761-5.patch16.12 KBtedbow
#171 3119761-5.patch16.12 KBtedbow
#170 3119761-5.patch16.12 KBtedbow
#169 3119761-5.patch16.08 KBtedbow
#168 3005229-100.patch62.21 KBtedbow
#166 3095755-12.patch2.71 KBtedbow
#165 3074993-only-supported_branches.patch105.82 KBtedbow
#163 3095755-force-fail.patch721 bytestedbow
#161 no-version_patch-version_extra.patch2.84 KBtedbow
#160 3062281-101-simple5-more-tests.patch37.25 KBtedbow
#159 3062281-101-simple5.patch37.34 KBtedbow
#157 3062281-101-simple4.patch37.34 KBtedbow
#155 3062281-101-simple3.patch37.38 KBtedbow
#153 3062281-101-simple2.patch37.35 KBtedbow
#151 3062281-101-simple.patch37.25 KBtedbow
#149 3062281-96-tester.patch35.16 KBtedbow
#147 3070521-58-test.patch26.82 KBtedbow
#146 2631202-tester.patch195.09 KBtedbow
#145 Screenshot 2019-09-20 11.47.01.png63.99 KBtedbow
#144 2313917-follow-up.patch5.61 KBtedbow
#143 2313917-simpletest2.patch30.67 KBtedbow
#142 2313917-simpletest.patch30.7 KBtedbow
#141 locale-no-filter-core.patch2.37 KBtedbow
#139 locale-break.patch2.17 KBtedbow
#137 2313917-switch-to-semver-test.patch255.86 KBtedbow
#136 upload-fail2.patch116.14 KBtedbow
#135 upload-fail.patch116.11 KBtedbow
#133 no_rebuild.patch634 bytestedbow
#131 2946333-149-test.patch112.08 KBtedbow
#129 2977515-129-onlylb.patch109.78 KBtedbow
#127 test_config_schema_install.patch2.66 KBtedbow
#125 2946333-temp-test2.patch105.77 KBtedbow
#124 2946333-temp-test.patch107.01 KBtedbow
#123 3041659-link.patch64.42 KBtedbow
#122 3041659-link.patch64.42 KBtedbow
#121 3041659-link.patch62.51 KBtedbow
#120 3041659-field_config_sub.patch63.38 KBtedbow
#118 3041659-field_config.patch63.44 KBtedbow
#117 2948828-x50.patch31.39 KBtedbow
#115 core-quickedit-x100.patch1.91 KBtedbow
#114 2948828-107-x100.patch38.27 KBtedbow
#111 2948828-108-waits-x30.patch41.09 KBtedbow
#111 2948828-108-no_waits-x30.patch38.27 KBtedbow
#109 2948828-qe-test-pass.patch40.75 KBtedbow
#107 2948828-no-revisions.patch41.09 KBtedbow
#105 qe.patch6.65 KBtedbow
#103 test-only-qe1.patch16.99 KBtedbow
#101 2948828-wait.patch50.92 KBtedbow
#99 2948828-tag-only.patch50.16 KBtedbow
#97 2948828-hard_wait.patch50.04 KBtedbow
#95 2948828-no-label.patch49.93 KBtedbow
#93 2948828-use-toolbar-again.patch49.93 KBtedbow
#91 2948828-assertQuickEditToolbarFieldLabel.patch49.89 KBtedbow
#89 2948828-42-simple-test.patch50.6 KBtedbow
#87 2948828-extend-base-only.patch47.85 KBtedbow
#85 2948828-quickedit_only.patch50.09 KBtedbow
#85 interdiff-qe.txt1.26 KBtedbow
#83 2948828-remove-init-check.patch50.06 KBtedbow
#83 interdiff-remve-init.txt1.04 KBtedbow
#81 2948828-library_weight.patch49.51 KBtedbow
#81 interdiff-library_weight.txt523 bytestedbow
#79 2948828-assertEntityInstanceStates3.patch49.5 KBtedbow
#79 interdiff-assertEntityInstanceStates3.txt1.24 KBtedbow
#77 2948828-assertEntityInstanceStates.patch49.42 KBtedbow
#77 interdiff-assertEntityInstanceStates.txt1.82 KBtedbow
#75 2948828-ignore-internal-qe-state.patch48.17 KBtedbow
#75 interdiff-ignore.txt3.25 KBtedbow
#73 2948828-42-test-use-traitx50.patch46.82 KBtedbow
#70 2948828-42-test-output2.patch45.55 KBtedbow
#67 2948828-42-test-output.patch45.7 KBtedbow
#64 2901792-force_fail.patch6.49 KBtedbow
#62 2946294-51.patch684 bytestacituseu
#59 2968110-34-59-x100-no_animation.patch9.52 KBtedbow
#57 2968110-34-58-x100-with-fix.patch16.28 KBtedbow
#57 2968110-34-58-x100.patch9.49 KBtedbow
#55 2968110-34-x100.patch9.43 KBtedbow
#53 2968110-20-test_contextual.patch12.03 KBtedbow
#51 duplicate_data.patch938 bytestedbow
#49 2957425_simple_testing.patch135.11 KBtedbow
#48 2957425_wait_save_link5.patch133.86 KBtedbow
#46 2957425_wait_save_link4.patch133.82 KBtedbow
#44 2957425_wait_save_link3.patch133.84 KBtedbow
#42 2957425_wait_save_link2.patch133.85 KBtedbow
#40 2957425_wait_save_link.patch133.86 KBtedbow
#34 2957425-loopy-2.patch169.8 KBtedbow
#32 2957425-loopy.patch129.67 KBtedbow
#30 2957425-169x10.patch129.1 KBtedbow
#28 2957425-169x15.patch129.1 KBtedbow
#27 2957425-file-attach-wait.patch129.1 KBtedbow
#25 2957425_test_waits.patch128.59 KBtedbow
#23 2957425_service_provider.patch127.51 KBtedbow
#21 2957425_does_it_pass.patch125.37 KBtedbow
#19 2957425-access_in_preview.patch118.66 KBtedbow
#17 2957425-access_on_default.patch119.58 KBtedbow
#15 2957425-rand1.patch119.03 KBtedbow
#14 2957425-rand.patch119.05 KBtedbow
#12 2957425-rand.patch118.99 KBtedbow
#11 temp-2957425-5-testing.patch82.39 KBtedbow
#10 temp-2957425-4-testing.patch81.84 KBtedbow
#9 temp-2957425-3-testing.patch82.8 KBtedbow
#7 temp-2957425-2-testing.patch82.86 KBtedbow
#5 temp-2957425-1-testing.patch82.72 KBtedbow
#2 temp-2957425-testing.patch82.67 KBtedbow

Issue fork drupal-2977515

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new temp-2957425-testing.patch82.67 KB

whats up with this test?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: temp-2957425-testing.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new temp-2957425-1-testing.patch82.72 KB

if ignore message?

Status: Needs review » Needs work

The last submitted patch, 5: temp-2957425-1-testing.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new temp-2957425-2-testing.patch82.86 KB

what is page text at this point?

Status: Needs review » Needs work

The last submitted patch, 7: temp-2957425-2-testing.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new temp-2957425-3-testing.patch82.8 KB

this?

The website encountered an unexpected error. Please try again later.Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'parent_entity_id' at row 1: INSERT INTO {inline_block_content_usage} (entity_id, parent_entity_id, parent_entity_type) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array
(
[:db_insert_placeholder_0] => 1
[:db_insert_placeholder_1] => node.bundle_with_section_field.default
[:db_insert_placeholder_2] => entity_view_display
)
in Drupal\layout_builder\InlineBlockContentUsage->addUsage() (line 47 of core/modules/layout_builder/src/InlineBlockContentUsage.php). 

Drupal\Core\Database\Statement->execute(Array, Array) (Line: 625)
Drupal\Core\Database\Connection->query('INSERT INTO {inline_block_content_usage} (entity_id, parent_entity_id, parent_entity_type) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2)', Array, Array) (Line: 87)
Drupal\Core\Database\Driver\mysql\Connection->query('INSERT INTO {inline_block_content_usage} (entity_id, parent_entity_id, parent_entity_type) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2)', Array, Array) (Line: 32)
Drupal\Core\Database\Driver\mysql\Insert->execute() (Line: 371)
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new temp-2957425-4-testing.patch81.84 KB

🎉

removing some of the other changes

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new temp-2957425-5-testing.patch82.39 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2957425-rand.patch118.99 KB

why so random?

Status: Needs review » Needs work

The last submitted patch, 12: 2957425-rand.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-rand.patch119.05 KB

😿

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2957425-rand1.patch119.03 KB

⛵️

Status: Needs review » Needs work

The last submitted patch, 15: 2957425-rand1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-access_on_default.patch119.58 KB

is access on default the problem?

Status: Needs review » Needs work

The last submitted patch, 17: 2957425-access_on_default.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-access_in_preview.patch118.66 KB

if in_preview don't check dependency access

Status: Needs review » Needs work

The last submitted patch, 19: 2957425-access_in_preview.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_does_it_pass.patch125.37 KB

🎭

Status: Needs review » Needs work

The last submitted patch, 21: 2957425_does_it_pass.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_service_provider.patch127.51 KB

🙀

Status: Needs review » Needs work

The last submitted patch, 23: 2957425_service_provider.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_test_waits.patch128.59 KB

⏰

Status: Needs review » Needs work

The last submitted patch, 25: 2957425_test_waits.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-file-attach-wait.patch129.1 KB

😅

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2957425-169x15.patch129.1 KB

Status: Needs review » Needs work

The last submitted patch, 28: 2957425-169x15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-169x10.patch129.1 KB 
+++ b/core/scripts/run-tests.sh
@@ -145,6 +145,22 @@
+ for ($i = 0; $i < 115; $i++) {

115, whoops

Status: Needs review » Needs work

The last submitted patch, 30: 2957425-169x10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-loopy.patch129.67 KB

∞🤷‍♂️

Status: Needs review » Needs work

The last submitted patch, 32: 2957425-loopy.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425-loopy-2.patch169.8 KB

drupalGet()

The last submitted patch, 32: 2957425-loopy.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

I was working on something else and noticed this patch with only 2 results, and stopped by to look at it.

FYI: you dont have to add all that code to run-tests.sh anymore to get it to run just the one test, you can add arguments to drupalci.yml to make it do that now:

Example of how I did that in another patch: https://www.drupal.org/project/drupal/issues/2942900#comment-12620690
(the times 50 patch)

(other details here: https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes...)

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

@Mixologic thank for letting me know this sounds like a great change!

The last submitted patch, 32: 2957425-loopy.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 34: 2957425-loopy-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_wait_save_link.patch133.86 KB

Adding a wait for "Save Layout"

changing to use method @Mixologic mentioned above. Thanks!!!!!!!!

Status: Needs review » Needs work

The last submitted patch, 40: 2957425_wait_save_link.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_wait_save_link2.patch133.85 KB

🐛

Status: Needs review » Needs work

The last submitted patch, 42: 2957425_wait_save_link2.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_wait_save_link3.patch133.84 KB

🐼

Status: Needs review » Needs work

The last submitted patch, 44: 2957425_wait_save_link3.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_wait_save_link4.patch133.82 KB

🐲

Status: Needs review » Needs work

The last submitted patch, 46: 2957425_wait_save_link4.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2957425_wait_save_link5.patch133.86 KB

🌋

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2957425_simple_testing.patch135.11 KB

🏔

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new duplicate_data.patch938 bytes

Test to see how many dataProviders have duplicate data sets.

Status: Needs review » Needs work

The last submitted patch, 51: duplicate_data.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2968110-20-test_contextual.patch12.03 KB

Taking a fix to ContextualLinkClickTrait.php from #2924201: Resolve random failure in LayoutBuilderTest so that it can be added to HEAD
to see if clickLink() will work for [32968110]

Status: Needs review » Needs work

The last submitted patch, 53: 2968110-20-test_contextual.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2968110-34-x100.patch9.43 KB

trying to see if waitForElementVisible() sometime is not enough to avoid random error of clicking on link

Status: Needs review » Needs work

The last submitted patch, 55: 2968110-34-x100.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2968110-34-58-x100.patch9.49 KB
new 2968110-34-58-x100-with-fix.patch16.28 KB

Status: Needs review » Needs work

The last submitted patch, 57: 2968110-34-58-x100-with-fix.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2968110-34-59-x100-no_animation.patch9.52 KB

trying without fix but no animation

The last submitted patch, 57: 2968110-34-58-x100-with-fix.patch, failed testing. View results

The last submitted patch, 57: 2968110-34-58-x100.patch, failed testing. View results

tacituseu’s picture

tacituseu commented
StatusFileSize
new 2946294-51.patch684 bytes

Don't mind me, didn't want to start another one, should be just this one patch.

Status: Needs review » Needs work

The last submitted patch, 62: 2946294-51.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2901792-force_fail.patch6.49 KB 
+++ b/core/lib/Drupal/Core/Update/UpdateKernel.php
@@ -213,6 +213,7 @@ public function loadLegacyIncludes() {
+    return;

I think this early return statement will cause the rest of the function not to run 😜

Anyways.....
Another experiment

Status: Needs review » Needs work

The last submitted patch, 64: 2901792-force_fail.patch, failed testing. View results

tacituseu’s picture

tacituseu commented

I sure hoped so ;), it was just a proof patch for what ended up as #3032869: \Drupal\Core\Update\UpdateKernel::fixSerializedExtensionObjects() caused test runs to double in duration.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: ajax system » other
Status: Needs work » Needs review
StatusFileSize
new 2948828-42-test-output.patch45.7 KB

how to get test output??

Status: Needs review » Needs work

The last submitted patch, 67: 2948828-42-test-output.patch, failed testing. View results

tacituseu’s picture

tacituseu commented

According to drupalci_testbot and BrowserHtmlDebugTrait::htmlOutput() it should be at artifacts/run_tests.javascript/simpletest_html/.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-42-test-output2.patch45.55 KB

@tacituse LOL thanks for the tip.

Status: Needs review » Needs work

The last submitted patch, 70: 2948828-42-test-output2.patch, failed testing. View results

tacituseu’s picture

tacituseu commented

Sometimes I also found helpful spamming the following:
$this->createScreenshot(\Drupal::root() . '/sites/default/files/simpletest/' . date('YmdHis') . microtime(true) . '-before-click.jpg');
around the breaking steps (especially having to do with animations/JS), they'll end up in phpunit-xml/ subdir, nothing beats visual.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-42-test-use-traitx50.patch46.82 KB

Status: Needs review » Needs work

The last submitted patch, 73: 2948828-42-test-use-traitx50.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-ignore.txt3.25 KB
new 2948828-ignore-internal-qe-state.patch48.17 KB

Status: Needs review » Needs work

The last submitted patch, 75: 2948828-ignore-internal-qe-state.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-assertEntityInstanceStates.txt1.82 KB
new 2948828-assertEntityInstanceStates.patch49.42 KB

assertEntityInstanceStates add wait

Status: Needs review » Needs work

The last submitted patch, 77: 2948828-assertEntityInstanceStates.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-assertEntityInstanceStates3.txt1.24 KB
new 2948828-assertEntityInstanceStates3.patch49.5 KB

oqoqoqoqoq

Status: Needs review » Needs work

The last submitted patch, 79: 2948828-assertEntityInstanceStates3.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-library_weight.txt523 bytes
new 2948828-library_weight.patch49.51 KB

Status: Needs review » Needs work

The last submitted patch, 81: 2948828-library_weight.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-remve-init.txt1.04 KB
new 2948828-remove-init-check.patch50.06 KB

Status: Needs review » Needs work

The last submitted patch, 83: 2948828-remove-init-check.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-qe.txt1.26 KB
new 2948828-quickedit_only.patch50.09 KB

Status: Needs review » Needs work

The last submitted patch, 85: 2948828-quickedit_only.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-extend-base-only.patch47.85 KB

Status: Needs review » Needs work

The last submitted patch, 87: 2948828-extend-base-only.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-42-simple-test.patch50.6 KB

Status: Needs review » Needs work

The last submitted patch, 89: 2948828-42-simple-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-assertQuickEditToolbarFieldLabel.patch49.89 KB

Status: Needs review » Needs work

The last submitted patch, 91: 2948828-assertQuickEditToolbarFieldLabel.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-use-toolbar-again.patch49.93 KB

Status: Needs review » Needs work

The last submitted patch, 93: 2948828-use-toolbar-again.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-no-label.patch49.93 KB

Status: Needs review » Needs work

The last submitted patch, 95: 2948828-no-label.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-hard_wait.patch50.04 KB

Status: Needs review » Needs work

The last submitted patch, 97: 2948828-hard_wait.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-tag-only.patch50.16 KB

Status: Needs review » Needs work

The last submitted patch, 99: 2948828-tag-only.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-wait.patch50.92 KB

Status: Needs review » Needs work

The last submitted patch, 101: 2948828-wait.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new test-only-qe1.patch16.99 KB

is this actually a quickedit problem?

Status: Needs review » Needs work

The last submitted patch, 103: test-only-qe1.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new qe.patch6.65 KB

Status: Needs review » Needs work

The last submitted patch, 105: qe.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-no-revisions.patch41.09 KB

testing to see if revert happens

Status: Needs review » Needs work

The last submitted patch, 107: 2948828-no-revisions.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-qe-test-pass.patch40.75 KB

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2948828-108-no_waits-x30.patch38.27 KB
new 2948828-108-waits-x30.patch41.09 KB

The last submitted patch, 111: 2948828-108-no_waits-x30.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 111: 2948828-108-waits-x30.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-107-x100.patch38.27 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new core-quickedit-x100.patch1.91 KB

Status: Needs review » Needs work

The last submitted patch, 115: core-quickedit-x100.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2948828-x50.patch31.39 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041659-field_config.patch63.44 KB

Status: Needs review » Needs work

The last submitted patch, 118: 3041659-field_config.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041659-field_config_sub.patch63.38 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041659-link.patch62.51 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041659-link.patch64.42 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041659-link.patch64.42 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2946333-temp-test.patch107.01 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2946333-temp-test2.patch105.77 KB

Status: Needs review » Needs work

The last submitted patch, 125: 2946333-temp-test2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new test_config_schema_install.patch2.66 KB

How many times do we call installEntitySchema for config entities

Status: Needs review » Needs work

The last submitted patch, 127: test_config_schema_install.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2977515-129-onlylb.patch109.78 KB

Status: Needs review » Needs work

The last submitted patch, 129: 2977515-129-onlylb.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2946333-149-test.patch112.08 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new no_rebuild.patch634 bytes

Status: Needs review » Needs work

The last submitted patch, 133: no_rebuild.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new upload-fail.patch116.11 KB

for #3055648: Frequent random fail in \Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTest
and #3044496-104: [ignore] bnjmnm patch testing

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new upload-fail2.patch116.14 KB

@group 😱

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2313917-switch-to-semver-test.patch255.86 KB

how badly broken?

Status: Needs review » Needs work

The last submitted patch, 137: 2313917-switch-to-semver-test.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new locale-break.patch2.17 KB

https://www.drupal.org/project/drupal/issues/2313917#comment-13195309

Status: Needs review » Needs work

The last submitted patch, 139: locale-break.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new locale-no-filter-core.patch2.37 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2313917-simpletest.patch30.7 KB

simpletest 😱

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2313917-simpletest2.patch30.67 KB

rebase

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2313917-follow-up.patch5.61 KB

🤷‍♂️

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new Screenshot 2019-09-20 11.47.01.png63.99 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2631202-tester.patch195.09 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3070521-58-test.patch26.82 KB

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3062281-96-tester.patch35.16 KB

is it needed?

Status: Needs review » Needs work

The last submitted patch, 149: 3062281-96-tester.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3062281-101-simple.patch37.25 KB

will it blend?

Status: Needs review » Needs work

The last submitted patch, 151: 3062281-101-simple.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3062281-101-simple2.patch37.35 KB

module directories?

Status: Needs review » Needs work

The last submitted patch, 153: 3062281-101-simple2.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3062281-101-simple3.patch37.38 KB

got bool condition wrong

Status: Needs review » Needs work

The last submitted patch, 155: 3062281-101-simple3.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3062281-101-simple4.patch37.34 KB

I am totally nailing this!

Status: Needs review » Needs work

The last submitted patch, 157: 3062281-101-simple4.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3062281-101-simple5.patch37.34 KB

🤞😅

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3062281-101-simple5-more-tests.patch37.25 KB

ok great. lets check the other tests

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new no-version_patch-version_extra.patch2.84 KB

what are we testing here?

Status: Needs review » Needs work

The last submitted patch, 161: no-version_patch-version_extra.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3095755-force-fail.patch721 bytes

https://www.drupal.org/project/drupal/issues/3095755

Status: Needs review » Needs work

The last submitted patch, 163: 3095755-force-fail.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3074993-only-supported_branches.patch105.82 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3095755-12.patch2.71 KB

Status: Needs review » Needs work

The last submitted patch, 166: 3095755-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3005229-100.patch62.21 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5.patch16.08 KB

phpcs lint fix?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5.patch16.12 KB

assign key first?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5.patch16.12 KB

escaped double quotes?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5.patch16.12 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5.patch14.53 KB

Remove cases

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5.patch14.46 KB

simplify

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5-del-lines.patch14.23 KB
new 3119761-5-dumb.patch14.48 KB
new 3119761-5-nonowdoc.patch13.33 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3119761-5-set-each-case.patch14.56 KB
new 3119761-5-set-keys.patch14.56 KB

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
  1. five five five
  2. six
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-43-1test.patch57.43 KB

This passes locally. timing?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-46.patch57.41 KB

class wrong

Status: Needs review » Needs work

The last submitted patch, 180: 3041885-46.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46plus-test.patch58.26 KB

use +2 days

Status: Needs review » Needs work

The last submitted patch, 182: 3041885-46plus-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-send-test.patch58.26 KB

use send() directly

Status: Needs review » Needs work

The last submitted patch, 184: 3041885-46-send-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-1method-test.patch54.65 KB

just the problem method

Status: Needs review » Needs work

The last submitted patch, 186: 3041885-46-1method-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-assert_message_cnt-test.patch54.75 KB

assert the message count directly

Status: Needs review » Needs work

The last submitted patch, 188: 3041885-46-assert_message_cnt-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-getmsg_testt-test.patch55.57 KB
new 3041885-46-throwjson-test.patch55.59 KB

The last submitted patch, 190: 3041885-46-getmsg_testt-test.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 190: 3041885-46-throwjson-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-response--test.patch53.54 KB

Status: Needs review » Needs work

The last submitted patch, 193: 3041885-46-response--test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-empty-test.patch53.71 KB

Status: Needs review » Needs work

The last submitted patch, 195: 3041885-46-empty-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-controller-test.patch53.93 KB

Status: Needs review » Needs work

The last submitted patch, 197: 3041885-46-controller-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-json-response-test.patch54.08 KB

This is best use of my time

Status: Needs review » Needs work

The last submitted patch, 199: 3041885-46-json-response-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-json-response-code-test.patch54.26 KB

Status: Needs review » Needs work

The last submitted patch, 201: 3041885-46-json-response-code-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-absolute-test.patch54.28 KB

absolute path?

Status: Needs review » Needs work

The last submitted patch, 203: 3041885-46-absolute-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-endpoint-test.patch54.34 KB

Status: Needs review » Needs work

The last submitted patch, 205: 3041885-46-endpoint-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-exceptoins-test.patch54.75 KB

Status: Needs review » Needs work

The last submitted patch, 207: 3041885-46-exceptoins-test.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-what-emptys-test.patch55.14 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-46-what-emptys-test1.patch55.11 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-46-what-emptys-test2.patch55.06 KB

Status: Needs review » Needs work

The last submitted patch, 211: 3041885-46-what-emptys-test2.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-file_get_contents.patch54.89 KB

Status: Needs review » Needs work

The last submitted patch, 213: 3041885-46-file_get_contents.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-json-file.patch56.74 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-46-response.patch57 KB

Status: Needs review » Needs work

The last submitted patch, 216: 3041885-46-response.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-46-encode.patch57.21 KB

Status: Needs review » Needs work

The last submitted patch, 218: 3041885-46-encode.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-drupalci.patch58.08 KB

Status: Needs review » Needs work

The last submitted patch, 220: 3041885-49-drupalci.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-49-2days.patch58.08 KB

😡

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 222: 3041885-49-2days.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-2days-drupalget.patch58.13 KB
new 3041885-49-fake_time.patch58.23 KB

The last submitted patch, 225: 3041885-49-2days-drupalget.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 225: 3041885-49-fake_time.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-fake_time_format.patch59.09 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-49-delete_cache.patch58.59 KB

The last submitted patch, 228: 3041885-49-fake_time_format.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-49-3113971e.patch98.55 KB

Status: Needs review » Needs work

The last submitted patch, 231: 3041885-49-3113971e.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-delete_cache.patch59.5 KB
new 3041885-delete_cache1.patch59.54 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-cache_data.patch59.52 KB

Status: Needs review » Needs work

The last submitted patch, 234: 3041885-cache_data.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-bool_fix.patch58.29 KB

Status: Needs review » Needs work

The last submitted patch, 236: 3041885-49-bool_fix.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-1call_plus1.patch57.41 KB

Status: Needs review » Needs work

The last submitted patch, 238: 3041885-49-1call_plus1.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-msg_excep.patch57.43 KB

Status: Needs review » Needs work

The last submitted patch, 240: 3041885-49-msg_excep.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-no_cache.patch57.28 KB

Status: Needs review » Needs work

The last submitted patch, 242: 3041885-49-no_cache.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-cronthrow.patch57.66 KB

Status: Needs review » Needs work

The last submitted patch, 244: 3041885-49-cronthrow.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-debug.patch57.8 KB

Status: Needs review » Needs work

The last submitted patch, 246: 3041885-49-debug.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-debug2.patch58 KB

Status: Needs review » Needs work

The last submitted patch, 248: 3041885-49-debug2.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-debug-filename.patch58.11 KB

Status: Needs review » Needs work

The last submitted patch, 250: 3041885-49-debug-filename.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-49-http-json.patch59.34 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 252: 3041885-49-http-json.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-http-status.patch59.86 KB

Status: Needs review » Needs work

The last submitted patch, 255: 3041885-49-http-status.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-http-status1.patch59.87 KB
new 3041885-49-only_get.patch11.31 KB

The last submitted patch, 257: 3041885-49-http-status1.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 257: 3041885-49-only_get.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-cast_string.patch12.99 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-49-dataproviderg.patch11.27 KB

Status: Needs review » Needs work

The last submitted patch, 261: 3041885-49-dataproviderg.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041885-49-cast.patch56.38 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3041885-46_0-cast.patch58.19 KB
new 3041885-46_0-cast-no_request_time_fix.patch56.33 KB

Status: Needs review » Needs work

The last submitted patch, 264: 3041885-46_0-cast-no_request_time_fix.patch, failed testing. View results

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2977515-phpcs-error.patch1.64 KB

phpcs error

tedbow opened merge request !298

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

tedbow opened merge request !1511

tedbow opened merge request !1532

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

tedbow opened merge request !1543

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sandeepsingh199’s picture

sandeepsingh199 commented
Project: Drupal core » Diff
Version: 10.1.x-dev » 8.x-1.x-dev
Component: other » Documentation
StatusFileSize
new 2992445-11.patch2.48 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: [ignore] tedbow patch testing » [ignore] Test Package manager core merge
Project: Diff » Drupal core
Version: 8.x-1.x-dev » 10.1.x-dev
Component: Documentation » other

@SandeepSingh199 please don't change the project of this issue.

Also the Automatic Updates Initiative team is going to be using this issue for testing the conversion of the contrib module for core inclusion so this should be the temporary focus of this issue

tedbow opened merge request !3475

tedbow closed merge request !3475

tedbow closed merge request !1543

tedbow closed merge request !1532

tedbow closed merge request !1511

tedbow opened merge request !3476

Yogesh Sahu’s picture

Yogesh Sahu commented
StatusFileSize
new test1.patch5.22 KB
Yogesh Sahu’s picture

Yogesh Sahu commented
StatusFileSize
new test2.patch5.22 KB
adeshsharma’s picture

adeshsharma commented
StatusFileSize
new 3153168-29.patch96.65 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Active

Not closing out as I know this is in use. But part of cleaning out the review queue moving this out to not affect the metrics. Can still use it by clicking Add test/retest.

Thanks!

Yogesh Sahu’s picture

Yogesh Sahu commented
StatusFileSize
new test.patch699 bytes

Wim Leers made their first commit to this issue’s fork.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Uh oh, that is a massive conflict in composer.lock and core's metapackages' composer.json files that is not worth our time solving.

PLUS! Since Feb 15, we fixed PHPStan compliance (which was manually disabled on this MR), removed the dependencies on symfony/finder and symfony/config (which apparently were manually added at the start of the MR, not by the script). So … starting a new branch: 2977515-march3.

🤞

Wim Leers opened merge request !3578

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new Screen Shot 2023-03-10 at 3.15.06 PM.png337.57 KB

OMG.

Wim Leers opened merge request !3622

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs review
StatusFileSize
new 296693-10.0.x.patch35.38 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 296693-10.1.x.patch35.54 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Just cleaning up review queue.

tedbow opened merge request !4730

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 10.1-3347291-combine-3358049-3358049.patch139.61 KB

testing backporting #3347291: Combine field storage and field instance forms back to 10.1.x

Status: Needs review » Needs work

The last submitted patch, 300: 10.1-3347291-combine-3358049-3358049.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-3358049-3358049-a.patch146.08 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-3358049-3358049-b.patch146.32 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-3358049-3358049-c.patch146.21 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-3358049-3358049-d.patch148.48 KB
srishtiiee’s picture

srishtiiee commented
StatusFileSize
new 10.1-3347291-combine-3358049-3358049-e.patch148.51 KB
srishtiiee’s picture

srishtiiee commented
StatusFileSize
new 10.1-3347291-combine-3358049-3358049-f.patch147.51 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 3356894-to-2327883.patch199.09 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-mega-a.patch304.12 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-mega-b.patch304.04 KB
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 10.1-3347291-combine-mega-c.patch303.7 KB
srishtiiee’s picture

srishtiiee commented
StatusFileSize
new 10.1-3347291-combine-mega-d.patch304.04 KB
srishtiiee’s picture

srishtiiee commented
StatusFileSize
new 10.1-3347291-combine-mega-e.patch303.75 KB

tedbow opened merge request !5011

tedbow opened merge request !5881

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.