Problem/Motivation

In #3222947: Decide whether to move Quick Edit to contrib Dries, the committer team, and other stakeholders have signed off on removing the Quick Edit module from core in Drupal 10.

This meta issue is filed as critical because it also unblocks a required Drupal 10 issue for removing our dependency on Backbone.

This issue is to coordinate and track the steps needed to deprecate Quick Edit.. See Remove a core module and move it to a contributed project of the deprecation policy.

Proposed resolution

Do the work necessary to deprecate Quick Edit.

Remaining tasks

  1. Move integrations implemented by other modules to Quick Edit module
    1. #3267258: Remove Quick Edit support from editor.module
    2. #3264633: Remove \Drupal\layout_builder\QuickEditIntegration and refactor it so that quickedit contrib provides the integration with layout builder
    3. #3265140: Move QuickEditImageController from image to quickedit
    4. Help topics
    5. #3222947: Decide whether to move Quick Edit to contrib
    6. #3227036: Remove QuickEdit from the Standard profile
    7. #3227513: Remove QuickEdit from the Umami demo profile
    8. #3228634: Move tests for integrations between QuickEdit and other modules into QuickEdit so that it can more easily be moved into contrib
    9. #3228634: Move tests for integrations between QuickEdit and other modules into QuickEdit so that it can more easily be moved into contrib
    10. #3227161: Stop using Quick Edit data attributes as selectors in tests that are not testing Quick Edit
    11. #3230928: Remove unused LayoutBuilderTest::testRemovingAllSections()' Quick Edit dependency
    12. #3238626: [Follow-up] Move tests for integrations between QuickEdit and other modules into QuickEdit
    13. Handle Quick Edit migrations. N/A
  2. Create the contrib project, Quick Edit, with a stable release.: https://www.drupal.org/project/quickedit/releases/1.0.1
  3. #3270434: Mark Quick Edit deprecated
  4. Release Quick Edit 1.0.2 that actually works with ^9.4 || ^10. 😅

Related work:

User interface changes

No more Quick Edit.

API changes

TBD, possibly in child issues

Data model changes

TBD, possible in child issues

Release notes snippet

Needed. Here or in child issues?

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
gaurav.kapoor’s picture

gaurav.kapoor commented

Hi. I would like to volunteer for this. How can I get maintainer access? Should I start working on linked issues? Thanks.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@guarav.kapoor: yay! Did you build with and/or on top of quickedit before? Are you familiar with some of the current issues of the core component? (https://www.drupal.org/project/issues/search/drupal?project_issue_follow...) -- It is definitely not required to fix any of them in core or neither when the project moves to contrib, so its more of a question if you think you could help out with them if others are working on them.

gaurav.kapoor’s picture

gaurav.kapoor commented

@Gábor Hojtsy I haven't build anything on top of quick edit. I have started checking the codebase of the quick edit module and checking issues reported under https://www.drupal.org/project/issues/search/drupal?project_issue_follow.... I can definitely help out other contributors working on this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

#3238626: [Follow-up] Move tests for integrations between QuickEdit and other modules into QuickEdit is done too!

That means we can now do #3227033: Remove Quick Edit from core 🤓

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Active » Needs review

We missed the window for doing this in 9.3.0.

What needs to happen next to get this done before 9.4.0?

catch’s picture

catch
he/him
Primary language English
commented

The current blocker is #3252214: Move tests for integrations between QuickEdit and CKEditor5 into QuickEdit so that it can more easily be moved into contrib

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Blocker #3252214: Move tests for integrations between QuickEdit and CKEditor5 into QuickEdit so that it can more easily be moved into contrib is committed.

Updated IS to reflect gaurav.kapoor has volunteered to become a maintainer for the Contrib Module QuickEdit in #4.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [plan] Move QuickEdit into contrib and remove it from core » [PP-2] [plan] Move QuickEdit into contrib and remove it from core
Status: Needs review » Postponed
Related issues: +#3215043: Indicate the non-stable statuses in admin/modules page, +#3215045: [Duplicate] Highlight obsolete module's status at admin/reports/status page, providing warning and link with explanation

Looking at @Gábor Hojtsy's comment in the (very) similar issue about moving the HAL module from Core to Contrib (#3049857: Remove HAL module from core and create a contrib project for it), I think this issue should also be postponed on #3215043: Indicate the non-stable statuses in admin/modules page and #3215045: [Duplicate] Highlight obsolete module's status at admin/reports/status page, providing warning and link with explanation

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Related issues: -#3215045: [Duplicate] Highlight obsolete module's status at admin/reports/status page, providing warning and link with explanation +#3250585: Highlight deprecated modules and themes at admin/reports/status page, providing warning and link with explanation

Update related issues.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-2] [plan] Move QuickEdit into contrib and remove it from core » [PP-1] [plan] Move QuickEdit into contrib and remove it from core

#3215043: Indicate the non-stable statuses in admin/modules page just got committed, only postponed now on #3250585: Highlight deprecated modules and themes at admin/reports/status page, providing warning and link with explanation.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] [plan] Move QuickEdit into contrib and remove it from core » [plan] Move QuickEdit into contrib and remove it from core
Status: Postponed » Active

Unpostponing after #3250585: Highlight deprecated modules and themes at admin/reports/status page, providing warning and link with explanation was committed.

spokje’s picture

spokje
Primary language Dutch
commented

Removal patch is in #3227033: Remove Quick Edit from core

catch’s picture

catch
he/him
Primary language English
commented

@gaurav.kapoor are you still interested in maintaining Quickedit in contrib? If so creation of the contributed project is the last blocker for #3227033: Remove Quick Edit from core.

gaurav.kapoor’s picture

gaurav.kapoor commented

@catch Not anymore. Thanks.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Updated IS to reflecting were still looking for a maintainer for QuickEdit in Contrib.

dww’s picture

dww
we/he/they
commented

Per #3227033-76: Remove Quick Edit from core, I did a subtree split of 9.4.x quick edit into 1.0.x branch of the contrib project and made a 1.0.0-rc1. I’m not really planning to maintain it, other than cooperation with the sec team if needed. So if anyone else wants to help, please do. But at least the deed is done. ;)

quietone’s picture

quietone commented
Issue summary: View changes
Parent issue: #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1 » #3222947: Decide whether to move Quick Edit to contrib
quietone’s picture

quietone commented
Title: [plan] Move QuickEdit into contrib and remove it from core » [Meta] Move QuickEdit into contrib and remove it from core
quietone’s picture

quietone commented
Issue summary: View changes
dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Updating remaining tasks with some things that are already done.

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Question on scope and issues. Currently both of these points:

  • Deprecate the core Quickedit module
  • Remove Quickedit module from core.

have patches in #3227033: Remove Quick Edit from core. Given the very next point is "Commit the deprecation patch and the removal patch within 24 hours of each other." is it better to leave these in the same issue, or would it be preferred to split out the 9.4.x deprecation patch into a separate issue?

Thanks,
-Derek

xjm’s picture

xjm
she/her
Primary language English
commented
Parent issue: #3222947: Decide whether to move Quick Edit to contrib »
Related issues: +#3222947: Decide whether to move Quick Edit to contrib, +#3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1
xjm’s picture

xjm
she/her
Primary language English
commented

@dww The whole notion of committing them 24 hours apart is weird; normally, we wouldn't even have deprecations allowed at the point where the major branch is open at all. However, separate issues are still preferable because they're totally different code-wise, being committed to different branches, and part of different steps of the meta.

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Cool, makes sense. #3270434: Mark Quick Edit deprecated

quietone’s picture

quietone commented
Title: [Meta] Move QuickEdit into contrib and remove it from core » [Meta] Tasks to deprecate Quickedit
Issue summary: View changes
Parent issue: » #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1
quietone’s picture

quietone commented
Issue summary: View changes
Related issues: +#3274155: [Meta] Tasks to remove Quick Edit from core and move to contrib

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [Meta] Tasks to deprecate Quickedit » [Meta] Tasks to deprecate Quick Edit
Issue summary: View changes

Sorry, this triggered my OCD too much too many times to resist 🙈😬

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

I believe we're just down to #3270434: Mark Quick Edit deprecated now. 🎉 Minor summary edit to update all the [#] statuses.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Drupal 10 beta should-have
quietone’s picture

quietone commented
Parent issue: #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1 » #3296094: [meta] Deprecate modules and themes that will be removed from Drupal 10 core by 9.5.0-beta1

Move to a child of the 9.5 beta1 parent

dww’s picture

dww
we/he/they
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

Now that contrib quickedit 1.0.2 is out, I believe we're ready, and all that remains is to commit #3270434: Mark Quick Edit deprecated and we can mark this plan fixed...

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

Thanks for the huge effort to deprecate Quick Edit!

The unfinished related issue in the IS is an issue in the contrib project.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

🥳

🙏 Many thanks to all of you who devised and executed this intricate web of tasks to allow Quick Edit to be removed from Drupal core!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.