CommentFileSizeAuthor
#225 2879048-225-log-cacheGet-extend.patch9.24 KBAnonymous (not verified)
#224 2879048-224-config-cid-field.storage.entity_test_mulrev_changed.field_test_text.patch1.4 KBAnonymous (not verified)
#224 2879048-224-config-cid-field.storage.entity_test_mul_changed.field_test_text.patch1.4 KBAnonymous (not verified)
#224 2879048-224-config-cid-field.storage.entity_test_mul_langcode_key.field_test_text.patch1.4 KBAnonymous (not verified)
#224 2879048-224-config-cid-field.storage.entity_test_mulrev.field_test_text.patch1.39 KBAnonymous (not verified)
#224 2879048-224-config-cid-field.storage.entity_test_mul.field_test_text.patch1.39 KBAnonymous (not verified)
#223 2879048-222-config-cids-p3.patch1.53 KBAnonymous (not verified)
#223 2879048-222-config-cids-p2.patch1.45 KBAnonymous (not verified)
#223 2879048-222-config-cids-p1.patch1.44 KBAnonymous (not verified)
#222 2879048-222-config-cids-non-field.patch1.57 KBAnonymous (not verified)
#222 2879048-222-config-cids-field.patch1.75 KBAnonymous (not verified)
#221 2879048-220-config-cids-non-field.patch1.59 KBAnonymous (not verified)
#221 2879048-220-config-cids-field.patch1.77 KBAnonymous (not verified)
#220 2879048-220-config-cids-2.patch1.99 KBAnonymous (not verified)
#219 2879048-219-cids-by-equal-default_config_hash.patch1.63 KBAnonymous (not verified)
#218 2879048-217-bins-special-deleteAll-config.patch1.27 KBAnonymous (not verified)
#218 2879048-217-bins-special-deleteAll-bootstrap.patch1.27 KBAnonymous (not verified)
#218 2879048-217-bins-special-deleteAll-discovery.patch1.27 KBAnonymous (not verified)
#217 2879048-217-bins-special-deleteAll.patch1.37 KBAnonymous (not verified)
#216 2879048-216-bins-special-delete.patch1.47 KBAnonymous (not verified)
#215 2879048-215-log-bins.patch2.41 KBAnonymous (not verified)
#214 2879048-214-log-bins.patch2.42 KBAnonymous (not verified)
#212 2879048-212-bins-deleteAll.patch1.3 KBAnonymous (not verified)
#211 2879048-211-cacheGet-false.patch1.62 KBAnonymous (not verified)
#210 2879048-210-log-getMultiple-with-spec-cid.patch3.89 KBAnonymous (not verified)
#209 2879048-209-test-only-gc-collect-binsearch-2.patch1.19 KBtacituseu
#209 2879048-209-test-only-gc-collect-binsearch-1.patch1.29 KBtacituseu
#208 2879048-208-log-EntityFieldManager-getFieldMap.patch18.39 KBAnonymous (not verified)
#207 2879048-206-log-FieldConfig-save.patch15.35 KBAnonymous (not verified)
#205 2879048-205-log-FieldConfig-create.patch8.03 KBAnonymous (not verified)
#203 2879048-203-ChainedFastBackend.patch2.03 KBAnonymous (not verified)
#202 2879048-202-test-only-without-old-one.patch2.16 KBtacituseu
#201 2879048-201-log-setUp-EntityResourceTestBase.patch4 KBAnonymous (not verified)
#200 2879048-200-log-setUp.patch4.62 KBAnonymous (not verified)
#199 2879048-199-log-resetAll-and-rebuildAll.patch3.3 KBAnonymous (not verified)
#198 2879048-198-log-drupal_flush_all_caches.patch6.63 KBAnonymous (not verified)
#196 2879048-196-log-calls.patch2.06 KBAnonymous (not verified)
#194 2879048-194-no-static.patch1.43 KBtacituseu
#194 2879048-194-clone.patch1.67 KBtacituseu
#190 2879048-176-test-only-well.patch2.71 KBtacituseu
#189 2879048-176-test-only-sorted_graph.patch2.75 KBtacituseu
#189 2879048-176-test-only-graph_object.patch2.75 KBtacituseu
#189 2879048-176-test-only-graph.patch2.75 KBtacituseu
#188 2879048-188-tour.patch1.35 KBAnonymous (not verified)
#188 2879048-188-statistics.patch1.36 KBAnonymous (not verified)
#188 2879048-188-book.patch1.35 KBAnonymous (not verified)
#188 2879048-188-action.patch1.35 KBAnonymous (not verified)
#183 2879048-182-test-only-with-random-modules.patch1.38 KBAnonymous (not verified)
#183 2879048-182-test-only-without-c74c39e.patch34.87 KBAnonymous (not verified)
#181 2879048-181-test-only-with-add-random-modules.patch3.46 KBAnonymous (not verified)
#181 2879048-181-test-only-without-entity_test.data_types.schema.yml.patch3.26 KBAnonymous (not verified)
#180 2879048-180-test-only-without-2c2e85c.patch5.89 KBtacituseu
#180 2879048-180-test-only-without-113c6dc.patch5.56 KBtacituseu
#178 test-only.patch759 bytesAnonymous (not verified)
#176 fix.patch2.82 KBAnonymous (not verified)
#176 test-only.patch759 bytesAnonymous (not verified)
#173 x100-EntityTestJsonInternalPropertyNormalizerTest-and-129.patch2.69 KBAnonymous (not verified)
#173 x100-EntityTestJsonInternalPropertyNormalizerTest.patch628 bytesAnonymous (not verified)
#171 x200-EntityTestHalJsonInternalPropertyNormalizerTest-and-129.patch2.7 KBAnonymous (not verified)
#171 x200-EntityTestHalJsonInternalPropertyNormalizerTest.patch632 bytesAnonymous (not verified)
#170 x20-EntityTestHalJsonInternalPropertyNormalizerTest.patch631 bytesAnonymous (not verified)
#167 2879048-167-graph-stress.patch34 KBtacituseu
#165 2879048-165-graph-stress.patch33.92 KBtacituseu
#163 2879048-163-graph-stress.patch33.75 KBtacituseu
#161 2879048-161-graph-stress.patch33.6 KBtacituseu
#159 2879048-159-graph-stress.patch33.59 KBtacituseu
#157 2879048-157-graph-stress.patch33.59 KBtacituseu
#155 restore-d7c496150e.patch147.6 KBAnonymous (not verified)
#154 revert-d7c496150e.patch108.88 KBAnonymous (not verified)
#153 revert_dc5ca923d0_r.patch3.78 MBAnonymous (not verified)
#152 revert_fdef8555ac_r.patch3.82 MBAnonymous (not verified)
#151 revert_10a1e15fa3_r.patch3.82 MBAnonymous (not verified)
#150 revert_d7c496150e_r.patch3.67 MBAnonymous (not verified)
#149 revert_82f1a1ca6c_r.patch4.04 MBAnonymous (not verified)
#148 revert_a47d8c49b2_r.patch3.55 MBAnonymous (not verified)
#147 2879048-147-revert-yml-modules-and-themes.patch7.93 KBAnonymous (not verified)
#146 2879048-130-minus-two-themes.patch2.05 KBAnonymous (not verified)
#145 revert_7204a00_r.patch4.46 MBAnonymous (not verified)
#143 revert_50a541b_r.patch5.65 MBAnonymous (not verified)
#142 revert_50a541b.patch5.65 MBAnonymous (not verified)
#141 2879048-141.patch1.49 KBAnonymous (not verified)
#139 2879048-98-No-config-user-namespace__ConfigImportUITest.patch1.04 KBAnonymous (not verified)
#139 2879048-98-No-config-user-namespace_without_many_themes.patch64.64 KBAnonymous (not verified)
#137 2879048-98-No-config-user-namespace-save-graph-sorted-1-add-mod.patch1.85 KBtacituseu
#137 2879048-98-No-config-user-namespace-save-graph-1-add-mod.patch1.67 KBtacituseu
#135 2879048-98-No-config-user-namespace-save-graph-sorted-1.patch1.31 KBtacituseu
#135 2879048-98-No-config-user-namespace-save-graph-1.patch1.14 KBtacituseu
#134 2879048-98-No-config-user-namespace-save-graph-sorted.patch1.31 KBtacituseu
#133 2879048-98-No-config-user-namespace-save-graph.patch1.14 KBtacituseu
#130 2879048-98-No-config-user-namespace.patch1.03 KBtacituseu
#129 2879048-98-No-config-user-namespace-keep-graph.patch3.68 KBtacituseu
#126 x20__2849674-49_rest.patch13.42 KBAnonymous (not verified)
#125 x20__2849674-49_system.patch13.43 KBAnonymous (not verified)
#124 2879048-122-action.patch1.6 KBAnonymous (not verified)
#124 2879048-122-filter.patch1.6 KBAnonymous (not verified)
#124 2879048-122-system.patch1.6 KBAnonymous (not verified)
#122 2879048-122-more-dependencies.patch1.64 KBAnonymous (not verified)
#118 2879048-118-action_default_configuration.patch1.54 KBAnonymous (not verified)
#114 2879048-98-No-config-user-namespace-NodeCreationTest.patch1.05 KBAnonymous (not verified)
#114 2879048-98-No-action__order.patch1.61 KBAnonymous (not verified)
#114 2879048-98-No-install__order.patch2.69 KBAnonymous (not verified)
#114 2879048-98-action-schema__order.patch3.34 KBAnonymous (not verified)
#112 interdiff-order.txt518 bytesAnonymous (not verified)
#112 x200__2849674-49_change_order.patch13.42 KBAnonymous (not verified)
#112 x200__2849674-49.patch13.42 KBAnonymous (not verified)
#108 2879048-108-system_intead_user.patch1.02 KBAnonymous (not verified)
#108 2879048-108-filter_intead_view.patch1.02 KBAnonymous (not verified)
#108 2879048-108-other_company.patch1.45 KBAnonymous (not verified)
#108 2879048-108-change_order.patch1.41 KBAnonymous (not verified)
#108 2879048-108-submodules.patch1.45 KBAnonymous (not verified)
#107 2879048-107-user_name-and-req.patch1.04 KBLendude
#107 2879048-107-user_name.patch1.04 KBLendude
#105 2879048-105-only-user.patch1.01 KBAnonymous (not verified)
#102 2879048-98-No-config-views-namespace.patch1.01 KBLendude
#102 2879048-98-No-config-user-namespace.patch1.03 KBLendude
#98 2879048-98-No-action.patch1.61 KBLendude
#98 2879048-98-No-install.patch2.69 KBLendude
#98 2879048-98-action-schema.patch3.34 KBLendude
#97 2879048-97-fpt.patch1.93 KBtacituseu
#93 2879048-93-test-batch-only-config-and-action-bare-gc-disabled.patch3.83 KBtacituseu
#90 2879048-90-2.patch3.27 KBAnonymous (not verified)
#90 2879048-90-1.patch3.38 KBAnonymous (not verified)
#88 2879048-88-test-batch-only-config-and-action-bare.patch3.31 KBtacituseu
#86 2879048-86-test-batch-only-config-and-action-access-as-object+not-typed-as-content-execute.patch4.72 KBtacituseu
#81 2879048-81-gc.patch5.87 KBAnonymous (not verified)
#80 2879048-80-only-FileFieldWidgetTest.patch498 bytesAnonymous (not verified)
#78 2879048-78-test-batch-only-config-and-action-comma.patch4.64 KBtacituseu
#76 2879048-76-test-batch-only-config-and-action-concurrency-1.patch4.98 KBtacituseu
#74 2879048-74-test-batch-only-config-and-action-access-as-object.patch4.69 KBtacituseu
#72 interdiff.txt509 bytesAnonymous (not verified)
#72 patch-67_and_rebuild_themes.patch5.13 KBAnonymous (not verified)
#67 2879048-67-test-batch-only-config-and-plugins.patch4.64 KBtacituseu
#64 2879048-64-test-kernel.patch2.51 KBtacituseu
#64 2879048-64-test-batch.patch6.13 KBtacituseu
#62 2879048-62-test.patch8.16 KBtacituseu
#60 2879048-60-test.patch8.15 KBtacituseu
#60 2879048-60-patch.patch5.75 KBtacituseu
#57 2879048-57.patch13.42 KBAnonymous (not verified)
#56 x100_2809471-13.patch12.3 KBAnonymous (not verified)
#54 page_2809471.patch11.97 KBAnonymous (not verified)
#52 2809471-13-2.patch12.16 KBAnonymous (not verified)
#52 2809471-13-1.patch12.28 KBAnonymous (not verified)
#50 2879048-50.patch43.93 KBAnonymous (not verified)
#48 2879048-48.patch44.04 KBAnonymous (not verified)
#46 2879048-46.patch43.67 KBAnonymous (not verified)
#43 2879048-43.patch43.03 KBAnonymous (not verified)
#42 2879048-42-full.patch42.71 KBAnonymous (not verified)
#42 2879048-42.patch43.23 KBAnonymous (not verified)
#40 2879048-40.patch43.09 KBAnonymous (not verified)
#38 ignore_patch_testing-2879048-38.patch27.18 KBAnonymous (not verified)
#36 ignore_patch_testing-2879048-36.patch26.7 KBAnonymous (not verified)
#34 2879048-33.patch35.03 KBAnonymous (not verified)
#32 phpunit.patch233.32 KBAnonymous (not verified)
#31 rebuild.patch7.26 KBAnonymous (not verified)
#29 50x_sleep.patch7.73 KBAnonymous (not verified)
#29 50x_cache_list.patch7.8 KBAnonymous (not verified)
#29 50x_list_null.patch7.74 KBAnonymous (not verified)
#28 50x_refresh.patch7.74 KBAnonymous (not verified)
#28 50x_reset.patch7.74 KBAnonymous (not verified)
#28 50x_rebuild.patch7.39 KBAnonymous (not verified)
#26 x100_theme_exception.patch3.45 KBAnonymous (not verified)
#25 x100_theme_alone.patch3.41 KBAnonymous (not verified)
#24 x100_assert_alone.patch1.05 KBAnonymous (not verified)
#22 x100_assert.patch7.28 KBAnonymous (not verified)
#21 assert_default_fix.patch6.85 KBAnonymous (not verified)
#19 assert_default.patch6.82 KBAnonymous (not verified)
#19 assert_return.patch6.83 KBAnonymous (not verified)
#17 assert.patch6.79 KBAnonymous (not verified)
#15 use_class_v3.patch848.11 KBAnonymous (not verified)
#13 use_class_3.patch846.52 KBAnonymous (not verified)
#12 use_class_v2.patch785.4 KBAnonymous (not verified)
#9 use_class.patch785.75 KBAnonymous (not verified)
#8 menu_link_content_does_not_properly_validate_description-2877559-29.patch1.74 KBDinesh18
#7 menu_link_content_does_not_properly_validate_description-2877559-29.patch1.74 KBDinesh18
#4 x10000_runs_2857843.patch5.34 KBAnonymous (not verified)
#4 500x10_langs_2857843.patch5.34 KBAnonymous (not verified)
#2 x1-2857843.patch5.06 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

vaplas created an issue. See original summary.

Anonymous’s picture

Status: Active » Needs review
FileSize
5.06 KB

Status: Needs review » Needs work

The last submitted patch, 2: x1-2857843.patch, failed testing.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
5.34 KB
5.34 KB

The last submitted patch, 4: 500x10_langs_2857843.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: x10000_runs_2857843.patch, failed testing.

Dinesh18’s picture

Dinesh18’s picture

Anonymous’s picture

Title: IGNORE: Patch testing issue » Ignore: patch testing issue
Assigned: » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
FileSize
785.75 KB
Anonymous’s picture

Category: Task » Support request

Status: Needs review » Needs work

The last submitted patch, 9: use_class.patch, failed testing. View results

Anonymous’s picture

Status: Needs work » Needs review
FileSize
785.4 KB
Anonymous’s picture

FileSize
846.52 KB

Status: Needs review » Needs work

The last submitted patch, 13: use_class_3.patch, failed testing. View results

Anonymous’s picture

Status: Needs work » Needs review
FileSize
848.11 KB

Status: Needs review » Needs work

The last submitted patch, 15: use_class_v3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 17: assert.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 19: assert_default.patch, failed testing. View results

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 22: x100_assert.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
1.05 KB
Anonymous’s picture

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 26: x100_theme_exception.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
7.39 KB
7.74 KB
7.74 KB
Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 29: 50x_sleep.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
7.26 KB
Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 32: phpunit.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
35.03 KB

Status: Needs review » Needs work

The last submitted patch, 34: 2879048-33.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
26.7 KB

Status: Needs review » Needs work

The last submitted patch, 36: ignore_patch_testing-2879048-36.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 38: ignore_patch_testing-2879048-38.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
43.09 KB

Status: Needs review » Needs work

The last submitted patch, 40: 2879048-40.patch, failed testing. View results

Anonymous’s picture

Status: Needs work » Needs review
FileSize
43.23 KB
42.71 KB
Anonymous’s picture

The last submitted patch, 42: 2879048-42-full.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 43: 2879048-43.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
43.67 KB

Status: Needs review » Needs work

The last submitted patch, 46: 2879048-46.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 48: 2879048-48.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
43.93 KB

Status: Needs review » Needs work

The last submitted patch, 50: 2879048-50.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
12.28 KB
12.16 KB

Status: Needs review » Needs work

The last submitted patch, 52: 2809471-13-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
11.97 KB

Status: Needs review » Needs work

The last submitted patch, 54: page_2809471.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
12.3 KB
Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 57: 2879048-57.patch, failed testing. View results

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tacituseu’s picture

Checking which part exactly as it doesn't seem to have overlap at all, and with less iterations not to give CI a hard time.

Status: Needs review » Needs work

The last submitted patch, 60: 2879048-60-test.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Status: Needs review » Needs work

The last submitted patch, 62: 2879048-62-test.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

The last submitted patch, 64: 2879048-64-test-batch.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Lendude’s picture

Ha, did not expect that at all!

Status: Needs review » Needs work

The last submitted patch, 67: 2879048-67-test-batch-only-config-and-plugins.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

o_O

tacituseu’s picture

Status: Needs review » Needs work

The last submitted patch, 70: 2879048-69-test-batch-only-config-and-plugins-trace.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 72: patch-67_and_rebuild_themes.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

could it be ? Drupal\Core\Action\ActionInterface:

  /**
   * Checks object access.
   *
   * @param mixed $object
   *   The object to execute the action on.
   * @param \Drupal\Core\Session\AccountInterface $account
   *   (optional) The user for which to check access, or NULL to check access
   *   for the current user. Defaults to NULL.
   * @param bool $return_as_object
   *   (optional) Defaults to FALSE.
   *
   * @return bool|\Drupal\Core\Access\AccessResultInterface
   *   The access result. Returns a boolean if $return_as_object is FALSE (this
   *   is the default) and otherwise an AccessResultInterface object.
   *   When a boolean is returned, the result of AccessInterface::isAllowed() is
   *   returned, i.e. TRUE means access is explicitly allowed, FALSE means
   *   access is either explicitly forbidden or "no opinion".
   */
  public function access($object, AccountInterface $account = NULL, $return_as_object = FALSE);
 

@vaplas: interesting observation indeed.

Status: Needs review » Needs work

The last submitted patch, 74: 2879048-74-test-batch-only-config-and-action-access-as-object.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Let's force concurrency to 1 then and see if only the first one fails.

Status: Needs review » Needs work

The last submitted patch, 76: 2879048-76-test-batch-only-config-and-action-concurrency-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 78: 2879048-78-test-batch-only-config-and-action-comma.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
498 bytes
Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch, 81: 2879048-81-gc.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Well, #60 fail with 5.6 and pass with 7.1. There may be some specific behavior, for example:

function file_progress_implementation() {
    ...
    elseif (version_compare(PHP_VERSION, '7', '<') && extension_loaded('apc') && ini_get('apc.rfc1867')) {
      $implementation = 'apc';
    }
   ...
}

Or some vendor, like phpspec, in which there are many checks like version_compare(PHP_VERSION, '7...)?

Anonymous’s picture

All versions php 7.x passed tests of #78. Annnd php 5.5 too!) Random luck? Not. Rerun #57 with 100 runs, and pass too. Hence problem only with php 5.6.

tacituseu’s picture

@vaplas: yes, tried them on #67 too, and all it does is registering an Action plugin, out of ideas at the moment.

tacituseu’s picture

Status: Needs review » Needs work
tacituseu’s picture

Status: Needs work » Needs review
FileSize
3.31 KB

Status: Needs review » Needs work

The last submitted patch, 88: 2879048-88-test-batch-only-config-and-action-bare.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
3.38 KB
3.27 KB

The last submitted patch, 90: 2879048-90-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 90: 2879048-90-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Anonymous’s picture

MAN!!!

tacituseu’s picture

Sprinkling core with gc_disable() every time 5.6 isn't happy can't be a solution though.

Anonymous’s picture

Let it be so) But it's a good jab in the fight against #2842393: Discover why gc_disable() improves update.php stability. Now the problem is easier to reproduce.

tacituseu’s picture

Lendude’s picture

What's so damn special about this action that it causes all this ????

Wild stabs in the dark....

The last submitted patch, 98: 2879048-98-action-schema.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 98: 2879048-98-No-install.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 98: 2879048-98-No-action.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Lendude’s picture

Ok so, it's the adding a module that kills it....sheeeesh

lets try some empty modules and see if that still kills it....

Anonymous’s picture

Lendude!!! It is epic!

The last submitted patch, 102: 2879048-98-No-config-user-namespace.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Lendude’s picture

You've got te be kidding me.....

I gotta go now, so @vaplas go crazy with this :)

Lendude’s picture

Lendude’s picture

@vaplas, @catch just did a ton of commits, so try the original failing file too, the problem might have moved to a different test

The last submitted patch, 108: 2879048-108-filter_intead_view.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 108: 2879048-108-system_intead_user.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Status: Needs work » Needs review
FileSize
13.42 KB
13.42 KB
518 bytes

It seems the order matters for stable works of Mr. Bot:

  • #102: 2879048-98-No-config-user-namespace.patch - failed.
  • #108: 2879048-108-change_order.patch - passed.

Let's check the #2849674-49: Complex job in ViewExecutable::unserialize() causes data corruption 200 runs one then.

Status: Needs review » Needs work

The last submitted patch, 112: x200__2849674-49_change_order.patch, failed testing. View results

Anonymous’s picture

The last submitted patch, 114: 2879048-98-No-install__order.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 114: 2879048-98-action-schema__order.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 114: 2879048-98-No-action__order.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

tacituseu’s picture

Looks like CI ran out of free space again on some of those patches.

Anonymous’s picture

Because I abused the trust of CI and ran it 200 times in #112. But I saw the tests fall in both versions. Apparently in the schema.yml also something hidden, because changed order in #114 doesn't help.

tacituseu’s picture

Looking over latest patches, could it be that the dependency resolver is the one responsible for creating those 'bad' objects https://bugs.php.net/bug.php?id=72286 mentions ?

Anonymous’s picture

#121: Maybe even more so that @xjm emphasized this bug. But it says:

The issue affects PHP 5.6 and 5.5 (and 5.4), but not 7.0.

But our tests works with 5.5. Of course, maybe this problem actual only special 5.x versions. In any case, it's too smart for me :)

tacituseu’s picture

@vaplas: 5.5 is patched/supported by Ubuntu, so might have some fixes that are not in 5.6, but that is only if installed from their repository, not sure what is the state of things now, since AFAIR to support generating stack dumps/backtraces on those coredumps the CI team started custom compiling php from sources.

Anonymous’s picture

Anonymous’s picture

Does anyone understand why adding dependency helps to get rid of random falls? Me not. What if add any independent module?

tacituseu’s picture

The fails are in circular reference garbage collector, my guess would be it either:
1. changes order of objects and the algorithm has easier time collecting them
2, increases reference count so the algorithm doesn't even try to collect it

Also follow up on php versions used for testbots (drupalci_environments): they are based on tarballs directly from https://secure.php.net, except for those suffixed with 'x-dev' which are from https://github.com/php/php-src/, so no Ubuntu/Debian specific patches in them.

Anonymous’s picture

@tacituseu, thank you! Sounds logical for me!

Anonymous’s picture

WOW! This is awesome!

tacituseu’s picture

@vaplas: Thanks for the question, it kept bugging me so took a stab at #127.2 and it worked ;).

tacituseu’s picture

tacituseu’s picture

Anonymous’s picture

Looks like patches haven't user_batch_action_test.info.yml part.

tacituseu’s picture

Yeah forgot to git add ;), but will be good for baseline.

Anonymous’s picture

All I could understand is that the drop may occur with graph of themes (although the graph of a successful test is the same as the last graph of a failed test).

I like the idea that the themes are the culprit, because I have a tooth on them due #2849674: Complex job in ViewExecutable::unserialize() causes data corruption :) But maybe I'm wrong. Try our test, leaving only the main themes.

Also check ConfigImportUITest.

tacituseu’s picture

There are 152 calls to ModuleHandler::buildModuleDependencies() per test run, it is used for both modules and themes, the very first one is from ThemeHandler::rebuildThemeData(), and it is in a different order than all the rest so there might be something to this tooth (also observation from #72 that the first ones tend to fail), but the resulting graphs are the same.
I don't expect them to differ, just trying to create a test case for Graph.
You can split the log with:
$ csplit -n 3 -f mod-dep-calls- graph.log '/^20170807/' "{*}"

Anonymous’s picture

Sooner or later the FileFieldWidgetTest will be converted to phpunit. Therefore, it makes sense to prepare in advance. After that, I will create a new issue with move the main points from here.

Anonymous’s picture

It seems that we lost this control test :(, because #130 also not work now. Checking the reason: is the changes in the set of modules/themes or the change CI settings? (revert to 2017-08-07, commit hash 50a541b.... + #130 patch).


5Mb changes by 2 month, crazy!
Anonymous’s picture

The last submitted patch, 142: revert_50a541b.patch, failed testing. View results

Anonymous’s picture

Yep, due to list of modules/themes was changed. Before a binary search, one heuristic attempt.

Anonymous’s picture

Anonymous’s picture

Hm. Revert *.yml of modules and themes not helped :( Okay, I'll try to find a topic after which problem gone. Most likely this will not help, because after it many changes can affect on the graph. But anyway.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Well, #153 red, #150 green. So, after #2569805: For Drupal migration, identify the source module (commit d7c496150e....) the problem again became elusive 😥
I tried to roll back the patch from #2569805:

  • via quickly revert the patch with cancel all a collision parts (#154).
  • via max restore the patch with revert all parts via revert few another issues (#155).

But it did not help. This confirms, that the problem with php 5.6 has not disappeared, but simply ceased to appear on this test :(

tacituseu’s picture

Lets try to make some use of those old logs then. Also re-queued #130 with 8.4.x and 8.3.x.

Status: Needs review » Needs work

The last submitted patch, 157: 2879048-157-graph-stress.patch, failed testing. View results

tacituseu’s picture

Status: Needs work » Needs review
FileSize
33.59 KB

Status: Needs review » Needs work

The last submitted patch, 159: 2879048-159-graph-stress.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Status: Needs work » Needs review
FileSize
33.6 KB

Yikes... this one, hopefully, without c&p/s&r errors.

Status: Needs review » Needs work

The last submitted patch, 161: 2879048-161-graph-stress.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Status: Needs work » Needs review
FileSize
33.75 KB

Status: Needs review » Needs work

The last submitted patch, 163: 2879048-163-graph-stress.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Status: Needs work » Needs review
FileSize
33.92 KB

Status: Needs review » Needs work

The last submitted patch, 165: 2879048-165-graph-stress.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tacituseu’s picture

Edit: No luck, previous patches were just figuring out how to get bootstrap.inc included, will try moving into Drupal\Tests\Core\Extension\ModuleHandlerTest next.

Anonymous’s picture

Title: Ignore: patch testing issue » Ignore: patch testing issue for #2919863
Issue summary: View changes
Related issues: +#2919863: Discover why gc_disable() during non-interactive install improves tests stability

Issue with info about this works #2919863: Discover why gc_disable() during non-interactive install improves tests stability

Changed IS, because ton of work has been done, and it will be more correct to make this issue more specialized.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Wim Leers’s picture

Per #169, #2871591: Allow ComplexData in TypedData to specify computed properties that should be exposed in normalization and other contexts risks being reverted unless we can figure out a work-around for the random fail on 5.5 (which btw is completely unsupported by the PHP team…)

#170 confirmed that this is a random fail. #173 is now attempting to check whether the patch of #129 fixes the random fail or not.

I'll be actively following this issue, ping me if you get stuck on something.

tacituseu’s picture

Test bots are having free space issues now ('Requeued after CI error.').

Anonymous’s picture

#174: Woot!

#175: not problem, just reduce the number of tests and combine EntityTestJsonInternalPropertyNormalizerTest + EntityTestHalJsonInternalPropertyNormalizerTest

If I understand correctly, then adding a couple of random module dependencies will fix the error, but first check that we haven't 'Requeued after CI error.' now.

The last submitted patch, 176: test-only.patch, failed testing. View results

Anonymous’s picture

tacituseu’s picture

@vaplas:
I think it needs manual cleanup when it gets out of space, but maybe it is enough for the instance to spin down after 2 hours.

Looking over the patch it doesn't seem like it touched anything that would affect ModuleHandler::buildModuleDependencies(), since it first failed on daily I checked commit history for that day:
113c6dc: #2840392: Enable BigPipe by default in the Standard install profile
2c2e85c: #2695109: Cache bins are not deleted when the module that declares them is uninstalled
3cadcd5: #2903161: Fix incorrect FieldFormatter id for "weight" field in base field definition in display options
1e85083: #2910682: Mark serializer encoders @internal

The last submitted patch, 181: 2879048-181-test-only-without-entity_test.data_types.schema.yml.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 183: 2879048-182-test-only-without-c74c39e.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Luck with random modules slightly smoothed my shame with the revert.

tacituseu’s picture

Great find :D, and it leads to ModuleHandler::buildModuleDependencies() too:
1. FunctionalTestSetupTrait::installModulesFromClassProperty():

$success = $container->get('module_installer')->install($modules, TRUE);

2. ModuleInstaller::install(array $module_list, $enable_dependencies = TRUE):

$module_data = system_rebuild_module_data();

3. system.module::system_rebuild_module_data():

$modules = _system_rebuild_module_data(); 
$modules = \Drupal::moduleHandler()->buildModuleDependencies($modules);

Edit: fixed call stack.

Anonymous’s picture

Excellent! I believe that we should apply #129 for php < 7. At least like workaround, because these random fails can stall the others issues.

tacituseu’s picture

Wim Leers’s picture

Why are all #189 patches green, but is #190 green?

Anonymous’s picture

Per #127:

increases reference count so the algorithm doesn't even try to collect it

In #189 collected more reference via

+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
@@ -229,13 +230,16 @@ public function buildModuleDependencies(array $modules) {
+    $do_not_collect[] = $sorted_graph;

+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
@@ -229,13 +230,16 @@ public function buildModuleDependencies(array $modules) {
+    $do_not_collect[] = $graph;

In #190 nothing is collected.

tacituseu’s picture

There's also a third option that keeping the references is padding the buffer with safe objects, makes the buffer go over GC_ROOT_BUFFER_MAX_ENTRIES, and the real trouble-maker doesn't get recorded and hence never attempted to be collected. Each of those arrays has hundreds of entries (300-400 AFAIR).
But #188 shows that just messing with this array/dependencies makes it green, so I'd bet on the source of the problem to be near that.

The last submitted patch, 194: 2879048-194-clone.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anonymous’s picture

Wim Leers’s picture

I have to say, it’s super impressive to see the two of you expertly analyzing this! 😮👏👏👏

Anonymous’s picture

@Wim Leers, your post is very inspiring, thank you so much!

The main brain in this analysis is @tacituseu, of course. I posting patches just to keep the company ;)


#196: it's interesting that with fails the buildModuleDependencies() works well as well as with passes:

Relevant logs are equivalent, so the error occurs after the all buildModuleDependencies() calls.

Anonymous’s picture

Looks like @alexpott made a patch with a fix #2921862-18: Segfault on PHP5.5 and PostgreSQL. But it will be nice to catch a specific line. Therefore the continuation.

drupal_flush_all_caches() works also well. Go next.

Anonymous’s picture

Hm.. or i'm or I miss something, or installDrupal() works like a charm too. Going to setUp().

Anonymous’s picture

I'm betting that this way will lead to some query to the database. Which collapses because of the bug in PHP. But what exactly?

tacituseu’s picture

Re #198: The problem with GC is it will almost never fail at the place the problem was introduced, only later when buffer is filled up and it automatically triggers gc_collect_cycles(). Also thought about trying to dissect it by placing gc_collect_cycles() at various places in code path until it starts to fail in exactly the same place each time.
This patch just checks if things move without old workaround.

Anonymous’s picture

Many thanks for the clarification. Most likely you are right, as always. I just want to finish the dissection for get the final fiasco. And one more suspect.

tacituseu’s picture

#202: Looks like removing the previous patch from DrupalKernel::initializeContainer() makes it go away too ;D.

Anonymous’s picture

tacituseu’s picture

Bunch of commits just went in, also test bots are having 'No space left on device' issues again.

Anonymous’s picture

@tacituseu, thanks for the warning, it saved me from panicking!

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Sorry for the bunch of patches without comments. Here are the current research.

#208 detects fail after get cid 'entity_base_field_definitions:entity_test_cache:en' from cache, when new FieldConfig entity call save().

#210 checks, that fail not occurs due to request to value from database. Because getMultiple() works good.

Maybe problem due to use incorrect value from cache later?

#211 tries to create a new entity without using the cache. At first it seemed to me that it helps, but the retest said otherwise.

Maybe creating FieldConfig entity only first signal of problem with outdate cache?

#212 tries to clear all cache bins at the beginning of the setUp(). And looks like it helps.

So, php 5.5/5.6 bug somehow violated the cache (in the database or references), and it becomes fatal?

Anonymous’s picture

I know what you're thinking:

  1. What the hell is he talking about?
  2. What kind of thing in bins, if it turns out such a mess?

I do not know, let's see!)

Anonymous’s picture

opps, 10 times it more than need. I will cancel these test by manual.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

FileSize
1.75 KB
1.57 KB
Anonymous’s picture

It can only mean one thing, I missed something between the #208 and #210. I have a guess, but first another test of this area.

Anonymous’s picture

Okay. I can only explain this by bug in gc_collect_cycles. While I was catching a bug without creating new variables (just a pair of global variables with primitive values), I walked confidently in one direction. Example, all fails in #208 occur after cacheGet with cid 'entity_base_field_definitions:entity_test_cache:en' (I added a few more runs now, and this behavior has remained)

But in #225 I added a lot more variables to save the intermediate results, and the fail went to a completely different place. See also #202 explanation from @tacituseu.

Why #224 passed? These cids are not created/used in any way on the scanned area (created and save FieldConfig instance). So, most likely it's just another random action, that prevents the appearance of a bug.

Once again I apologize for all this noise. Now I'm on my own skin checked the insidiousness of gc :(

Anonymous’s picture

#2921862: Segfault on PHP5.5 and PostgreSQL was fixed! And most likely we will use this approach further, if necessary. Do you mind if I close the issue? Because it already contains a tone of patches, interfering with comfortable work.

tacituseu’s picture

+1 for closing for now, event though it's bound to show up again as long as we're supporting 5.x.

What did we learn, Palmer? ;),

Anonymous’s picture

Status: Needs review » Fixed

xD

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.