Add plural labels to Entity Types in editor module [#2702695]

Problem/Motivation

As it has been introduced in #1850080: Entity type labels lack plurality, cannot generate UI text based on label if plural is needed now we have a way to specify plural label for any entity type. Let's do it for Editor module.

Proposed resolution

Add plural labels to all entity types defined by Editor module. More information can be found in the change record: https://www.drupal.org/node/2689949

Remaining tasks

Write the patch.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Comment	File	Size	Author
#3	2702695-3.patch	618 bytes	ciprian.stavovei
#3	8.1.x: PHP 5.5 & MySQL 5.5 18,530 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 April 2016 at 13:36

ciprian.stavovei created an issue. See original summary.

Comment #2

ciprian.stavovei CreditAttribution: ciprian.stavovei commented 8 April 2016 at 13:52

Issue summary:	View changes
Issue tags:		+DCTransylvania

Comment #3

ciprian.stavovei CreditAttribution: ciprian.stavovei for ASSIST Software SRL commented 8 April 2016 at 14:27

Assigned:	ciprian.stavovei	» Unassigned
Status:	Active	» Needs review

File	Size
2702695-3.patch	618 bytes
8.1.x: PHP 5.5 & MySQL 5.5 18,530 pass

I fixed it with the help of Amateescu at Drupal Camp TRransylvania.

Comment #4

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 11 April 2016 at 14:01

Title:	Add plural labels to Entity Types in Editor module	» Add plural labels to Entity Types in editor module
Status:	Needs review	» Reviewed & tested by the community

Thank you! :)

Just one remark:

+++ b/core/modules/editor/src/Entity/Editor.php
@@ -16,6 +16,12 @@
  *   label = @Translation("Text Editor"),
+ *   label_singular = @Translation("Text Editor"),
+ *   label_plural = @Translation("Text Editors"),
+ *   label_count = @PluralTranslation(
+ *     singular = "@count Text Editor",
+ *     plural = "@count Text Editors"

They're consistently capitalized, but I wonder if they should actually all be lowercase?

Deferring that decision to a committer.

Comment #5

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 11 April 2016 at 20:31

Status:

Reviewed & tested by the community

» Closed (duplicate)

Thanks @ciprian.stavovei and @Wim Leers. The question in #4 is one of the sorts of questions that should be handled on a single issue. So I am closing this as a duplicate of #2702683: Add plural labels to entity types and merging the patch in there. Please comment on there so we can make sure you get the issue credit for your work here!