#161 | test-classy-with-stable-full-1.patch | 194.36 KB | star-szr |
|
#156 | kittens-kittens.patch | 3.82 KB | lauriii |
|
#153 | classy-stable-chickens-eggs.patch | 1.27 KB | star-szr |
|
#151 | classy-stable.patch | 388 bytes | star-szr |
|
#148 | allow_base_themes_to-2574975-17.patch | 2.8 KB | star-szr |
|
#145 | hidden-themes.patch | 10.6 KB | star-szr |
|
#142 | add_a_stable_base_theme-2575421-92-test.patch | 162.6 KB | star-szr |
|
#139 | 2575421-71-add-stable-theme-libraries2.patch | 181.79 KB | star-szr |
|
#136 | 2575421-71-add-stable-theme-libraries.patch | 195.97 KB | star-szr |
|
#133 | add_a_stable_base_theme-2575421-33-test.patch | 10.52 KB | star-szr |
|
#128 | add_a_stable_base_theme-2575421-19-test2.patch | 9.71 KB | star-szr |
|
#128 | add_a_stable_base_theme-2575421-19-test1.patch | 11.01 KB | star-szr |
|
#124 | safe-theme-1.patch | 1.3 KB | star-szr |
|
#119 | add_twig_filter_for-2571561-8.patch | 5.74 KB | star-szr |
|
#117 | twig_2.x-make_necessary_changes-2568181-23-testmillion.patch | 381.44 KB | star-szr |
|
#115 | test-twig-html-strategy.patch | 737 bytes | star-szr |
|
#113 | remove_race_condition-2571817-2-test.patch | 17.18 KB | star-szr |
|
#111 | twig_2.x-make_necessary_changes-2568181-23.patch | 375.27 KB | star-szr |
|
#109 | make_necessary_changes-2568181-23.patch | 9.94 KB | star-szr |
|
#108 | twig_2.x-make_necessary_changes-2568181-23-test.patch | 361.59 KB | star-szr |
|
#107 | upgrade_to_twig_1_22-2568171-73-test.patch | 59.9 KB | star-szr |
|
#98 | upgrade_to_twig_1_dev-uncomment.patch | 60.46 KB | star-szr |
|
#97 | upgrade_to_twig_1_dev.patch | 60.53 KB | star-szr |
|
#1 | 7269-194-minimum-test.patch | 142.63 KB | star-szr |
|
#1 | interdiff.txt | 1.99 KB | star-szr |
#4 | 7269-194-wip1.patch | 167.53 KB | star-szr |
|
#4 | interdiff.txt | 29.04 KB | star-szr |
#6 | 7269-194-wip2.patch | 166.54 KB | star-szr |
|
#6 | interdiff.txt | 1018 bytes | star-szr |
#8 | ignore_patch_testing-2426563-8.patch | 94.79 KB | joelpittet |
|
#10 | interdiff.txt | 7.05 KB | joelpittet |
#10 | ignore_patch_testing-2426563-10.patch | 171.64 KB | joelpittet |
|
#11 | 2429447-test.patch | 46.98 KB | dawehner |
|
#13 | 2429447-13.patch | 78.6 KB | dawehner |
|
#16 | 2426563-16.patch | 103.99 KB | dawehner |
|
#18 | 2348747-64.patch | 575 bytes | star-szr |
|
#20 | 2348747-64-with-twig.patch | 9.57 KB | star-szr |
|
#21 | twig-views-view-fields-2348747-46-interdiff.txt | 1.45 KB | Manuel Garcia |
#24 | 1944572-41.patch | 2.68 KB | star-szr |
|
#26 | 1944572-41b.patch | 2.73 KB | star-szr |
|
#26 | interdiff.txt | 587 bytes | star-szr |
#27 | 1944572-43.patch | 14.51 KB | star-szr |
|
#28 | test-toolbar-selector.patch | 522 bytes | star-szr |
|
#29 | 2426563-29.patch | 5.42 KB | dawehner |
|
#31 | field-parent-initial.patch | 1.25 KB | star-szr |
|
#31 | form-file-initial.patch | 2.49 KB | star-szr |
|
#31 | form-item-initial.patch | 20.3 KB | star-szr |
|
#31 | form-item--initial.patch | 14.8 KB | star-szr |
|
#31 | form-type--initial.patch | 5.87 KB | star-szr |
|
#31 | form-required-initial.patch | 13.2 KB | star-szr |
|
#31 | form-submit-initial.patch | 2.98 KB | star-szr |
|
#31 | text-forms-initial.patch | 4.49 KB | star-szr |
|
#31 | form-wrapper-initial.patch | 5.93 KB | star-szr |
|
#32 | form-submit-full.patch | 3.72 KB | star-szr |
|
#32 | form-item-full.patch | 21.95 KB | star-szr |
|
#32 | form-file-full.patch | 8.32 KB | star-szr |
|
#32 | form-item--full.patch | 17.89 KB | star-szr |
|
#32 | field-parent-full.patch | 1.83 KB | star-szr |
|
#37 | form-type--full.patch | 5.91 KB | star-szr |
|
#37 | form-required-initial2.patch | 11.41 KB | star-szr |
|
#38 | 2273925-test-contextual.patch | 16.09 KB | star-szr |
|
#40 | upgrade_path_plan_to-2555243-24.patch | 354.25 KB | star-szr |
|
#42 | interdiff.txt | 1.03 KB | star-szr |
#43 | upgrade_path_plan_to-2555243-25.patch | 354.58 KB | star-szr |
|
#43 | interdiff.txt | 592 bytes | star-szr |
#47 | upgrade_path_plan_to-2555243-26.patch | 355.36 KB | star-szr |
|
#47 | interdiff.txt | 798 bytes | star-szr |
#48 | upgrade_path_plan_to-2555243-26-2.patch | 355.35 KB | star-szr |
|
#48 | interdiff.txt | 786 bytes | star-szr |
#54 | upgrade_path_plan_to-2555243-28.patch | 355.46 KB | star-szr |
|
#54 | interdiff.txt | 900 bytes | star-szr |
#55 | upgrade_path_plan_to-2555243-28-2.patch | 356.33 KB | star-szr |
|
#55 | interdiff.txt | 1.28 KB | star-szr |
#60 | upgrade_path_plan_to-2555243-28-3.patch | 356.82 KB | star-szr |
|
#60 | interdiff.txt | 921 bytes | star-szr |
#61 | upgrade_path_plan_to-2555243-28-4.patch | 358.61 KB | star-szr |
|
#61 | interdiff.txt | 2.68 KB | star-szr |
#66 | upgrade_path_plan_to-2555243-28-5.patch | 359.64 KB | star-szr |
|
#66 | interdiff.txt | 2.45 KB | star-szr |
#69 | upgrade_path_plan_to-2555243-28-5.patch | 359.64 KB | star-szr |
|
#70 | upgrade_twig_test_1.x-1.patch | 42.46 KB | star-szr |
|
#72 | upgrade_twig_test_1.x-2.patch | 42.46 KB | star-szr |
|
#73 | interdiff.txt | 3.77 KB | star-szr |
#76 | upgrade_twig_test_clean_1.x.patch | 30.65 KB | star-szr |
|
#81 | upgrade_twig_test_1.x-3.patch | 42.67 KB | star-szr |
|
#84 | upgrade_twig_test_1.x-4.patch | 42.98 KB | star-szr |
|
#87 | upgrade_twig_test_1.x-5.patch | 43 KB | star-szr |
|
#89 | upgrade_twig_test_1.x-cache2.patch | 57.15 KB | star-szr |
|
#90 | upgrade_twig_test_1.x-cache3.patch | 57.19 KB | star-szr |
|
#93 | upgrade_twig_test_1.x-cache4.patch | 68 KB | star-szr |
|
#94 | upgrade_twig_test_1.x-cache5.patch | 67.69 KB | star-szr |
|
#95 | upgrade_twig_test_1.x-cache6.patch | 67.3 KB | star-szr |
|
#96 | upgrade_to_twig_1_22-2568171-68.patch | 60.05 KB | star-szr |
|
#96 | upgrade_to_twig_1_22-2568171-72.patch | 60.11 KB | star-szr |
|
Comments
Comment #1
star-szrSee what breaks for now.
Comment #2
star-szrComment #4
star-szrComment #6
star-szrComment #7
ParisLiakos CreditAttribution: ParisLiakos commentedgreat, looks good and not that bigger..lets take it to tha main issue?
Comment #8
joelpittetComment #10
joelpittetComment #11
dawehner.
Comment #13
dawehner.j
Comment #14
dawehner.
Comment #16
dawehnerNext one
Comment #18
star-szrComment #19
star-szrComment #20
star-szrComment #21
Manuel Garcia CreditAttribution: Manuel Garcia commentedI've been testing this patch, and all seems in order. Malicious code is still escaped as expected, for example:
Tried entering
<script>alert('hacked');</script>
as a class for a field, the result isclass="scriptalerthacked-script"
.I also tried a variety of other strings, everything is secured by twig, as expected.
I do have one question on this patch though, ran an interdiff with the latest patch on the main issue (#46), which you can find attached.
My question is on this part:
And:
Is this on preparation for a test or?
Comment #22
star-szr@Manuel Garcia where are you seeing those changes? Did you forget to rebase maybe? I'm not seeing those in the patch in #18 or #20.
Comment #23
Manuel Garcia CreditAttribution: Manuel Garcia commentedOh my god Cottser sorry... thats coming because I have another patch applied to fix the problem with devel_generate.. #2422101: CommentItem should override the generateSampleValue method and provide sample values... please ignore.
I think we are ready to put this into the main issue, will do that now, thanks!
Comment #24
star-szrComment #26
star-szrComment #27
star-szrComment #28
star-szrComment #29
dawehnerJust research.
Comment #31
star-szrInitial versions first.
Comment #32
star-szrAnd updated ones where applicable.
Comment #37
star-szrComment #38
star-szrComment #40
star-szrComment #42
star-szrInterdiff for the last one, note that this hacks vendor, see https://github.com/twigphp/Twig/issues/1811
Comment #43
star-szrShould be greener :)
Comment #47
star-szrShould fix one fail or so. But I think adding Twig extensions is broken still.
Comment #48
star-szrComment #53
star-szrThat's why I shouldn't patch past midnight in most cases.
Comment #54
star-szrWon't be green but should have better syntax ;)
Interdiff is from #47…
Comment #55
star-szrTurns out Drupal\system\Tests\Theme\TwigExtensionTest is not passing for me locally even on HEAD.
So just adding some other stuff here to play with, test extension shouldn't be setting a bad example extending core's extension.
Comment #60
star-szrComment #61
star-szrComment #62
star-szrYeah it doesn't help for running this test locally when you have a twig_extension_test.twig.test_extension service in your contrib modules folder from playing around months ago :(
Comment #66
star-szrGetting closer…
In theory all that's left is resolving Drupal\Tests\Core\Template\TwigExtensionTest that doesn't seem to like the 't' and 'trans' filters we have defined because
callable
is now hinted and I guess it's not able to resolve 't' from bootstrap.inc because unit tests?Comment #69
star-szrDoesn't have the new cache class yet but it's all I have time for at the moment. This is 1.x.
Comment #70
star-szrOops wrong file.
Comment #72
star-szrComment #73
star-szrIt's good to learn things.
Comment #76
star-szrNo other changes just the upgrade to see what happens.
Comment #81
star-szrFaking the cache for now.
Comment #84
star-szrHmm forgot to include the new class.
Comment #87
star-szrComment #89
star-szrComment #90
star-szrComment #93
star-szrComment #94
star-szrThis just removes an unneeded (old) class TwigCache that I added earlier as a temporary measure.
Comment #95
star-szrRemoves changes from #2567139: Twig autoescape default strategy deprecation error triggered on every page load.
Comment #96
star-szrComment #97
star-szrComment #98
star-szrComment #107
star-szrComment #108
star-szrComment #109
star-szrComment #111
star-szrComment #113
star-szrComment #115
star-szrComment #117
star-szrComment #119
star-szrComment #124
star-szrComment #127
adamjuran CreditAttribution: adamjuran at Forum One commentedComment #128
star-szrComment #133
star-szrComment #136
star-szrComment #139
star-szrComment #142
star-szrComment #145
star-szrComment #148
star-szrComment #151
star-szrComment #153
star-szrComment #156
lauriiiAt least its a start
Comment #161
star-szrComment #169
dpiDead