External Avatar support

halkeye - October 28, 2007 - 23:20
Project:Drupal
Version:7.x-dev
Component:user system
Category:feature request
Priority:normal
Assigned:Unassigned
Status:patch (code needs work)
Description

With the current implementation of user avatars, no module can support external avatars without adding custom theme code.

This patch will allow external urls to be set for user->picture but it will be up to modules to set that properly.

AttachmentSize
user.module.external.patch493 bytes

#1

catch - October 29, 2007 - 00:12
Category:bug report» feature request
Status:active» patch (code needs review)

This is a patch, and a feature request.

#2

Wim Leers - October 29, 2007 - 00:41
Status:patch (code needs review)» patch (code needs work)

An additional space is needed between the comma and "TRUE".

#3

halkeye - October 29, 2007 - 01:09
Status:patch (code needs work)» patch (code needs review)

updated

AttachmentSize
user.module.external_0.patch494 bytes

#4

earnie - October 29, 2007 - 12:03
Status:patch (code needs review)» patch (code needs work)

Shouldn't the administrator be given an option to allow external URL for the avatar? I can see this being an issue for some.

#5

catch - October 29, 2007 - 12:16

Should definitely be an admin option since this opens up user privacy issues yeah.

#6

halkeye - October 29, 2007 - 17:11

I don't see why an admin needs the option for this patch, nor any privacy issues.

All it does is allow modules to set $user->picture to a url instead of only allowing local files, there shouldn't be a way, with drupal core, to set this to a url.

Can someone show me where I'm wrong about this?

#7

earnie - October 29, 2007 - 18:14
Version:6.x-dev» 7.x-dev

All it does is allow modules to set $user->picture to a url instead of only allowing local files, there shouldn't be a way, with drupal core, to set this to a url.

I don't know what you're trying to say. User.module is a Drupal core module. Allowing external links for the avatar should be a choice that I (as administrator) need to make. External links could cause issues with the page display. Even if I allow them I may want to temporarily not allow them for network issue reasons. I for one wouldn't allow a user to use external links for the avatar to begin with.

Drupal version 6.x is closed to new features so I've moved the issue to version 7.x.

 
 

Drupal is a registered trademark of Dries Buytaert.