Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
@Tessa could you create an 8.x branch?
I'm porting this module to Drupal 8 here at Drupalcon Dublin.
Release blockers:
Comment | File | Size | Author |
---|---|---|---|
#2 | guardian-d8-2809687-2.patch | 22.31 KB | askibinski |
Comments
Comment #2
askibinski CreditAttribution: askibinski at ezCompany commentedHere's the patch! I'm marking this 'needs review' although I know it needs some work and testing. But also because I would like have answers/comments on below remarks. Keep in mind this is an initial patch.
* I obviously already did some refactoring, but I think some parts can still be optimized
* hook_init is replaced by an event_subscriber Service
* most logic is now in the Guardian class, still some hooks present in .module and .install
* configuration API: I'm not sure about the naming convention: I moved th to variables hours and mail to guardian.global.hours and guardian.global.mail
* Is it possible to do $this->account = \Drupal::currentUser(); without using the global?
* there is no D8 equivalent for element_get_visible_children() see line 101 guardian.module so don't know how to do this.
* made a scaffold phpunit test, needs work
TODOS:
* Needs testing! I did some basic testing but running out of time here so there are probably bugs...
* needs phpunit/kernel tests
Comment #3
Tess BakkerBranch created, http://cgit.drupalcode.org/guardian?h=8.x-1.x
Comment #5
Tess BakkerAdded some sub-issues.
Comment #6
Tess BakkerComment #8
Tess BakkerComment #13
Tess Bakker