CKEditor uses the automatically generated ID attribute for the body field in the ARIA label

This is a tricky one, but I can't see where else it would be. I haven't tried this in a new install, but..

Nope.. that doesn't fix it..

So this is grabbing the form element's ID, which isn't going to be changed, right? Combined with the fact that it is coming from a vendor asset, is there really anything that can be done? Wouldn't this have to be a fix requested in the CKEditor project?

I just checked it out in the CKEditor demo and it's the same issue there.

http://ckeditor.com/demo

Before marking an accessibility bug here http://dev.ckeditor.com/query?status=!closed&component=Accessibility

What do we want CKEditor to do?

There may be multiple machine names.

Rather than saying:
<span id="cke_editor1_arialbl" class="cke_voice_label">Rich Text Editor, editor1</span>

Would it be better to:

• Define which Rich Text Editor
• Pull a name from the label for the input field rather than just the ID
• Include different information if there were more than one Rich Text Field available

What else?

From a user standpoint, using "Rich Text Editor" I think is better than "CKEditor" which a user won't understand.

Pulling it from the label would probably be ideal, as it is already there.

<label for="edit-body-0-value">Body</label>

If there is more than one, it already increments, though in reverse order? 3, 2, 1 ...

The root cause for this is that CKEditor generates Rich Text Editor, <editor's name attribute> as the label. And the editor's name is http://docs.ckeditor.com/#!/api/CKEDITOR.editor-property-name, which in turns is retrieved/generated as follows:

Note: It will be originated from the ID or name attribute of the element, otherwise a name pattern of 'editor{n}' will be used.

I'm talking to the CKEditor developers to figure out the correct way to solve this.

Most likely, we've found a bug in CKEditor. The ARIA label should use the editor's "title", which is configurable, but it turns out it's using the editor's "name", which we cannot configure. I filed a CKEditor ticket: https://dev.ckeditor.com/ticket/12204, where you can find more details.

(Changing the name attribute in Drupal is not an option, because the label may contain characters that are invalid for the name attribute.)

Marking as postponed because this is blocked on an upstream issue.

The bug in CKEditor has been fixed. It will be included in next week's CKEditor 4.4.4.

Lovely! I'll roll a patch here once 4.4.4 is released, but I'll first need to update Drupal 8's CKEditor to 4.4.4 then :)

@Wim Leers - is there an existing issue for that? Would be great to ensure that D8 gets released with 4.4.4.

#12: yes, #2271051: Update CKEditor library to 4.4.4. :)

#2271051: Update CKEditor library to 4.4.4 landed, so now this is unblocked! :)

Changed the title of the editor to next format: Rich Text Editor, {label of attached field} field

Forgot patch#15, attached the new version!

+++ b/core/modules/ckeditor/js/ckeditor.js
@@ -11,6 +11,9 @@
+      var label = $('label[for=' + element.getAttribute('id') + ']').text();
+      format.editorSettings.title = Drupal.t("Rich Text Editor, !label field", {'!label': label});

Looks great!

But let's add a comment to explain that this is the label used by screenreaders.

Perhaps something like Set a title on the CKEditor instance that includes the text field's label, so that screen readers say something that is understandable for end users.
?

Added the comment to the patch.

Just one more nitpick round…

+++ b/core/modules/ckeditor/js/ckeditor.js
@@ -11,6 +11,11 @@
+      //Set a title on the CKEditor instance that includes the text field's label,
+      //so that screen readers say something that is understandable for end users.

Please change to one leading space and wrap at 80 cols.

Changed the comments layout

+++ b/core/modules/ckeditor/js/ckeditor.js
@@ -11,6 +11,13 @@
+      // for end users.
+
+      var label = $('label[for=' + element.getAttribute('id') + ']').text();

You added this blank line, which sadly needs to be removed. Hopefully this is the last reroll!

No blank line anymore

just re-rolled #22.

Committed 1e727b3 and pushed to 8.0.x. Thanks!