The taxonomy breadcrumb uses normal l($current->name, taxonomy_term_path($current)) links versus using the taxonomy_term_path to generate the links to the taxonomy terms. Same goes to the taxonomy feeds domain. The should, at least in my opinion use the taxonomy_term_path.

CommentFileSizeAuthor
#7 190850-term-path-d6.patch1.8 KBandypost
#7 190850-term-path-admin-d6.patch2.64 KBandypost
#3 taxonomy_breadcrumb[1].patch1.66 KBrobin monks
#1 taxonomy.module.patch593 bytesPoetro
#1 taxonomy.pages.inc.patch609 bytesPoetro
taxonomy.pages_.inc_.patch609 bytesPoetro
taxonomy.module.patch593 bytesPoetro

Comments

Poetro’s picture

Poetro commented
StatusFileSize
new taxonomy.pages.inc.patch609 bytes
new taxonomy.module.patch593 bytes

Wrong order for patch, attached correct one.

birdmanx35’s picture

birdmanx35 commented
Version: 6.x-dev » 7.x-dev

This is a feature request, and feature requests go to 7.x-dev.

robin monks’s picture

robin monks commented
Category: feature » task
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new taxonomy_breadcrumb[1].patch1.66 KB

Rerolled, with no change in functionality. Also did some testing and it all looked good. Moving to task, and marking as reviewed.

Robin

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Huh. I had no idea there was a hook_term_path(). :)

Looks like a good clean-up. Taxonomy tests continue to pass. Committed. Marking back to 6.x for consideration.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 7.x-dev » 6.x-dev

Sigh. :P

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Category: task » bug
Status: Reviewed & tested by the community » Needs work

I consider this a bug fix, since taxonomy paths are supposed to be overridable by modules. This is what forum module does. So we should use the overridable function instead of hardcoding paths. However, the patch does not apply to Drupal 6:

$ patch -p0 < taxonomy_breadcrumb\[1\].patch.txt 
patching file modules/taxonomy/taxonomy.module
Hunk #1 FAILED at 1223.
1 out of 1 hunk FAILED -- saving rejects to file modules/taxonomy/taxonomy.module.rej
patching file modules/taxonomy/taxonomy.pages.inc
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED -- saving rejects to file modules/taxonomy/taxonomy.pages.inc.rej

Waiting for reroll.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 190850-term-path-admin-d6.patch2.64 KB
new 190850-term-path-d6.patch1.8 KB

Suppose the admin screen should display altered links too.
D7 uses hook_url_alter_outbound() so this patch only for D6

Status: Needs review » Needs work

The last submitted patch, taxonomy_breadcrumb[1].patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.